From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15A5036829B for ; Sun, 26 Jul 2026 13:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785073246; cv=none; b=NTfNrrGHuG8y8jsqmBaovj+H0vB1Mg/aeMd+k+vgotpGIMgkl1/vcWxdnReNtbTTNRVnvJyUeJ07MOxX+CJ2+ApLKZHidOc03064fjxb0B26vh2LjQ5LBs3nQlAIeAuHhFRRdE+DtIQVZKNwqwM4u6g8sARayJe4XpcYWRU/cKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785073246; c=relaxed/simple; bh=XUlAB99EUPHGjfNDCkjkwUX6kHPjQ6HNWiYkPAgR9jY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HoF94JPeJsA+7ZK2s/yIupxa63zL6Y5C8y3AhSLK3NMwF36R5IQxrRIb98TzMH/gi9BYZt4Ca11lsyxgMGHMJgIKjSVQ8uyXQGSc2X1lB79QuOszH08aSXVj7UA3mdGxurYKsb6Z5lgmEvB72Nme6ZrlWl1OU+Ey7kQ1ulAL3Mw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FoN6EhdZ; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FoN6EhdZ" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-84e27035206so1804016b3a.3 for ; Sun, 26 Jul 2026 06:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785073244; x=1785678044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4dRKslA0KH8ziQVxUICHViYTgpblUQ8JSWEDZ5wzIhI=; b=FoN6EhdZulSBoVVjQwOiRM2QpdTEBmtuL9hyWOYsYClOzmcF53KCZ0wvn+U8sWtqml uzluK5qPXI+P92zyy2do1uK0wxYYcRPENr3bj2Zcl/yzU/kPoOumzuPiO9tgW+/fg+aJ SWEm7aRVhslh6c29epMCi9U3m5UYh0UnwwT9oe014EAu7Vy8GkgkIgS2kJf1z9fbhi95 JtCNdtHHwKvG7zMTTTil+ZgLvW5fq6V/ND5Ovaa0OXREMJwxd/0Hem++saLcuAeIAlPE qGDg6Ru8hFEN/Lis1saWMgZcIyZtVO4X/p+6P+OCY7k619IdCIb0k2Pol2wGhV6yjoJt QCEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785073244; x=1785678044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4dRKslA0KH8ziQVxUICHViYTgpblUQ8JSWEDZ5wzIhI=; b=keltXG+SfDrML6+JdIFbN3K/Sm+Y8na/+cGO27wij6igMD6tC2jgWIK6MSh5Rer/Yf 6aH5PKYymGragkHu+yCc1Z4ptnWeoEw0dg8fpD/NRQjiGoRVVO3TgIILZmrHRd/PdECo QaEVKSmlddRadRvRFgB76tGIchWmfCAa/KIRi9m68uuBE3C+t9YZnDvd5e6EonPMhB4a nstzJYl+nM1Lx/13tBEYVl5UG/ZwuQo20hPIfGWScOYJKM6aCU2mHA+zbBgWXMnGMtk2 dvJsG20FRnFVlBhjDtHcdbG8Z3qCZ4qlbM8U/8PYP7OmJMM1zy6w5lIo7XTbhau6ewVc 9I5A== X-Gm-Message-State: AOJu0Yz1bWigcXeHWzMmWr3jXRh7EzflEuCdg1MnfP4IJBJ7vL9+YQ6q 5B2Mpz4eJlaP8W6YtJ4yXdigEgOMFjVV9zbXjyk/XZfrEo8bwt6Xh6fNf4xDnC7y X-Gm-Gg: AR+sD13iMaFbT8LOn+hWm8z+Z/yv+1BFrcD5LQY/guOIv/ErP4zmEHxa0yk9XyBQEbo H73H4L5w5JGwEpbkr8rZkOn2cOkucRWCYdIUvAQio3lFCtY1rT05KxwyQ2pziXpC1nwSBfH3fH0 sI7mSDumShJx+Qpq5hIdYpYHftrCmcO0hF/UqksEfo6Q0okf/i7QVVMM6Vy9QGOOue0HhMMcPZo ZXoHZT1YcQHi+kuYibpF8mhPxAvLtpU3pEzCJ84+zROX2yPNPzFzOLHhVn1oJZbccuPqRoqB4q/ jpE0k1BdDAm2NZOcDe7vBQE3dIzD6BKeY+7zVt9/Y8PX+UbqRLL/crjpgildABNFHu5nCMOchY7 NWaqKLoxWF34oCSVCK5ahR5+GOKQK0Dsik0XgBdVAO1BM1h9b8CatY8sIf2boT6QIx7s57Z2Y X-Received: by 2002:a05:6a00:2288:b0:848:2f84:733 with SMTP id d2e1a72fcca58-84e5959cb20mr3933797b3a.70.1785073244483; Sun, 26 Jul 2026 06:40:44 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e53254f57sm1873798b3a.1.2026.07.26.06.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 06:40:43 -0700 (PDT) From: Sang-Heon Jeon To: Ping-Ke Shih Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [PATCH rtw-next v2 2/2] wifi: rtw89: remove conditional return with no effect Date: Sun, 26 Jul 2026 22:40:31 +0900 Message-ID: <20260726134034.1385834-3-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260726134034.1385834-1-ekffu200098@gmail.com> References: <20260726134034.1385834-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/net/wireless/realtek/rtw89/mac.c | 6 +----- drivers/net/wireless/realtek/rtw89/mac_be.c | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c index db9fca828829..2cbff2be9bbb 100644 --- a/drivers/net/wireless/realtek/rtw89/mac.c +++ b/drivers/net/wireless/realtek/rtw89/mac.c @@ -1710,11 +1710,7 @@ static int sys_init_ax(struct rtw89_dev *rtwdev) if (ret) return ret; - ret = chip_func_en_ax(rtwdev); - if (ret) - return ret; - - return ret; + return chip_func_en_ax(rtwdev); } const struct rtw89_mac_size_set rtw89_mac_size = { diff --git a/drivers/net/wireless/realtek/rtw89/mac_be.c b/drivers/net/wireless/realtek/rtw89/mac_be.c index 8de0fe5a3b1d..dfa0973e367c 100644 --- a/drivers/net/wireless/realtek/rtw89/mac_be.c +++ b/drivers/net/wireless/realtek/rtw89/mac_be.c @@ -929,11 +929,7 @@ static int sys_init_be(struct rtw89_dev *rtwdev) if (ret) return ret; - ret = chip_func_en_be(rtwdev); - if (ret) - return ret; - - return ret; + return chip_func_en_be(rtwdev); } static int mac_func_en_be(struct rtw89_dev *rtwdev) -- 2.43.0