From: Zhao Li <enderaoelyther@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Mark Brown <broonie@kernel.org>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Pagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>
Subject: Re: linux-next: manual merge of the wireless-next tree with the origin tree
Date: Mon, 27 Jul 2026 00:41:56 +0800 [thread overview]
Message-ID: <20260726164156.71624-1-enderaoelyther@gmail.com> (raw)
In-Reply-To: <b99e4a1428546030b61883063b9542dd953a69f2.camel@sipsolutions.net>
On Sun, 26 Jul 2026 12:33:13 +0200, Johannes Berg wrote:
> But because I don't think (a) we should fix that in the merge, and (b)
> it's actually very important, I'm just going to leave it as
> "notify_driver".
I traced both paths again and I agree with you. Retrying against a broken
AP is the better failure mode than confusing the driver, and the trigger
needs an AP that reports success without an AID Response element, so it is
not worth changing the merge resolution.
> If we actually observe this in practice and want to get rid of the time
> wasting, I guess we could add a path out that does both, but I'm not
> sure it's worth it.
For the record, destroy_assoc_data already does both. Since f13e573ab3f12
moved drv_mgd_complete_tx() into ieee80211_destroy_assoc_data(), that label
notifies the driver before the link is torn down, then abandons. No
additional path would be needed. The impact is negligible either way, so I
agree it is not worth touching now.
Thanks for looking at it.
Zhao
next prev parent reply other threads:[~2026-07-26 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 15:57 Mark Brown
2026-07-22 20:53 ` Enderaoe Lyther
2026-07-23 11:51 ` Mark Brown
2026-07-23 20:21 ` Zhao Li
2026-07-26 10:33 ` Johannes Berg
2026-07-26 16:41 ` Zhao Li [this message]
2026-07-26 17:02 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2024-10-09 0:35 Stephen Rothwell
2024-10-09 7:12 ` Johannes Berg
2022-02-22 16:12 broonie
2022-02-22 16:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726164156.71624-1-enderaoelyther@gmail.com \
--to=enderaoelyther@gmail.com \
--cc=broonie@kernel.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome