From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B2993033D6 for ; Sun, 26 Jul 2026 18:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785089035; cv=none; b=NBUWAGbx6/eOvnY4LcdKtI9x8GVd6Rn8HRVO/V3LQpl5e4amE9Z0c8rdFkIsPmqW0dINFH1B4UhHN+exVoL9MxehtjlFZlUqLV59PvNuBI3hPvYvEOTKyfuz2f/Ig7DlybCGKO4EoLL5pA6nX58p4KkQAhRpUc6K6MSls7rofTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785089035; c=relaxed/simple; bh=q9dAk8eF3iiJ+cl/0uS54dQjKdefX8YMOgEw3GcSL6o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Put8rpJCT04oxg5qaSVLEiHRFECKR7u7aE8zFk7/Z0hwX6xA1v6oT9dA1SdGzv+hpMnKKDVqDF+qWLQqRVKY7S5hiK4ycKs1oyBbsY1rdNlzlETClkrUQ/VPlk2JmC/SC6jz95BnE5Bl3rZJBTplBgyQTTiA0+EMRdVRbqbRMyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sF554Ke1; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sF554Ke1" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-ca80d708489so1305018a12.1 for ; Sun, 26 Jul 2026 11:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785089034; x=1785693834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=PdwZxxP8oqz0gMmIElZLBFtAWKuHTGQms5/kGxcVlaA=; b=sF554Ke1PMvrl1QSPfxB+mWk4DuccVheqT9cTBhUrQfCVueRGeGvYvw0dNnYkr+ewY 9xRI03yO3kSfl5Vc/e0uLA1jArl6H70wBxTju2pnGI+fmHFSjUjIq/PPQiJ0O5sdzqws kgY8Z4ByJMYCwDUoK2pZnbXsePZP2+OoZgJ275DUFm7nWSsbcwm8ACTLVkuu6yJGBom2 WevuLyScGg0Nu6Liu88ILkh6Goz0r2l8ms7d4szecVEpcWw7NRKqR8FTJim6qp8SMAuT FVYef6NR+vYYpOypTwalDIFGcgwsIK6AS6hdisntBHGt5pOEoDGSrIf/xNCokvz7Suab PPHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785089034; x=1785693834; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PdwZxxP8oqz0gMmIElZLBFtAWKuHTGQms5/kGxcVlaA=; b=YJx4awRMNNxoFSKhCn61vTjBGeLUfzOdbzw6eUGj/r1xlsWd7nW9JdnlPTfkxBpr81 JZ9FtBcVW/GIDY0Pt2WZ7xRB2j9DU/uVVW3vBaxvu8BSZPTwSf1EhtiihIcPoQx9JuGa Vf6wJqTw2eptY1qTSw3cr2qsvGUgaTjQ3t2mQg/9Zdb9L1C1c95LZUWwG3pxt/DxNEJ0 VlzuFnYuXx3QxdcpZpSarV9WeKsKkOatbCcJUhdTmPQoM34pkdeA1wt+ISnmQqDPp/vT s3sTYu6jUd2jBEhhicRQxzNtTYGa7yD99DlOqxQWdp0QwODG/+mZgazkRd/YSmc1fmI5 PFug== X-Forwarded-Encrypted: i=1; AHgh+RrfZnrb7z/2lQeQ7kWGJhTr5U69gZ1KmRMWTOTfetYiusocsZfDLdK1zSpV/fiS1EWOVdLvhiy1dyP7U7g=@vger.kernel.org X-Gm-Message-State: AOJu0YwqBhl+UYKzs4h99jh6H9apLzSpDd9/axDul+s9YzTZWyQY9RTv /LEwAZlnrVWWuylbhrP5//8ZV8nnYGT+v55UBh6bgGWpHSKsF4JmWCF6 X-Gm-Gg: AR+sD10mL9dYdEUEi67N3PZlFNqJUqOBNPENYUl4F768575Qlv2PONz39+H8wO1yE/q D5+PL4YanLfiayFP2Ld0bl8TwT1Nn0USNsqCT9jQGB4QJIly5rwvUZ2ty8KaVRSS5cueSSJTuGR mGYCXlNqPTCJelxAj998b5KI3bhPe2N8GoODGFB2AD0lQpTxWwLmocEt4M8zZeemagEz2Od65C0 MT7Wtd2Rh4SXvx/oMAJTngl4YiSCXUZmaDaTCWSUXmUpw5rvrn2W3pw982rh6Jbgno+QJBKBiAp AkHEIkEZWJLELFRXSRZ6NAuYx05Re5n6IMLY0sYT+rz3RvncVZlWrCFYUk8p0bqA2j9EA1F3RxP DricLOJHMWxQz5Wa1ezQVSCSpG3RFAkD0KJg8Qd00Iz7MI41hCnipeOcVfR5TcQT2M63irDJarU ZFthb8dekiirs= X-Received: by 2002:a05:6a21:6b8c:b0:3c3:8315:80b6 with SMTP id adf61e73a8af0-3c67267e948mr7535903637.32.1785089033798; Sun, 26 Jul 2026 11:03:53 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:30b7:9ffb:4fac:ad00]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc3e1285sm24729671eec.5.2026.07.26.11.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 11:03:53 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Ray Jui , Scott Branden Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Broadcom internal kernel review list , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] iio: adc: bcm_iproc_adc: Use dev_err_probe() for resource acquisition failures Date: Sun, 26 Jul 2026 23:33:19 +0530 Message-ID: <20260726180319.315016-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid Replace open-coded dev_err() and error returns with dev_err_probe() for failures from syscon_regmap_lookup_by_phandle() and devm_clk_get() in the probe path. This simplifies error handling and properly handles deferred probing. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index cf4738b16e62..62f12eecc8b2 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -522,19 +522,16 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); - ret = PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(&pdev->dev, + PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); adc_priv->adc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, - "failed getting clock tsc_clk\n"); - ret = PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(&pdev->dev, + PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); adc_priv->irqno = platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) -- 2.43.0