From: Jonathan Cameron <jic23@kernel.org>
To: Gustavo Silva <gustavograzs@gmail.com>
Cc: "Pan Chuang" <panchuang@vivo.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Maxwell Doose" <m32285159@gmail.com>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Siratul Islam" <email@sirat.me>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe()
Date: Sun, 26 Jul 2026 21:16:01 +0100 [thread overview]
Message-ID: <20260726211601.2b7aef65@jic23-huawei> (raw)
In-Reply-To: <20260726210830.2eca3e9a@jic23-huawei>
On Sun, 26 Jul 2026 21:08:30 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Sat, 25 Jul 2026 20:16:15 -0300
> Gustavo Silva <gustavograzs@gmail.com> wrote:
>
> > On Fri, Jul 24, 2026 at 11:03:38AM +0800, Pan Chuang wrote:
> > > Since commit
> > > 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> > > devm_request_irq() and devm_request_threaded_irq() automatically log
> > > detailed error messages on failure. Remove the now-redundant
> > > driver-specific dev_err() and dev_err_probe() calls.
> > >
> > > Signed-off-by: Pan Chuang <panchuang@vivo.com>
> > > ---
> > > drivers/iio/chemical/ccs811.c | 4 +---
> > > drivers/iio/chemical/ens160_core.c | 2 +-
> > > drivers/iio/chemical/scd30_core.c | 2 +-
> > > 3 files changed, 3 insertions(+), 5 deletions(-)
> > >
> >
> > Reviewed-by: Gustavo Silva <gustavograzs@gmail.com> # for ens160
> >
>
> For some reason b4 is adding a review from Andy to this one
> that I can't find either locally or on the list (not for v1
> or this). I've edited it out by hand.
>
> Maxwell did give a tag though on v1 so I've kept that.
Ah. Andy did give it, and the author should have picked it up
after following the condition attached in reply to v1.
>
> Thanks,
>
> Jonathan
>
next prev parent reply other threads:[~2026-07-26 20:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 3:03 [PATCH v2 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-24 3:03 ` [PATCH v2 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 02/13] iio: addac: ad74413r: Remove redundant dev_err_probe() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-25 23:16 ` Gustavo Silva
2026-07-26 20:08 ` Jonathan Cameron
2026-07-26 20:16 ` Jonathan Cameron [this message]
2026-07-24 3:03 ` [PATCH v2 04/13] iio: st_sensors: Remove redundant dev_err() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 05/13] iio: gyro: adxrs290: Remove redundant dev_err_probe() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 06/13] iio: health: Remove redundant dev_err() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 08/13] iio: imu: " Pan Chuang
2026-07-24 3:03 ` [PATCH v2 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-24 3:03 ` [PATCH v2 11/13] iio: proximity: " Pan Chuang
2026-07-24 3:03 ` [PATCH v2 12/13] iio: light: " Pan Chuang
2026-07-24 3:03 ` [PATCH v2 13/13] iio: temperature: " Pan Chuang
2026-07-24 10:27 ` [PATCH v2 00/13] iio: Remove redundant error messages on IRQ request failure Joshua Crofts
2026-07-26 19:59 ` Jonathan Cameron
2026-07-26 20:24 ` Jonathan Cameron
2026-07-27 3:45 ` Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726211601.2b7aef65@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=gustavograzs@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=panchuang@vivo.com \
--cc=tduszyns@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®