From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE963ACF02 for ; Sun, 26 Jul 2026 23:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785107970; cv=none; b=lgK6EnHkZIsnioAJlG+/y8dv3t6ZvINp8TNfiYQGkV+Tavxoudat4sRa8eupNx/vSufw3av4ROz3o0YKWZ4kAhA8wGFnKfBA+L7jYoj9hBOISdrNr8P/yQ3xtCMsyo5Wa6bgGmZkuHPhXnYB5k45/YD46u/y+3x5jjdXaH3xdoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785107970; c=relaxed/simple; bh=v2kSmGUdsRV+012QSQjTrDQ+eXHAlOhF2KtRUdmgdkE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iScsiqVE6BrjSld85UmrJ+ZH9wd05NluRqAb3pnL3dDDoOF8zFsuKvs0SBIP4uuj+qpXFjEe7ZT97w0a2nu0YDx7jramlxMw8AaWOSk/VG5YNkepMd5GWnFP0fp+u/sZJFNyvF+uth9cd3TFyZ1rHFXsnpx3p0aD1d4TlrGUTng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cJBxLFAA; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cJBxLFAA" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cc97653887so24120225ad.1 for ; Sun, 26 Jul 2026 16:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785107967; x=1785712767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FxqUZKAau5p0iE2zHflVSScszcjRBB1eTtSQVoHDjq4=; b=cJBxLFAAaCMIeigpoETj9JIypmv4qSRgjhyn2vRmYY7KJgMSAQXdQ0AyX3U2aI7R1b lUyWxuer1Efl6/bqldNBVnvq0YOldXplNn0w6wa/2r1t8UWfKgmpNOUW7QrCNr0WK8GI V7l4RpgfPdhPTyheTpkLfi1tcgTfcMZnI0lIFdJrTzLyd4gg9cJNz6k+0kngjMT9iRHl VzsSdZSej3q1MR+RJTUV//T52UbUpYZQ/CJBtNOE9ZEp9HLSupg7usCy2elnVSxEgdRp 40QIJO7EdbhyEbZVEll/Gr6dtHxjdLDe4+FCG6UXKjIt+mAeFkl3C6I+XRGgu9xiQvDX ADFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785107967; x=1785712767; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FxqUZKAau5p0iE2zHflVSScszcjRBB1eTtSQVoHDjq4=; b=WmBXn3YtVZ9nxfBuXxO3rtYV5sG16lrrRwpE1UHyxSxUZ9UJmiMJ+mEb9Uzr9pTt+p ulPAuxTFNxm4dV2yqIp0E/JD+F0KembazqyzZP+zRA/rxYyEv7MeSTx14EZ4SYtUH3DN u6yDtueiNn7o4N8evL6jcH/SScw+zKnaDydXfMJjaXENTAs/8awlzFm/GNSKICMHb0yL 7lKejPxDSVZM4jgflW/L9HvXli+auQMTTkxdps8O6Cqcv9nDzVaav0wAdbif7SssJC2a zxjC0Y9N3B2ErTGCcjOozQMmsjka+Mc8MQ61LV0zqBtjeJpD6nMKnhgA3l0H7dR8ye45 Ox5A== X-Forwarded-Encrypted: i=1; AHgh+RrBGS40BOt9asxmMN0ISIdmeZvSUHYRaLNtKqQKDra6uCUOMNq2ha7zkWK+/Qiwr2+zecFtluXH0Bl4WOI=@vger.kernel.org X-Gm-Message-State: AOJu0YwUJ5J01Qph9uU7W5UK+mTd3qrlsJY0nfWcIlibbuKccG9UUu6Y ias4xsD+j2XGJtwCMD7G/xr+MrEsi+T6q9bLLwwlHJwPSbaj4giP41Yw X-Gm-Gg: AR+sD13r+lDVjJRIBY+ThOEFyJk1zi9dTJt1DfOmIvJs1zCbIFpin5Q5ZuB/VHu+F9S dUt6XIOFmtj/09DjVRk39iajc2aIKrZolBzP+DfbhF3JlCI9L/FSPhvw4DgXm5wcweW+UlaXovc ZSSJT98OwF8cEfL2kE+1ruY001ZE5mYYsg7viAl8vEibSpn3t64MilijjG8zsF2hqtJtbtEGQ1Y yqHd6Dr0m5KPv6YiX37Z1vjs20WqGjWLXi8yC0LSuyvY78sHNUwcHO5jxBZccWiU42ArxTEyHhv ZZRS1w67J7oeb60GRbnfBZRn6800Qr6iDOL5HLVOYcIYdd0mYorjLBXK4FO5xFdGCTzed7NTZC+ aTNrl2Tsnr/jWDM9j5zSdsFMzP2wPtzClnDhL2dUs9MelQd4a/qCPtT7+kkmYRg0L7+z6zpBHDW NuDqyUXyh+TfclHxctDWQoryB9LAi+onqk71Nz4q/5rTK2HF72zZugACVS3qxGN+NC0Cv28fVJZ u/ERfy0IRmQoncFJaYlBv6GKLgXZ99WCTTRW5tyP9LTQQ9EG0g1TV0= X-Received: by 2002:a17:903:1ae3:b0:2c9:c991:3bf0 with SMTP id d9443c01a7336-2cfde796a13mr59151255ad.8.1785107967076; Sun, 26 Jul 2026 16:19:27 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59b885sm24939315ad.15.2026.07.26.16.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 16:19:26 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Florian Fainelli , Jonas Gorski , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next] net: dsa: b53: srab: propagate errors from init helpers Date: Sun, 26 Jul 2026 16:19:24 -0700 Message-ID: <20260726231924.88459-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert b53_srab_prepare_irq() and b53_srab_mux_init() from void to int-returning functions so probe failures are properly propagated. b53_srab_prepare_irq() now returns -ENOMEM on allocation failure and -EPROBE_DEFER if any port IRQ is not yet available. b53_srab_mux_init() now returns PTR_ERR on ioremap failure instead of silently ignoring it. Check and propagate both return values in b53_srab_probe() so the driver core sees the real error instead of always reaching b53_switch_register(). Assisted-by: Opencode:Big-Pickle Signed-off-by: Rosen Penev --- drivers/net/dsa/b53/b53_srab.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c index b9939bbd2cd5..d34e1fa10c9e 100644 --- a/drivers/net/dsa/b53/b53_srab.c +++ b/drivers/net/dsa/b53/b53_srab.c @@ -531,7 +531,7 @@ static void b53_srab_intr_set(struct b53_srab_priv *priv, bool set) writel(reg, priv->regs + B53_SRAB_CTRLS); } -static void b53_srab_prepare_irq(struct platform_device *pdev) +static int b53_srab_prepare_irq(struct platform_device *pdev) { struct b53_device *dev = platform_get_drvdata(pdev); struct b53_srab_priv *priv = dev->priv; @@ -551,18 +551,22 @@ static void b53_srab_prepare_irq(struct platform_device *pdev) name = kasprintf(GFP_KERNEL, "link_state_p%d", i); if (!name) - return; + return -ENOMEM; port->num = i; port->dev = dev; port->irq = platform_get_irq_byname_optional(pdev, name); kfree(name); + if (port->irq == -EPROBE_DEFER) + return port->irq; } b53_srab_intr_set(priv, true); + + return 0; } -static void b53_srab_mux_init(struct platform_device *pdev) +static int b53_srab_mux_init(struct platform_device *pdev) { struct b53_device *dev = platform_get_drvdata(pdev); struct b53_srab_priv *priv = dev->priv; @@ -572,11 +576,11 @@ static void b53_srab_mux_init(struct platform_device *pdev) int ret; if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID) - return; + return 0; priv->mux_config = devm_platform_ioremap_resource(pdev, 1); if (IS_ERR(priv->mux_config)) - return; + return PTR_ERR(priv->mux_config); /* Obtain the port mux configuration so we know which lanes * actually map to SerDes lanes @@ -613,6 +617,8 @@ static void b53_srab_mux_init(struct platform_device *pdev) dev_info(&pdev->dev, "Port %d mode: %s\n", port, phy_modes(p->mode)); } + + return 0; } static int b53_srab_probe(struct platform_device *pdev) @@ -622,6 +628,7 @@ static int b53_srab_probe(struct platform_device *pdev) const struct of_device_id *of_id = NULL; struct b53_srab_priv *priv; struct b53_device *dev; + int err; if (dn) of_id = of_match_node(b53_srab_of_match, dn); @@ -651,8 +658,13 @@ static int b53_srab_probe(struct platform_device *pdev) platform_set_drvdata(pdev, dev); - b53_srab_prepare_irq(pdev); - b53_srab_mux_init(pdev); + err = b53_srab_prepare_irq(pdev); + if (err) + return err; + + err = b53_srab_mux_init(pdev); + if (err) + return err; return b53_switch_register(dev); } -- 2.55.0