From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632231A9FBD for ; Tue, 28 Jul 2026 00:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785198170; cv=none; b=jLDyKWY3hff1zXloOvU0qoAy3XGK19BY0hevq/XpAyrCY9OlFyn20HsKti4Zj0k6rkc1oY7lD6aunMj9YrLAf+j3Cd9PNUricAysMJZSweVpmfNRzigj92Ogk3i/BMkUY3xeHgdu9CuMKgnvb6BXL+2C5jdPUH9FP1QD1EAolBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785198170; c=relaxed/simple; bh=Vr6lYln3IIQd0jQpA8JmB1vRON4rBsCVrTFU2O+2vUI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mxa533ob8HkhtOXxGOf6Gl/k0QEYxDiw3n0d1ZBA0Si66fvwRV5gFhwZuDKhHTWiXOmcDPvgnTgF0YCcA9HRsvC3ZKGOLenoYvOeShxyw/aIxtFSmog+6Ksf0RLjczOUEDrGzyCVaVnAshNiEwZqVCsDKdCdy1vx8jTjzUB9mHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gHe6Vh3c; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gHe6Vh3c" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-81e83f1f15aso7076917b3.1 for ; Mon, 27 Jul 2026 17:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785198168; x=1785802968; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MEZmseVazoMVtdSfGMQhrKWqDNsvj4vIcTNUE+WpTkw=; b=gHe6Vh3clY0ap6nCPBrujBxNFHWOcZGQAIz5a0sd95eRGtZ1Wl3AdMwLvrQcfs5aPr HVpv4pxPYmrqgZlp77IC3kue+aP5RreLhDV6oDZ+SPOIaUSY1QF5kHhCy5uW+pdFbdRR NRkVeRPmmLx3XNO6VA4Oefx94FZ+o30LLEjIPvOfd+3CzZFj/IYrABP4u9LV+1arMA4U w0A5Ilk70M+XqN+Y2VYumBUF26m7HEyuWgqoBXIJS7gyEz4NjWKTwvC1mCcJ5Uum7Jaj D7XwkP73X60zSf+KTpf5snhaWgyr0Y6PEgv9LJklriv/1+sAt3scSl5CYwNgmmE9cwbV vL5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785198168; x=1785802968; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MEZmseVazoMVtdSfGMQhrKWqDNsvj4vIcTNUE+WpTkw=; b=Wn8CQ57FFiLQ2sw5uhDK1AbScoetgeICpoofnva2axdiMLil/p4UXOQAN5i+AtvYOd ytEobs2YjQE5GXIyMYO1OmxrVnpUE2H8LEPxHAg0WDJeAT7qo+2bmppCygamgI04EHc2 WspgfAUqw60uFWN5PqWFTVKu9BfUkPbwn1Y+oy1trnbH3Goz1fCMVXoOKnItS/vgHN+z R+n+D6Ymk45LsctSbIN8M/DmVxqILsuzyGcszqI0ytRgcG8lIVQbXHUjhTqiFyphdXez Vvt27mSZ336q+dFukCH6SE2SO4bcF/x4mGP5v2exs9seK/gnCQRzcMKYGoO5ep53F57A 31xg== X-Forwarded-Encrypted: i=1; AHgh+RplcdaAIkgpmCdrXcuIPLgblRnlud9X4EcZn49MxQWBW2FnHyW0RH+Lqf83Yh02WBreYxGOtzmXz/OYct0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywxzeefantilsf6mwFigTkRhg0COS2VuGFGaIekab6bm6eI9juH gUO0+A5Jzt+qwC5L5KSJG3fxpdLhYbwpUqErKyrG+puthK+F10Mip5Ut X-Gm-Gg: AR+sD12ecVaG8o2AIC9awVPPzPpFGpMtsIs4KYeCkHqegXUy2pnwgEcrzsZVkPEfalb BCzoJKYn8CUuytlbAKg/gE2WQ7za5WR+Gwf2VOfqaz6jDD3MRGjc5RRDsbg1oVzlApx6RYSZ/wV RMfLlHtoyo7dM8ySGsIyH1P97ftGHxF9VfshAPdvlYuIncmzC6rBNkfaiaGMIL1sqEzZUteWbIP /8ingTzxKfwrQAvOkIU7pEThnZKPYgokOapRlk9JyXbLddUf9AWoIw/XeywNvjkYl1+onQnuuAb bn0cLwcVW+vi86b8MfGtYpMBLa2SJ5WTxtdhcvBSzUuN6OOWrSpD6+5VJBADpJgsPXnM/4gCJLk 8omi8Po5KFbIRy2JjkI3lLHprz2MXRVvehXUvhD6s4UGpPlJbTVNvC0mkVf43+rBfGC3oR88zGJ XzTs/CROGky+gj7KtHPQ== X-Received: by 2002:a05:690c:7245:b0:81e:abe2:e022 with SMTP id 00721157ae682-81f991fe6a4mr544577b3.5.1785198168375; Mon, 27 Jul 2026 17:22:48 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81f655acc7csm39583707b3.0.2026.07.27.17.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 17:22:46 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Mon, 27 Jul 2026 21:22:19 -0300 Subject: [hwmon PATCH v2 3/8] hwmon: (adt7470) Fix busy-loop and I2C flooding in update thread Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260727-adt7470_fixes-v2-3-598e38a46ba6@gmail.com> References: <20260727-adt7470_fixes-v2-0-598e38a46ba6@gmail.com> In-Reply-To: <20260727-adt7470_fixes-v2-0-598e38a46ba6@gmail.com> To: Guenter Roeck , Chris Packham , Andrew Morton , "Darrick J. Wong" , "Mark M. Hoffman" Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Angelo Daros de Luca , sashiko-bot@kernel.org X-Mailer: b4 0.15.2 When userspace configures 'auto_update_interval' to 0 via sysfs, the background kthread executes schedule_timeout_interruptible(0), which returns immediately. If 'num_temp_sensors' is concurrently or previously set to 0, the msleep_interruptible() delay inside adt7470_read_temperatures() also becomes 0. This combination forces the background thread into a tight, unbounded busy-loop, hogging the CPU and flooding the I2C bus with a continuous stream of transactions. Fix this vulnerability by raising the lower limit of the clamp_val in auto_update_interval_store() from 0 to 500 milliseconds. This guarantees a reasonable minimum sleep window between sensor updates, protecting the system from intentional or accidental I2C bus denial of service. Reported-by: sashiko-bot@kernel.org Closes: https://lore.kernel.org/r/20260716213252.EACA71F000E9@smtp.kernel.org Fixes: 89fac11cb3e7 ("adt7470: make automatic fan control really work") Signed-off-by: Luiz Angelo Daros de Luca --- drivers/hwmon/adt7470.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/adt7470.c b/drivers/hwmon/adt7470.c index 62ec68ea0a40..0b19b0925d1c 100644 --- a/drivers/hwmon/adt7470.c +++ b/drivers/hwmon/adt7470.c @@ -509,7 +509,7 @@ static ssize_t auto_update_interval_store(struct device *dev, if (kstrtol(buf, 10, &temp)) return -EINVAL; - temp = clamp_val(temp, 0, 60000); + temp = clamp_val(temp, 500, 60000); mutex_lock(&data->lock); data->auto_update_interval = temp; -- 2.55.0