From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE79527456 for ; Tue, 28 Jul 2026 00:23:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785198202; cv=none; b=hnsOLAAPcsHsRpHNDgR8Mx1wZmziNh2vGdR81meP1Y8oE60VI1RXQ1QRWDcbBcFW8ganYdZVdNLEe0Ip1iGfMZVZ3loy+afF628uCEnEZ/Gshe3+TFi3D1Yn+TDJaUWgD/C94QW7WaKHyeIwhuiEWAAdR27AWERgqARbK5tU4g4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785198202; c=relaxed/simple; bh=Qs94MZCzv2SNHH3BXNOPJVwYeH+URwI1EsnWDik9Onc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RRaqmd3tihGCEJ8YlVB2FYTPHBxDMXxQOSR5Ffns3Ek+EgWZ1H3WIKTFeTStauVqmNFtoe672GrvxU8xvDF/qRCANQK0/4dqY8yVXk5I5ErF3+mJaK9bV2lQS8wd39V6sRpEwz/vEfFUMKeHgqHx7WZcAhkKEwTtIb+/mgsCSrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ns3SXdEo; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ns3SXdEo" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-81ed2a06b9eso28336737b3.3 for ; Mon, 27 Jul 2026 17:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785198200; x=1785803000; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Qxd8xdumCkIdLQd6RcY8Rhs0Ioggjo5TOmyZeN4hGe0=; b=Ns3SXdEofK6bUncM+LakbO5E98zEhkvdSHGH+ILf6AIfU+E4MX72zHj21e0+c7ZVu8 ktW+OQAZmRLviPgMAPZ26p4/lCuRhsKqxFnzmhJ07KUenrMS+OgKbDM4BSYaARzUEdRB 7fzKd4WvT7QtLw1g5ivqVT/6LfeT0PGXIRKCcTineF5VI47gSR2oTeihp1PblpxYx7KS 8wBtUBqBKr/ZXEM7a/ktdLsBqjT7IjrQRbPCjJNOnBETWJSDKdczz/KjRnaI8XIh27Yf CG71q2w/J2KOsc5wfUoZhLAspqtWCMGoJLby7bX87qkDaoPLZW6C67gXLA2fG4eR97j+ LEWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785198200; x=1785803000; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qxd8xdumCkIdLQd6RcY8Rhs0Ioggjo5TOmyZeN4hGe0=; b=I1DlanpKCe7lOZpCHJCtOsmt7y21VclNGMhIzhaoWiHikniEq+y5sgoUduwKx+TpYi nobbpZWi0WDI1/17A4Enq+3E0kd+PuDMU+GGo3PZB7f9Ibaoz5/mPaANKzn+OBE4EeXt EbLv6th4SJ1+mg7fbp5/eyOsdjBEiYM7JpFPopMPyKJm8AMGlQ/W+Y3bQ+tOvx/SuPUR p8+bP5HNfBtlQlwX0gGv8S1zYKsvq/yywjERhjA15VYdU21ynSVTzYrn2raNeFX574En EiKdRJ7m5xqnOgc+tYuC0GbfCB9eGsVNc+Zc913oSmZvSZqKZwbrk4BIxK0ejwukktku kBIg== X-Forwarded-Encrypted: i=1; AHgh+RogmuFgZaenoWGuO6z4if3E2w1yb3/gzINuIiTUDIN3CcjwjB2AK1FnL+mYUBcOXNDgkqoNqLGPg4J2VxI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/3VWYTFGcZdeTXORnaVqScdYEDLnsqaAogyplig+GhsGfBwnk bijmOoW6l/eB7vuVPfux3splvRHG4JVw4NYj5mK6Bwy/3T/4hz57Nu/C X-Gm-Gg: AR+sD13D8vFu6DrU5RLHvokmISbYjNrKEQhpFR1Hkqb+yIJ2SNyXDhDUH/qtyh6fVbg 1NEtjgZ8Fk/JhlhtK3OZjjOKdQe1XgTVWL+bqNOyOqK3LJUsEXrz92wPLpBMSdRMskjJ27pFbkM q9HqUrmIRaA4HtyEYG7TXzGkA6QwRxjBh2P8yHfGlPnmPTQ1G64bQOePPauSptN6zeNRifIUHWl fRBt1ipvMvkq0tESOpQ7XrJYvZXyDaalmnnAwkAJF6qpPj9blSmmVX6y4uWDKXGvvY5HtBufzb/ 3VZcip/82iWUMQOMAkW+MDFMNts2zTk/C805sSXrkOunx/LQEI+gaucW+yoScY11UmLjDoLTHLt FhQGwG4oVDdqp7JpdcLJSZ7D1Wv6Lnu7OpdOje2Puc/r3xbDpGLUtJvLU5Ei123hdBb8araTHfX gq9kNbfRn82/fVG27Nl4gwuYT7wHTC57txER1chAbq7U35Ww8yBK8LNS3AhkgZW2x5p1XS/fPBP 91N X-Received: by 2002:a05:690c:9b0f:b0:80b:bc16:8a2a with SMTP id 00721157ae682-81f9936c594mr449737b3.36.1785198199831; Mon, 27 Jul 2026 17:23:19 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81f655acc7csm39583707b3.0.2026.07.27.17.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 17:23:15 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Mon, 27 Jul 2026 21:22:24 -0300 Subject: [hwmon PATCH v2 8/8] hwmon: (adt7470) Fix PWM auto temp state array and bounds check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260727-adt7470_fixes-v2-8-598e38a46ba6@gmail.com> References: <20260727-adt7470_fixes-v2-0-598e38a46ba6@gmail.com> In-Reply-To: <20260727-adt7470_fixes-v2-0-598e38a46ba6@gmail.com> To: Guenter Roeck , Chris Packham , Andrew Morton , "Darrick J. Wong" , "Mark M. Hoffman" Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Angelo Daros de Luca , sashiko-bot@kernel.org X-Mailer: b4 0.15.2 In pwm_auto_temp_store(), the parsed user input was missing bounds checks, allowing values > 0xF to overflow into the adjacent channel's bits. Furthermore, the value was being incorrectly written to the pwm_automatic state array instead of pwm_auto_temp. Fix this by rejecting values > 0xF with -EINVAL, and assigning the value to the correct array only after a successful I2C write. Reported-by: sashiko-bot@kernel.org Closes: https://lore.kernel.org/all/20260727034932.0B7C41F000E9@smtp.kernel.org/#t Fixes: 6f9703d0be16 ("hwmon: add support for adt7470") Signed-off-by: Luiz Angelo Daros de Luca --- drivers/hwmon/adt7470.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/adt7470.c b/drivers/hwmon/adt7470.c index 772d2a409bb5..c45b984c02e6 100644 --- a/drivers/hwmon/adt7470.c +++ b/drivers/hwmon/adt7470.c @@ -1049,8 +1049,10 @@ static ssize_t pwm_auto_temp_store(struct device *dev, if (temp < 0) return temp; + if (temp > 0xF) + return -EINVAL; + mutex_lock(&data->lock); - data->pwm_automatic[attr->index] = temp; if (!(attr->index % 2)) { mask = 0xF0; @@ -1061,6 +1063,9 @@ static ssize_t pwm_auto_temp_store(struct device *dev, } err = regmap_update_bits(data->regmap, pwm_auto_reg, mask, val); + if (!err) + data->pwm_auto_temp[attr->index] = temp; + mutex_unlock(&data->lock); return err < 0 ? err : count; -- 2.55.0