From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A083A3ED109 for ; Mon, 27 Jul 2026 09:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785144102; cv=none; b=X8d3kdJYY/Ad5/24eI2DIG9ovl9m4rJIzRLviWqzHpzROvNkXUNmKSTm+YkRt/Xyr77NTwfofjdYCwpygWySPm2gDSDH0B1SYxeZdRhursIDeVmr2KQ6CRTIq+lQ8wTZprWMRtbYuSRK5AiiaJRC7clkGMUmwe9obHETN9EdTas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785144102; c=relaxed/simple; bh=kMV/fIdncevKVfjmGtD42TtZdUil7gxexiPseZZWR6E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cKL1k9WP+UhKUuTgTw/OwSt2gJrJd+ayWAw/j+1IOSvjtd0snfs6QY5ur/+K5mIIsX/qXjnl9RMwfbRY64pjpIvfG6tLdbBjxJrxoSR9+k3fKJJChsn+xtDzCgtJU0Dwkao/A5R3fDmRkV/6CBZapeD4Faig6kkEWxtwKJIwbY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AM5BV5dr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cTm0sKwl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AM5BV5dr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cTm0sKwl" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66R8g5Z6161561 for ; Mon, 27 Jul 2026 09:21:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eqQE6EJ/sZeK9Gs+yGgiu4HoQE4qPd/3LI0KMakU988=; b=AM5BV5dr/OH0FQS4 EXwNz14zGf8kwzFVsKXZ0HMax/A5IZ24ZWW5bHEbVPJYsenjZeEzLq9mlsWZ9Ydf nPMIR+AgU83sOGylilS+3JH6S50aZyhpDTqQJuXg/4fY6BXu27UraG82w95DgChr ctnoNLDXmX/mobTgs5KjgBmraDTZdfd7Pnf2CuhXEwzQLeusiKtQSVHEerQqMhNS xWrbS5WdjFHwAhyJ8caGxxRo58KL80mN8RYwWIFyfO+n3j80TrBGHqgaLSKOjzBg e55ILfB8M8dYuxodMivdZqUqG2fEon5eyxY2XfxI7qu9p4DngItz8mGeSY6Gl63v uBI6Lw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fny9wh868-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 09:21:39 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1d7886cdso49380231cf.1 for ; Mon, 27 Jul 2026 02:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785144098; x=1785748898; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eqQE6EJ/sZeK9Gs+yGgiu4HoQE4qPd/3LI0KMakU988=; b=cTm0sKwlbBP7jKUk6FVE5FtD/hwnnpmlybOkcy/pfyII73hEezs4NJQtC3XgHWOL8r yPWTxfTSKFMmgmnnoMH4qrCdLlJURxdDqG/lyKBBqc0C25rOqwKC+zWh1kb8/Hk4xugD 6ell2Bzbzi6rlIGgoCxYQdtm0qf8OT6NABSazbfD0nDo+GhKVcULoadFFPF3JfTNB9fe u+M9ZVnLipVLfL+mrxYF+nM2mjBYS5a6aoxZEP3PLyaDwVaMKhk7QVcb2iqMtfd/81kL 8MNXoGA4bB02DV32Lpjgxe3NtaXpHlF8GJ2CCvyo8fXosFhj8vE9s2c8b2nUGDiWTUp1 5h1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785144098; x=1785748898; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eqQE6EJ/sZeK9Gs+yGgiu4HoQE4qPd/3LI0KMakU988=; b=qlwtRPAmEh5ap46w6imhkIEHbMVf0J9AyimOBD7IJwc7/Z6F7mZzCk2qVM3/xGTFVO Or3FQrbEMP4sis8S+OSPY7PDXSv5PSIqM0cB7421b6O3SQnyrTChoCQiKCunuy/oDae/ F+x9Yo8Extt4sQbEBMMF4Ng/49PsOIkXPUfk/hCMLO7tj0I8hKljpF/vvQdau/MKYd4G XM7vvbjcdRMYZiv3xgSC7DxbvuetKp3Tq+vjU+LI9AzU+/Bx+0/6Wqejktw0x5lp8nhX BV2BmMmyLLIu4lTrNQHbJ7hlrH2GYU2wVPPopFt9kIkfEjfxBdvUzc3B694zhOkWnNgc zvxA== X-Forwarded-Encrypted: i=1; AHgh+RoBOfhh4FPmVwEz0T4ikZHbRkMdKlaeYkPMyJPYWaNFKf+954J65/D5YFdCqpIr3X5oRXxzVQobMMsU0OA=@vger.kernel.org X-Gm-Message-State: AOJu0YyuHK+ykho2Iv/PCsHWbDkAjSBtgS53ZXrvmPk2tc+3zf2GxWcj m0ZGZlGOaqp6RobjWVQ4Kfj4obYH37DiUqHyJ3Mlfxf1H0Qnq2fVgIlgM174VgSSiL+yAFEOtO/ I+AT5zYduE8gLQ308wzYvjL5xQVjToJXwxlPHHdxRP+SWAYU0ht3eu1jRrENAhvpvBnw= X-Gm-Gg: AR+sD11fmC6vHTTswLnBqbG52ObqUqQBnpbra726+Lr+M8Zr+jLzdFmvpy89RNc3FV1 hn7prID+HeMznCkVNAL6EVQahkhtbsScRO2HrtRnPKYjeZFDEZpSb+5jTVtAeYVQxok/4b/WDzi 1EcvIL3+MUO4zZ8Vp+qMO6FBL7gfDBEKaYRfBXp7B5XN86ftONl7Giv9RmijcFgKRqQA4m1gJ8E neLFieMO3/JO0AiXjCMHkUjfvnbfaLgpJ60XnqxLC5DqwtjdfJcUdRNIMu/1R7ss1yo0YedjmQv LyskYKWc7aQfSwGEsu6r6XAG8QWNMJNOFvrj3gDvVY+DNAsUcfEih2jYv5FO96FO7TC7PNPYm0D +p9yJRX7Mo4baXhGMPglrCqISMtUi/U4eWpqGlsRZsDS9JkZRShc8IH6hkJVc5xv2tfHf493xm2 vN/1CSThQj5wPSJUgKQk9FSuhZB+YWOIu4Viz+UBuMOciCa8t6qORX X-Received: by 2002:a05:622a:5883:b0:51c:7b12:5fd2 with SMTP id d75a77b69052e-529a8775ef1mr73343131cf.78.1785144098667; Mon, 27 Jul 2026 02:21:38 -0700 (PDT) X-Received: by 2002:a05:622a:5883:b0:51c:7b12:5fd2 with SMTP id d75a77b69052e-529a8775ef1mr73343051cf.78.1785144098322; Mon, 27 Jul 2026 02:21:38 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:61cd:dcd3:c61a:ac3c]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69fb51c9babsm2265326a12.12.2026.07.27.02.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 02:21:37 -0700 (PDT) From: Loic Poulain Date: Mon, 27 Jul 2026 11:21:33 +0200 Subject: [PATCH v2 2/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260727-cci-clk-fix-v2-2-c3958f28b045@oss.qualcomm.com> References: <20260727-cci-clk-fix-v2-0-c3958f28b045@oss.qualcomm.com> In-Reply-To: <20260727-cci-clk-fix-v2-0-c3958f28b045@oss.qualcomm.com> To: Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vladimir.zapolskiy@linaro.org, Loic Poulain X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDA5MiBTYWx0ZWRfXyMlf6id3UeYj V5LqNo+PugKUB5K21T/t1cR4fkl82MabQxWfu2OOfMT8VnX4JzZ1nzBi8i0M+jJetZu+4oHgELW gutJvOLPCfXC8kFWATqiDPs54qsIs5CWWSB0ZHADUc6YGHgSZgh29rZODqVZ5d0Q+T0BqcfYKR9 kHG2GKRTzKLVcJOP6yWZlaZ6bhW3tk0VxL8KUubwmW9OplzvcJxgDairD5odXwI5c+cVaCTpjX1 330h05ycaPTjYiR7Uj1Vwm8T11iXnJc4HN4me7NKlYTEY2722ho3j0GRRQ2b7JBHw5HSWYBZyH+ 1exddzTDZMsqJqMJRRtCI3yntd3LU3AvKZheSLyXn1p4/9R1VWyXCpuN2STLKN90XjHKvHVQY86 92RykowWZ88iY2GEQL3rhh8yuO2/DR0ZIO8nEYOtewXSb2Eyi67roEDJCTRxvHHJAjTSIb57D5G OnSq3Kva0h5a+n1//UA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDA5MiBTYWx0ZWRfXyY5UyhmfjsXh F8rTU8TgRLb+VFI8M7XprR6kvBalfsOzmh7HlsS5P2Ety0y9LMKQhmGhocckR7gpOISedoRz48Y gpvfXacSV/OOoA1b5mEm2nfCyG/g+6o= X-Proofpoint-ORIG-GUID: WDa_EvmgOgqh3TY6wjXfbYwf-pYX_KuE X-Authority-Analysis: v=2.4 cv=E4b9Y6dl c=1 sm=1 tr=0 ts=6a672323 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=wn_r6Zk-WEjAk6jVh9gA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: WDa_EvmgOgqh3TY6wjXfbYwf-pYX_KuE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_02,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270092 This reverts commit b641af684fc28a07bee9c808eb6c433f9d9bcec6. The cci_clk_rate field is needed to enforce the correct CCI clock rate at probe time. The hw_params timing values are in clock ticks and were calibrated for a specific frequency per hardware variant, so running at the wrong rate would violate I2C timing specifications. Signed-off-by: Loic Poulain --- drivers/i2c/busses/i2c-qcom-cci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c index 23cef922351ce44d71f1691cd7e4aab274fdd196..2ed58b2a2f31c62ee1c972a53b71f86787144b84 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -117,6 +117,7 @@ struct cci_data { unsigned int num_masters; struct i2c_adapter_quirks quirks; u16 queue_size[NUM_QUEUES]; + unsigned long cci_clk_rate; struct hw_params params[3]; }; @@ -668,6 +669,7 @@ static const struct cci_data cci_v1_data = { .max_write_len = 10, .max_read_len = 12, }, + .cci_clk_rate = 19200000, .params[I2C_MODE_STANDARD] = { .thigh = 78, .tlow = 114, @@ -701,6 +703,7 @@ static const struct cci_data cci_v1_5_data = { .max_write_len = 10, .max_read_len = 12, }, + .cci_clk_rate = 19200000, .params[I2C_MODE_STANDARD] = { .thigh = 78, .tlow = 114, @@ -734,6 +737,7 @@ static const struct cci_data cci_v2_data = { .max_write_len = 11, .max_read_len = 12, }, + .cci_clk_rate = 37500000, .params[I2C_MODE_STANDARD] = { .thigh = 201, .tlow = 174, -- 2.34.1