From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAC1D3BE62B for ; Tue, 28 Jul 2026 06:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785221687; cv=none; b=QNvT3ItBPM0R5OuFrGiiPxVoFe5ZCEAY63y3WfHFxXiwq+/bZ5gSD0j4n+9vVGoz/XZPk+UkMIXRjlDa9QJhGa04iAlAL+mlt8IN3kBepKkLqb5ZT+zeGiN1cS6l1FzIk8hv0UysbOuOnXQq2tJGFCqYLoAQ37LEhPsrBgFRfxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785221687; c=relaxed/simple; bh=PljwSokI9I7bDnWbnOYmxo1OjA1Gvp19xAtinH09i98=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tcWVEKLEv8BNLKaZ6YCoGBC3LWXyZdQYe2lkmjH/XY9OYWchvCdoVbTXE36Efc2O0b6nB7VffPtxM3UG4xYa9Q0K3W+q04zTQVdqR1LvBrzRU5EXDniWeuuLGzwRP0UAj19cYP32DQZmnb7ROPv7SgnMhvEVEYB0GJUYVVw6DWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J3xQ61Bd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iudlhZnm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J3xQ61Bd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iudlhZnm" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66S46Sd31821166 for ; Tue, 28 Jul 2026 06:54:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eKCGyZXLs+8bYrvXbjrF48hNb2NUGBExhweDO6fIo/k=; b=J3xQ61Bdo/WLlcB2 ESFRd8Cht3UigW+TBeERnHi5tUiAnIOiVJAlG4irOakIqu5PFuXC2Dz13AgamoiZ 70JpptXGR6CDqbv1GZdpn4q7Rb2yg1ScmsPV4ZyUs7nXOSNyRJFiQ3sKXUwjlvSi RaUqVTX6fJJxSZnhROXyfq+jN3iDrAJYPN3CkYJbq8ZqtHKYeol3o6OiuFgL70SG qO9Eo7iCcGSE3xMJ+Vn8x9RwSLH7O3mgwFRGrV+0wXLho0LgVT99Y9kXvXfIrVRQ cnbE22g/mcH6Oisb1mZPa4RivEjZoxwUZdV5X8iTBf09AgAeng0SpY2sagnp8+Yg CxNewg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fpn3y0jrb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Jul 2026 06:54:44 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2d01666c1b3so606395ad.3 for ; Mon, 27 Jul 2026 23:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785221684; x=1785826484; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eKCGyZXLs+8bYrvXbjrF48hNb2NUGBExhweDO6fIo/k=; b=iudlhZnmfb8SpQJWQ7NDjEDnf/NGxwixGB1czkNrdLoQYqcTPNluYrgk3/TXvAYOeR BrdnM7IaO95Qo3SJnqNb/thkCNCSBKGiIbbHlFmYx2ES7JCdLBIo/Dx2Y/ObEcj4fnAn VMUsB2FIyjYTtBGSeOrG9mgwK7794XxJpb/mjUb/yhNi7+qZlkVWVlPh4l205S+w5xUC y3G7fcByArwiYsaUsU4F1iBaBACNGcSasoRYXcn2zJXRT2/z7SeDs4uw2Ba0piey66xO JDCRt4CnKni8mHxtLSTWExN9GFea81FDq8Pnl1z7D+coP2ObrnZd/gDXIuXARWlMFbNW MuVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785221684; x=1785826484; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eKCGyZXLs+8bYrvXbjrF48hNb2NUGBExhweDO6fIo/k=; b=HHtgiaPCW3TZb6tWGrHoS8mosYWqrxt3GvHx7iiJC1ynB4fJElvLdDwImliS4llegZ DeLPCji46YSYM0AsuHW+VN0QhuBUlgK/00SsmtsimKP8+tQuaRHxNbO70kD/Q//t5MU8 EZp4pw4F3Z+e5MA09WQnjxjNn6qRwU7QbbQk4bRwTyT+DKDc+ollRLjYJkX2ZEPhOLhn UZ0NTk1uPP1+pdQDydXlMBq6PITWRh8dCLdr2ZGPyMDvb4nJg9rdmn6MNBpHysCbKWp2 tLlRQ+orX8wHvbiKg8BNmFqbphOFVbCp2h9pklY5/X6V7dyGupra/HQ+XZQs0/O3MdJ1 PdOQ== X-Forwarded-Encrypted: i=1; AHgh+Rov6IyY0blCuFxw0OqT7y0Fqo3Q5bZsawCdOBoV4EdK9WnRhyz4rwydURMwA5DB/X03kKQgRGTglhbNhyU=@vger.kernel.org X-Gm-Message-State: AOJu0YwRxiFCMoOIJ5EJNrvMUELam3z6SAd8M6DjTK7+zAzbEJnhFUXM JoVKqvHMG8wbNILkWjGF8LFhuZKWZEo7ncLYZh9UYXDq4IK+2OE3zcYud5fVJBJN5BrWKDcFZA8 MVBacPROjsIlGyULkfX9oCTAvgaq+5yyNxsSsg+DavY6KdQOR6O2IgiPyX5NEFX8BOb4= X-Gm-Gg: AR+sD11gxbz510S61mRddY6aFuOfitCxrS+4QmpzMoVF+OtEjJfPC8mkGK5d4HwyAkz DV6rQ3sRKZuFXgfZAKZ35kygskABlAUhICrEObHTPqmXQbUQjhSflrW0PHUrJoUs0e4Jc5RrE3j dimAnMi6uOWfVE1JDCETtn9/Se27XFFlXagGe+SWLqi1vIkLb5tBrmOrSE8S0pmPLo32JwsoXAI i1A5kbL0yxk1FQJ40f1DHE0BVdmWag+538SbeymbBJ6r8zuFpCX24ns9/+EgtaZ22vbo7U74hMh DJ4sl6hGB4R7XJK8pFBRY2OquDM2+l7zEh67JhU8+p+frSOQQRCE/eyi2uEpMA7DkNH0DdiVEtv bnF2QwUZ0KCkk8WpOhVLO8fq8ETSeyJiLrJcDy98o8j1/KMI= X-Received: by 2002:a17:903:320d:b0:2cc:e7f3:d39e with SMTP id d9443c01a7336-2d015c0d818mr19721355ad.2.1785221683767; Mon, 27 Jul 2026 23:54:43 -0700 (PDT) X-Received: by 2002:a17:903:320d:b0:2cc:e7f3:d39e with SMTP id d9443c01a7336-2d015c0d818mr19721095ad.2.1785221683357; Mon, 27 Jul 2026 23:54:43 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde5e2881sm46260245ad.25.2026.07.27.23.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 23:54:42 -0700 (PDT) From: Zijun Hu Date: Mon, 27 Jul 2026 23:54:31 -0700 Subject: [PATCH v2 1/3] Bluetooth: btintel: Fix diagnostics event detection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260727-generic_fix-v2-1-a57bdb81ac67@oss.qualcomm.com> References: <20260727-generic_fix-v2-0-a57bdb81ac67@oss.qualcomm.com> In-Reply-To: <20260727-generic_fix-v2-0-a57bdb81ac67@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik , Chethan Tumkur Narayan Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Authority-Analysis: v=2.4 cv=fbidDUQF c=1 sm=1 tr=0 ts=6a685234 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=w585p4NK48lv-ZABhGUA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI4MDA2MCBTYWx0ZWRfXzUCR3i1tOCtZ QUBWoz1zfvL7Ya6Kn6B1l/X5NTwdgfREFOIbXSGCxubGL+fxnKQFQWOPmkBTxU9FEva1FGmA0RF J/H92/gyUSVhBuysnu4xsj7+gLpX8GA= X-Proofpoint-ORIG-GUID: 15jxffQPpa3W1hltJQCOBxRGYhzSZ0Ea X-Proofpoint-GUID: 15jxffQPpa3W1hltJQCOBxRGYhzSZ0Ea X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI4MDA2MCBTYWx0ZWRfX4rJEJJdy3S6F 68Rc7RCZ8PrjzmagN7sics7Of4KazPZ9r46tDsGKCC8dUryddHngBMdBRMC7JGyW+ws3S6w9Xjw Xrq7U76NK4qCFUlVK4OouYnLvLu7RvoZbOF8bOAt0qfKxEu0zOgeX6TDCT9Xy1AwV27RlUCJfR2 LlJxUf/tPOdf7yNn6ZO1XBRo6h9GETLRbkA9AQMeVVeSQbAy8OcQLCPpwjIUkBbF12ZczM5Y1Ek Sz1M0yngW86QukRQlROvK+yn1z1ptuihVYm/8Pg1tiIP3+l4d+HpQxCM8Lkxny/+vDtDTuz+bHC R5mVWGUDpNycy7zjqZK3rS3kMwYJupQ1cqTXmqCJigkhdy0OeNojeAobdyd3ZyKe/aAVT1QVQeJ hWDd7fpbXzKS7AayqS4+1i32nbHXl6nJiNiMH1PfYS+TuXqowU2dIL52i981B1fGS+Ia7yJFjUd 5mj8rTJBvy3JjXoIGBA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-28_01,2026-07-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607280060 For a diagnostics VSE, diagnostics_hdr[] sits at the start of the event payload, skb->data[2], but btintel_recv_event() wrongly guards its memcmp with @len, which is measured from skb->data[3] for the earlier INTEL_BOOTLOADER check. Fix by using (@len + 1) instead, which == (skb->len - HCI_EVENT_HDR_SIZE) exactly. Fixes: af395330abed ("Bluetooth: btintel: Add Intel devcoredump support") Signed-off-by: Zijun Hu --- drivers/bluetooth/btintel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 680f96c188d4..b800379f91cf 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -3827,17 +3827,17 @@ int btintel_recv_event(struct hci_dev *hdev, struct sk_buff *skb) kfree_skb(skb); return 0; } } /* Handle all diagnostics events separately. May still call * hci_recv_frame. */ - if (len >= sizeof(diagnostics_hdr) && + if (len + 1 >= sizeof(diagnostics_hdr) && memcmp(&skb->data[2], diagnostics_hdr, sizeof(diagnostics_hdr)) == 0) { return btintel_diagnostics(hdev, skb); } } return hci_recv_frame(hdev, skb); } -- 2.34.1