From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F7D93BFAEB for ; Tue, 28 Jul 2026 06:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785221688; cv=none; b=W1D7rIVHR00AuwUxF/Tv55hBr9BBjWdTYBfmZuWq+j5gT6C/H/15L3/8B7TPYbdyOgtZsJtQNUtCe3kAuQAW1en9TMO2rfAbL9uiALJc28CU9Fh4HgWAfwQPj8PwwDR5GDaKojZufOXkdnl2c6xJ++VJXQCPgifTgl6+j6CpOPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785221688; c=relaxed/simple; bh=JkTm2YjGpHaAxYGPumzo398OfNBnTy9grI7XyIvWxoA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sK258DlIoMD4dYdnKcGYSdaCsv1wat6mdzBvZagNFaJfpYo6HY0znIO1R11I4LjlBJ3rNxNKs3DLdlr243tnmjjkvDE9et/Z2IUkn4okMoJfJUgWXVZF06xyu8fOzQ+eltnTSKLzul3c70KpMHZ7UwpFqNiBmH7+l7poZdmnsnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IVBlnfTr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PFUsEA2Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IVBlnfTr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PFUsEA2Z" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66S3abDZ1527460 for ; Tue, 28 Jul 2026 06:54:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EJgx+VTaajeyRHXpkiq0/8017ZE/dm20Y1BaHDucPnk=; b=IVBlnfTrvP141cVJ W8HrvpvIvePH0gzVoYjC7LViZcZKKVXIDh7ibTgq17QgQ0XeT6CBIAvGJNdq9WUO NI6PCMiuxfg19ViWRUnOjMnRqpEzhdw7HBQhsQ/fzzBSMWgqNrBVQC4jN6V6dzO7 EBiiA1jCWG6GznO1KiVwT1203+6Bo34th0O/6/+9YqhmKx/K7SNq+4vSDomtuQus pxhPARBT6qisS8IBSF1CHNBqraKLggEDJ8FA77zSnrGgBgeAxbaCb6X4gaERN5Ta WIG1/Y/j5DF6iJWqoU+JOpSD2Ji49Gtg8icXOJVq9Q81DO2N5+KOUcFSqtoBdvUF fRNpNg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fpbn8auw4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Jul 2026 06:54:46 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cae7a8b9easo6880685ad.3 for ; Mon, 27 Jul 2026 23:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785221685; x=1785826485; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EJgx+VTaajeyRHXpkiq0/8017ZE/dm20Y1BaHDucPnk=; b=PFUsEA2ZFi99nijlxnU+6iN6kU2POWaJ1qsSqAJazQ1fr9QejipDeNvIlMoIM8mJGv pmt6CUd4qslctfqzcXd8nRBag+iqW2MnqMbFWzSGar9WdGDRaI+MSAiIg4rac9yYXlKk iZSW0fQ9DkmU1jlIcS7gEQUUcwrbv/IGl3BJKmV5wt2Uk9BrM1bP8iaeAb/t6i9J25kb Y2A2WDcO4J/seVT2TDLuPBlTkXqJ88wIMr5avW35H5EvMondGX8OSVu/IgzjsbLgDO1N A8SIMezt+1MFyq7w41Ghsgq7gepxT9GkjGvHt6pCb/8A93taTdZubU//WonHNb4+5PhA RYAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785221685; x=1785826485; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EJgx+VTaajeyRHXpkiq0/8017ZE/dm20Y1BaHDucPnk=; b=KXViBsjZtN3kkkWh4wMEyYWDeylTPcohWCnwVZ5dkfOdLJyvKTByDsCfZpSH2xZNG3 Qq1W7rmtK3Qp5cETFJy5eSW8/qX+98RnHqpwHTnmSfrzDYTm3Twb7SzmvkqghtHGtVGq ER2roWzMXE33jBao9fYoZjHWsT0omvwu70CKRm96q2/x6n7kFryhJvvL/iqWnIKhUywy d5ySsSKHAveBKIR5F270aGUeICRBUxgU604+CP1EfjU09utIeZN8lXRF6ibJXIM5uMqF OpLJ5iZxHiYQe6ESvGUYTp+8JnShruNv9rteLCbwwbN2x64iOBgd+VdOJmXvLfdbAya1 LWKA== X-Forwarded-Encrypted: i=1; AHgh+Rq/Z8yaVsxQOjPge2Fj8SuUF2Ur3ZmYeVeXpWS15GJIkGQAzE0M4xe2zakJjgXYn+h/hGN8qVHwhSOm+zw=@vger.kernel.org X-Gm-Message-State: AOJu0YwZluDJbf6AWDjYOmp2A8BPdE6SX/4lMj3kuPBibSuJRW+I1zJV c3qaF6mpyPTJGJYMLOagzVLktX1n4bmDHZeyvkupS9mC03I4sbGLgaju96IVChlFofkTFMZhyaz DB4j1dww7RmklIw9zSa2oOIalLp/5Arg30ivzRnaCaxJF1VMZYEw7MdUGjmHhT7bpUG8= X-Gm-Gg: AR+sD10rMdIOqog3UHzbiSJjTasrUZzXLFDEqoVvDXnNByWTqTanKdjzyAnJMq5bYza fGsiAkjgW3f0lgLBYD080f9mhcs+8vs09Eajx+6Y1tZuofz6Qa1vrKf7bQw0DtCDwklQL/Oo6bR JCJym15KKNYpMraesT4bbMdOSGWlsQthOOlM0KrmLlWMQGQAVLfMpRxTJR2W0kcDyNJY6DTQeDi W+/fL6puqe7FtV3msCGfgbfeGqIMG7qP5Uh7pXv5kx6VHn+4EPPPssSfIL3gCCYvTMuBZJqCiQP XcbQnInJAQ575pjJKUlEzkM/tcvgQ+bMnbFipkI9xCv9HKBHpZ2UFE183RpgyxvqP/wGOVJxW8w 63sLp7mBF0NpzFfYwwWuO5Xz2RAp8Pm3ZS8sSVf6lfvq6I4s= X-Received: by 2002:a17:902:d4cd:b0:2c9:ed4a:c3a4 with SMTP id d9443c01a7336-2d0159840d8mr11705745ad.0.1785221685466; Mon, 27 Jul 2026 23:54:45 -0700 (PDT) X-Received: by 2002:a17:902:d4cd:b0:2c9:ed4a:c3a4 with SMTP id d9443c01a7336-2d0159840d8mr11705355ad.0.1785221684802; Mon, 27 Jul 2026 23:54:44 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde5e2881sm46260245ad.25.2026.07.27.23.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 23:54:44 -0700 (PDT) From: Zijun Hu Date: Mon, 27 Jul 2026 23:54:32 -0700 Subject: [PATCH v2 2/3] Bluetooth: btintel: Remove redundant (hdr->plen > 0) in btintel_recv_event() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260727-generic_fix-v2-2-a57bdb81ac67@oss.qualcomm.com> References: <20260727-generic_fix-v2-0-a57bdb81ac67@oss.qualcomm.com> In-Reply-To: <20260727-generic_fix-v2-0-a57bdb81ac67@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik , Chethan Tumkur Narayan Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI4MDA2MCBTYWx0ZWRfX0ysuww/y2C7Z ymLcD++FiwcNGB5gDxw1tjOLo9XaZfshaPkFym2oFCllDscP3sefMKHJbCTb4n8hH0C6raHwuRa 9CABtmRdVehPObIqrTWky9Ruw1WsO6lZOkqrLSHNb4uW+U4tdIYgXgeIIKAh7Z+xzuG3gizYiC+ KmBrxb6QyYgGNvRHPmxYEb5yukMVCI23wypW7pwq02ecxEGP90XDbf6mD4UyXcx/G3rlSX13dRy Rs13UAKkAHJgq4RGjFCHF/y35NgCUYUImkYeY4Tf68utG+kvxyQEQZZXfLYH8cPCv3lzm+D6r+J ATapTSvtozbr0ZPejwoXHMV+DwEE4Hg2GtsHtwqTsXv0JsefhTbnwwimKbo9GZ2hagayFm+a/Oi J+Jpye25uALVFgxbs4z3Yh3y4rGAu9KsPIpWJMKrxzJHa/29HdnmkIuP2HXHSST5gqx2KObbPYx j7OBKuTAWurp3Ay9S6A== X-Authority-Analysis: v=2.4 cv=RO+D2Yi+ c=1 sm=1 tr=0 ts=6a685236 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=7TpkJ8Rp_0KA0x_Po7YA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: kA9aUg0Hyg4KMdaHFNzfy7ZMTr5P-aHM X-Proofpoint-GUID: kA9aUg0Hyg4KMdaHFNzfy7ZMTr5P-aHM X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI4MDA2MCBTYWx0ZWRfX2qcsOkLG3lxa Kw8Xf1tiSO5rZ1UEY9mT4XItBQJRsLIrHyWarDdhcafHHOJyHrDGlNQTeDqGW1HivGo9Ebo4I7u AQOFNktGcoLNndXOrRPmBPqwM6kZ8Qs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-28_01,2026-07-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607280060 Drop the check since: - it is already implied by the existing (skb->len > HCI_EVENT_HDR_SIZE) - hdr->plen is then not used by the function at all Signed-off-by: Zijun Hu --- drivers/bluetooth/btintel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index b800379f91cf..6e61f1bb1871 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -3797,18 +3797,17 @@ static int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb) return hci_recv_frame(hdev, skb); } int btintel_recv_event(struct hci_dev *hdev, struct sk_buff *skb) { struct hci_event_hdr *hdr = (void *)skb->data; const char diagnostics_hdr[] = { 0x87, 0x80, 0x03 }; - if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff && - hdr->plen > 0) { + if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff) { const void *ptr = skb->data + HCI_EVENT_HDR_SIZE + 1; unsigned int len = skb->len - HCI_EVENT_HDR_SIZE - 1; if (btintel_test_flag(hdev, INTEL_BOOTLOADER)) { switch (skb->data[2]) { case 0x02: /* When switching to the operational firmware * the device sends a vendor specific event -- 2.34.1