From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD12F1B87C0 for ; Mon, 27 Jul 2026 00:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785113630; cv=none; b=M9jfS5hCBk8e2dAY4K+hksHClpxDcT/niqFPMtGxpPD0p/PCaONuWrbDgjRapG8BtxnYin7zK+z2coMn35x0RNdfU6YqOe9YB7CUhiFqe51YEqUkFX/Vd7jSgOaVaTTT8cqsCuNHo4MBNsHHlSuD4L7Mw+Xa8f83yDNiFQ2yih8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785113630; c=relaxed/simple; bh=H5d/2IpDJ5mSbV2nCWBAdW/aONLsYHfxTefAkVqKfqE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WP0lUS1HGqxX3XnfGB7fXBz/KxIuuE7EMHXiaTAeSLkltqx0GVhHdIUTiiuZ8pHhWl8nSrEl+5yNU6PsF9jf9OXiDhwm6pS71xkxPPZ4JCCwxLIrcLDryMmS9xKIIbgVaJCotdlVz4cHrQC6M3h5+FODAOyPJMtE7guVw+zlV/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XIET52Wu; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XIET52Wu" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-5218927884fso24536081cf.3 for ; Sun, 26 Jul 2026 17:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785113627; x=1785718427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=D8hT5YG9osvX+mj6IYiZum/vN/YOieTcuoDvay1/Cqs=; b=XIET52Wu3dzb0JZvRL23GvsO2IrVARGQPzROLqb9+rIFaaZ6PI2TCm6xSXI2jceMOh EbiOLtWo+uX3qOF7Txb77ZMui+xlTRP8QcoavpfVG9R67rbC1BbsWm8fgNFYouMwH8WT dE7iGlHbpUa454xGkyBTSZP5J1sMpM19reo3lxOk0jrTtx9+HM+Auy28BoE5MV1LmC5d ffdHXi+7XwZkw8cKiFEBWp5M9WLRCQImqYtF9JLKks/xHAzFgxBnuPXpN7a6Kkz5SGs7 r/XJUp/JtF2/UkUrlac+JYH7gJS3n+Dcmv2/t1vcN39SXAEL0mC4sdolnrYUNXSa674v QtWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785113627; x=1785718427; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=D8hT5YG9osvX+mj6IYiZum/vN/YOieTcuoDvay1/Cqs=; b=cWhdPlxi9HJ4hG0Os/vdSHzHci42na7f13qlnKjgbKRhqjZvDos/zYPiKp2Rmcp4eF SUC+Ymx+zjH1+kd9pxwrVaGcj8P2NCOgcu4ToPtsYK1jtLJa4X1UhyTdXEEbg9ivW1jA ZbIInNNpuZ+lPQ02F6t92kpdGoFozpYJ9L0BKjowJfzUjlB0fjFxCEqilmWlRKjaWDuQ E0CMnG2C1WsOebves73S/5Kf3gRPmAZDmwKfW1ZOD90EIsR+8m6P6YSr45GWbCeWEwSl iumUOlrcq8oqL3EZ/qQlsQ4QqKAIwA0gMBoyjqP+FN3xa1hZtc4LtiAJU5xUbxZQUeQr I97g== X-Forwarded-Encrypted: i=1; AHgh+RoceCfLy82YYnqydBKyEv44RK2PwPXKMOPi2R1UYeIK3qf8xmFQZUiJ85y5vkKhoHSfoT5uF0u1sJT+C8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwNhmWtJ3bsUNHUGtMfnPBfVif7A7Vafq7GMYBXYpPOTEn1hq41 GBct5hLpj7BMPnbH5PSwGyt172r5ulTzP83dC4o9c/J7yqHkQh6nTroY X-Gm-Gg: AR+sD13dggHKLNu7zgwySJu57UWqCTJBobnIjt9FrmGpdqsT3TrornRj0qT3VTXpNNG /5463107M2nlNOmzlkOLrkJKlyx6YWM3Y8HtySV/P8pRp1q9POY4TDOVfsCiwq3MdwNFNQHSh33 rkOyY6rbN+5c2MTGjRAbnL/WiB5RM6o/mzoDppgOMWiPDQ+vS09A03Ir9rXpEsR4utll2Dy0Aoa h3shSBkcRX97oXerRIihSKAlPj+oHUfSPjXot4ltWiDUz6N0AHjmkh2DeY2DMEf7mMGUob6CuoF xg/PaGyjoF11vlYkBUy5t0fa2ceoICuj/yYNrtiqZ8mPjwaRCp/YsiqY3hcFr3oUJ4qQR3gP3C8 YohQnMt40v7ouY83g1SnTqVKL2KGQgsOCUd/1HNR/2lOn71VuYhx3eopjXUPoQZQ2TRLRlc19Q1 4x22R2k0HDdNtTGINrgrBpFRF0WWaxIFH5Ixjt3ENsSa8BV+G0QzEiAYgtO7nAxuQil5rlwI+d0 VbpoqVpNSRjHagCXsbIwxYWDiDQW0rnQsSO8G1wfsR7kswV7BmOSxkdAzeFyFEM5w== X-Received: by 2002:a05:622a:2586:b0:51c:d1c:474d with SMTP id d75a77b69052e-529a84b9a6emr73328471cf.19.1785113627516; Sun, 26 Jul 2026 17:53:47 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-529a27f2dedsm42949171cf.7.2026.07.26.17.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 17:53:46 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: talitos: Use platform_get_irq() to retrieve interrupt Date: Sun, 26 Jul 2026 17:53:44 -0700 Message-ID: <20260727005344.166124-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the need to call irq_dispose_mapping as needed by irq_of_parse_and_map(). Simplify the function as a result. No need for gotos anymore. Add a missing free_irq. Signed-off-by: Rosen Penev --- drivers/crypto/talitos.c | 43 +++++++++++++--------------------------- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index 3a3fd21d2c4d..bff653b87941 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@ -3241,10 +3241,8 @@ static void talitos_remove(struct platform_device *ofdev) talitos_unregister_rng(dev); for (i = 0; i < 2; i++) - if (priv->irq[i]) { + if (priv->irq[i]) free_irq(priv->irq[i], dev); - irq_dispose_mapping(priv->irq[i]); - } tasklet_kill(&priv->done_task[0]); if (priv->irq[1]) @@ -3353,54 +3351,41 @@ static struct talitos_crypto_alg *talitos_alg_alloc(struct device *dev, static int talitos_probe_irq(struct platform_device *ofdev) { struct device *dev = &ofdev->dev; - struct device_node *np = ofdev->dev.of_node; struct talitos_private *priv = dev_get_drvdata(dev); int err; bool is_sec1 = has_ftr_sec1(priv); - priv->irq[0] = irq_of_parse_and_map(np, 0); - if (!priv->irq[0]) { - dev_err(dev, "failed to map irq\n"); - return -EINVAL; - } - if (is_sec1) { - err = request_irq(priv->irq[0], talitos1_interrupt_4ch, 0, + priv->irq[0] = platform_get_irq(ofdev, 0); + if (priv->irq[0] < 0) + return priv->irq[0]; + + if (is_sec1) + return request_irq(priv->irq[0], talitos1_interrupt_4ch, 0, dev_driver_string(dev), dev); - goto primary_out; - } - priv->irq[1] = irq_of_parse_and_map(np, 1); + priv->irq[1] = platform_get_irq_optional(ofdev, 1); + if (priv->irq[1] == -EPROBE_DEFER) + return priv->irq[1]; /* get the primary irq line */ - if (!priv->irq[1]) { - err = request_irq(priv->irq[0], talitos2_interrupt_4ch, 0, + if (priv->irq[1] < 0) + return request_irq(priv->irq[0], talitos2_interrupt_4ch, 0, dev_driver_string(dev), dev); - goto primary_out; - } err = request_irq(priv->irq[0], talitos2_interrupt_ch0_2, 0, dev_driver_string(dev), dev); if (err) - goto primary_out; + return err; /* get the secondary irq line */ err = request_irq(priv->irq[1], talitos2_interrupt_ch1_3, 0, dev_driver_string(dev), dev); if (err) { dev_err(dev, "failed to request secondary irq\n"); - irq_dispose_mapping(priv->irq[1]); + free_irq(priv->irq[0], dev); priv->irq[1] = 0; } - return err; - -primary_out: - if (err) { - dev_err(dev, "failed to request primary irq\n"); - irq_dispose_mapping(priv->irq[0]); - priv->irq[0] = 0; - } - return err; } -- 2.55.0