mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
To: srini@kernel.org, linux-arm-msm@vger.kernel.org
Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com,
	linux-kernel@vger.kernel.org, quic_chennak@quicinc.com,
	dri-devel@lists.freedesktop.org, arnd@arndb.de,
	dmitry.baryshkov@oss.qualcomm.com, broonie@kernel.org,
	stable@kernel.org
Subject: [PATCH v1] misc: fastrpc: Add missing <linux/bitfield.h> include
Date: Mon, 27 Jul 2026 10:32:38 +0530	[thread overview]
Message-ID: <20260727050238.323039-1-ekansh.gupta@oss.qualcomm.com> (raw)

Commit 10555ba6126ed ("misc: fastrpc: Replace hardcoded ctxid mask with
GENMASK") introduced uses of FIELD_GET() and FIELD_PREP() but omitted
the header that defines them.  This causes build failures on x86_64
allmodconfig:

  drivers/misc/fastrpc.c: error: call to undeclared function 'FIELD_GET'
  drivers/misc/fastrpc.c: error: call to undeclared function 'FIELD_PREP'

The missing declaration also causes a secondary -Wformat error because
the compiler treats the implicit FIELD_GET() as returning int, which
mismatches the %llx format specifier used in the dev_dbg() call.

Fix by adding #include <linux/bitfield.h>.

Fixes: 10555ba6126ed ("misc: fastrpc: Replace hardcoded ctxid mask with GENMASK")
Cc: stable@kernel.org
Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
---
 drivers/misc/fastrpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 94681394c1a0..017334ea4f34 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -22,6 +22,7 @@
 #include <linux/firmware/qcom/qcom_scm.h>
 #include <uapi/misc/fastrpc.h>
 #include <linux/of_reserved_mem.h>
+#include <linux/bitfield.h>
 #include <linux/bits.h>
 #include <linux/bitops.h>
 #include <linux/compiler.h>
-- 
2.34.1


             reply	other threads:[~2026-07-27  5:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  5:02 Ekansh Gupta [this message]
2026-07-27  9:28 ` Srinivas Kandagatla
2026-07-27  9:32   ` Ekansh Gupta
2026-07-27 11:50 ` Mukesh Ojha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727050238.323039-1-ekansh.gupta@oss.qualcomm.com \
    --to=ekansh.gupta@oss.qualcomm.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_bkumar@quicinc.com \
    --cc=quic_chennak@quicinc.com \
    --cc=srini@kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®