From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 221493033D6 for ; Mon, 27 Jul 2026 09:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785146317; cv=none; b=eddDdwSJDJfNupqIeB2E5xZmoxvc3cwr6Jij/CbEW+GXgPFq9R9+91+hqEgIL7lBCAh3R4dMiNXiDJieoJ/xL8ykdH0NbKQid0MKGh3/wvjySmdNUtLA8QGW4RndRCQDkr6WXxtRwHBcvbk83T9UxqVOYYFS6+G62Mh6l1zB3TU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785146317; c=relaxed/simple; bh=CK19sufOPrVyDUGtt9TbvFfXeouakW4R/XyeqbRqgWs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qwq9MviPRcqYHciuH6/62Gtb8LRBuAiUAt2MyKn8XQvj0jhMdXtwuW7YLhHV2ukuQekxW7pAIrlKiMtRF7esyslFAlBlrHoy1XRHr5/8nN2aRlXnMQ3x/kWlzTv8y6/AAiIpggZpPbQjpG23TdvhmgEoD8iZdX5PxaFTchrhk8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JGiRLQU+; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JGiRLQU+" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-ca88130e09aso1712701a12.3 for ; Mon, 27 Jul 2026 02:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785146315; x=1785751115; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wR6uYvZxPPYYkNgZGPv+6qRyWQW12k+GSH5fqM2frck=; b=JGiRLQU+xTbOaL4WwvDntYNlitdnTYllwpbzx3f33NsWA19L5sOcMr9WI1/Vw4b1b6 eF01y9VNoh2i6dGdshh8JXqVQFV9t7Vf2jH2KHqz+Ei3fB1rw+P/KO9k4HIGR77x7kEj XuzdcQUqnbvDHzHcKvErQWu3wTkc6wc9SREgz9gZP9FXEFzheBoGbE7SI1k+dbEHJKKx aBxXH4PP4H0fcs1UpKqFTPZNPwue06urbJSzZgqP7MMIUs0o6skJhcbqsIYfYrIBLsts grwokLFs1I8DPPPdqlTz7uA7UwgZyNSONU686jRAFT17pVgjmjO/thJ0IzpuW61p9UyR 5XVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785146315; x=1785751115; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wR6uYvZxPPYYkNgZGPv+6qRyWQW12k+GSH5fqM2frck=; b=cJH7lKNcodilrZ/k0kCCD/0r93VVNP1u/a4H+ZrFYjvd7rqsJh8wxUiz8jHWCuWcSg sOTya/sjPeKtElCuJoolVxeVNnmbegtPJ/0G+ASYvBcGQ2crjQVDIsWgloYm+zfEG3pe gQlVWm/Eswx7MPvxF5ZH0Z6Mt4LG8C7bLmrgyCPszFvHCCAMfxbC4Aq11tuSveZont7C rFanSxANogPX9jQ15yDi9Nb340vCnvl4uYAiNgJ5vwwMZOC3q6gcTNEI+ajKI4TciGeQ 4Dxx5d06AvMtXsMHs/chznvKSw1SJcNn8Ql4Oe/kjRP/HfLpm0ftPJ57c5mRU0PABO3Y Blsg== X-Forwarded-Encrypted: i=1; AHgh+RotBxV3jlExb53VIjdYpw3DN2qnB4WGM3iAARVXQ7aDMCS55+AbYZMDQDLj2LhuAQXCkfH+Z2HkJvwp1Gg=@vger.kernel.org X-Gm-Message-State: AOJu0YzWE8pnWOMVx8jgBE1EctiWGugbvaLjMQ5XRVZSJAv6lIX2YsPd WysO/Q3TqK54wtp9p4DGcXI0bLntNscx+4DpiIbTIa+SHKNc1RXkC1wWFYbfegFt7cBsyQ== X-Gm-Gg: AR+sD11kdAuj7v6D3+1/fRjOJ63tfqSJEN8kj92e8AbkkWLxhgktmX8eoDlcyBPdJlk NavlBFYemSoVrvEXq6dSScxAPGBSJ2tnEsZkJ/c3A2iF3ys/tzGwJR1eYj4F1oYRyNWQ3KizCzP SOKrL20aw/dnMhCljdjUpVfLtExYdriuK2hdW8tDEJeNvg5h+aAhKnTVBMCRQWhSFGWSudBDamv lN+TdHaqRBIe2grj0Bea0T6HGXaRopxwnWKhzz/b+dpYvQqYrQxIWSEHbfGol0hkjEou6Kagm+T 4PP1lRpJDJMJMftEZZMR98bvJMmKZNN/dd5c9R1OZgaG6mfq8rQlZBax8xDf8BC3SbMyuHciZ8B TCTTs39vJbxcykA2Q7UNU1SN93mVl4M+o5A4pT+FU/ZicfC4ihPi5Euvp0oDynxps5eac2+3ECl IMZb8FNYzLSJ3lKMceCdQujj/k7MxGGbhhve0gYBzzPAeeQtatnYPGZ8LrcmVLbD3J/nhoPdRwM iX5Ehuufzqb5ZkYc7RK X-Received: by 2002:a05:6a20:4323:b0:3bf:6011:53b with SMTP id adf61e73a8af0-3c67df1ffe9mr7420999637.38.1785146315325; Mon, 27 Jul 2026 02:58:35 -0700 (PDT) Received: from 7cf34ddc0813.ant.amazon.com ([54.222.46.32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbbb66dcd38sm3014786a12.29.2026.07.27.02.58.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 27 Jul 2026 02:58:34 -0700 (PDT) From: Jiazi Liu X-Google-Original-From: Jiazi Liu To: Thinh.Nguyen@synopsys.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jiazi Liu Subject: [PATCH 1/1] usb: dwc3: ep0: skip CLEAR_HALT on non-stalled endpoints Date: Mon, 27 Jul 2026 17:58:27 +0800 Message-ID: <20260727095827.11807-1-liujiazi@amazon.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Mac hosts send CLEAR_FEATURE(HALT) to all endpoints immediately after SET_CONFIGURATION, even when no endpoint is actually stalled. This causes __dwc3_gadget_ep_set_halt() to be called unnecessarily, which can disrupt ongoing transfers on active endpoints. Fix this by checking the DWC3_EP_STALL flag before processing CLEAR_FEATURE(HALT). If the endpoint is not stalled, simply acknowledge the host request without calling into the endpoint halt path. Signed-off-by: Jiazi Liu --- drivers/usb/dwc3/ep0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index bfe616194dfa..b577a1b764fc 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -554,6 +554,9 @@ static int dwc3_ep0_handle_endpoint(struct dwc3 *dwc, if (set == 0 && (dep->flags & DWC3_EP_WEDGE)) break; + if (set == 0 && !(dep->flags & DWC3_EP_STALL)) + break; + ret = __dwc3_gadget_ep_set_halt(dep, set, true); if (ret) return -EINVAL; -- 2.50.1 (Apple Git-155)