From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 887853F58C2 for ; Mon, 27 Jul 2026 10:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785147101; cv=none; b=W3YfAooTS1t10jpUbLfxzbSLf8MFtlhMpsy/c+6fvoevvPhB5xig5GSIijDqAX8YFtuI+WIuOm2iZlHddwTQxgZSjB2XFlyZ56h3KiuES+2pLpDMgNiJ6XdxWjWO/p3OMAAL5JyI3K2xuhVmPabdRilUGqXVq/xFtA6sUVI9Cok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785147101; c=relaxed/simple; bh=h4ePA5ka0qPaYWNth0UkRXFMBqyoFond9v7BO689f6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uriC2wNCV/mTEbH4giOTSMDdbYCDX93a2UVGNx1qAyNH27vYzGh2Xg55/Wj7io8hDdai8ftXUzCnyq8YoHoW8F4MovW9yt/gPeFvZB32GDyiUSs2PiEkbKeA/hHxJFZrHGS1NCB83haKf6rHVHejTYCXpWU6pOc71NmlBb6Kpzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TYiLzo3f; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TYiLzo3f" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cf41bab353so34031295ad.0 for ; Mon, 27 Jul 2026 03:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785147100; x=1785751900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q5qn90GNuN/EhDc4YngJiHFWLzHAwHWxWP2/U2lR8lo=; b=TYiLzo3fxTLEB4o907wy3k2UedGuMilJCz46xDmw9JT7faHt2JuYQWQKOGfoIElkTu eS95oZ4GJPwOToEhkI0OJOD6KMikUM+XbXLl+VL7dIung8ss+6qu3//QVP0KVi1UTmwl JE4if+DeCNMujDk8rufknSGFIjSIKlOabufJEbFBz6VtXmphR8kgRsxnEeBb3C5q4aYV nXZcTGHERMIxLXRruFzGGifCu87KjRNZg59HED+RPShG8oU/HNo1lMTPT8gl3ZEwQeTJ jyYnmQtSE9CTU3O6at8o2cYCDeX/5/KOtvCOB0p+8TBMPfbwCwPpyQ77qBxzvztV1vwD Qbyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785147100; x=1785751900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=q5qn90GNuN/EhDc4YngJiHFWLzHAwHWxWP2/U2lR8lo=; b=AAQbzzr0FExW0qA6XskO2QAbiZrBCMtnwPwknDA1INTFDPSA88zSrF5UmcQKvEWGXO W1y3aPHpMQozF6u5YBfk1D5dOvaqKSe+MiQAOBD6/2JH7NBNvVUj3cmMnS+jQO6XiCG4 XIiURzd243bzrHYDeIq20mGJw9L20Sh3BKEgJ7mNnpWLVME8fGT+Reqa895CU5rxU3cI lrMEK8plN5/ABjKf2rVG/M8Y9A6nFtJkQYXFuGbNC3kkPOyE4dqcr9X+SaPgMizi6a/x Aqe10GcabzsU2G5xIHXNIpCWkbBap7dkMXhiiLvB9oN8A6tFa9FrcTmi317U4sCtC9H5 FcQw== X-Forwarded-Encrypted: i=1; AHgh+RpOJO8L+lJ3dCuE2bvekbS+/v9jY7hDREqcxbtdnaDKgQs33L2hJJcqJNWBlLJUEeu9f2MLVKeuISqWWws=@vger.kernel.org X-Gm-Message-State: AOJu0YyHuZEVEtprgDEXdKU2p/K9df21pna70g0zwSoba+SY1+H/14GX ErP6/F0lBqLIl2ol97Y/c4uIL7dQg3TRm0+8mILJnCycMhGvxDzqbRrr X-Gm-Gg: AR+sD13oYLKSmBHQjy78r0ILpwTIKuvS9lAsaCLysRUSGrbwmCZGpARz8aue6IBXsYx quMaBX7zevj2GBTx+Fkxm2MGmgnOYIskzGvopoGF90S1uCT/So7gvNunUL5lbF5jxhmIi9uD2zR 5HjwoRcbLOZTaXkEbi59jB4udSQZCTkNREFqt4jIqJHQMhk/Jnw9awh9U45WKMNxaX37VSj0Hmb 9oUVhf/MhHiL2zXqbW3irZ4e3fsRapUwhjgLM7O/y2KgULmtq5SyO5zmPKRYmRiEONWl6PVLOxS LGs9Ci3DO2mBd1e/jtnwr57iovtyBnEJFoBncVA+7Bs7tK2oeoFtDRCLdpk8ji3mrnwWds857Tm sK0vyRTqVgqAPySveD7Q0O/DquThfgU/+aSiIZ0eT2eDQBG4ipA1mq0fNlXG8bPzwRyufDNdYiD sluYZFtZWltROFahULEEuaLqeaExjU7c0S1JgOQ8ZeQncqdyd9Fm2KfT9o9BOvEVsAAd1Y2bx/O Abxna22VrRsBnAAJU/Qfg== X-Received: by 2002:a17:902:da4d:b0:2cc:6817:d9b1 with SMTP id d9443c01a7336-2cfde8a52a7mr73228775ad.41.1785147099838; Mon, 27 Jul 2026 03:11:39 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59bb5asm32371125ad.8.2026.07.27.03.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 03:11:39 -0700 (PDT) From: phucduc.bui@gmail.com To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/2] Input: st-keyscan: Improve probe error handling Date: Mon, 27 Jul 2026 17:11:25 +0700 Message-ID: <20260727101125.28291-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260727101125.28291-1-phucduc.bui@gmail.com> References: <20260727101125.28291-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() for devm_clk_get() to prevent log spam when probe returns -EPROBE_DEFER. Drop the redundant error message after devm_request_irq(), since the helper already reports request failures internally. Return the original error from platform_get_irq() instead of replacing it with -EINVAL. Signed-off-by: bui duc phuc --- Changes in v2: - Clarify the commit message to better describe the purpose of using dev_err_probe() drivers/input/keyboard/st-keyscan.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/input/keyboard/st-keyscan.c b/drivers/input/keyboard/st-keyscan.c index e53ef4c670e4..8e9bac339dc4 100644 --- a/drivers/input/keyboard/st-keyscan.c +++ b/drivers/input/keyboard/st-keyscan.c @@ -173,10 +173,9 @@ static int keyscan_probe(struct platform_device *pdev) return PTR_ERR(keypad_data->base); keypad_data->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(keypad_data->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(keypad_data->clk); - } + if (IS_ERR(keypad_data->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(keypad_data->clk), + "cannot get clock\n"); error = clk_enable(keypad_data->clk); if (error) { @@ -188,14 +187,12 @@ static int keyscan_probe(struct platform_device *pdev) keypad_data->irq = platform_get_irq(pdev, 0); if (keypad_data->irq < 0) - return -EINVAL; + return keypad_data->irq; error = devm_request_irq(&pdev->dev, keypad_data->irq, keyscan_isr, 0, pdev->name, keypad_data); - if (error) { - dev_err(&pdev->dev, "failed to request IRQ\n"); + if (error) return error; - } error = input_register_device(input_dev); if (error) { -- 2.43.0