From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f100.google.com (mail-yx1-f100.google.com [74.125.224.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DDF03F1ADA for ; Mon, 27 Jul 2026 10:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785147404; cv=none; b=l3snJ9Ca12GAiiKQGKYNGWtlaCM07tXWPcKZGs6hV700YzcoLuDWyfZ20SgBlrfoyCE6aF8w8yOHyCpTcKOZ/mHeQDrUkNOkCtUlbSWgM3gcEGFdPL1fFr98j6/E0YV1qFrYtG1laAHqNoVNidvVMBPIwvvhOVXrngBRH4VQZwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785147404; c=relaxed/simple; bh=xg416wZWycPdqeh1Em1LGsWC/Ld+2UysN2Am1AH6zxU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VrJ3N/bxXJ6iibbdT8sgaYHIa1ichHuXFsIkjj9juvARuV0hcUN1k9h33gp5QK4Pdv7N7Q6B2PhH6zIUI/9lPPnLxb6tvz2XciQBNq1wKskoyxRqPdB6cSZrYSfNRCPv4agUw7nGF8j4qpLt6clarhb9R4ZEePZp3NvXE3YweE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=B7Wdd3HT; arc=none smtp.client-ip=74.125.224.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="B7Wdd3HT" Received: by mail-yx1-f100.google.com with SMTP id 956f58d0204a3-6685001353fso1941324d50.1 for ; Mon, 27 Jul 2026 03:16:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785147401; x=1785752201; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=EXnlR8dRlG9FnR4UHV3rtVsyPMP4PaYSGN0799YN8n4=; b=TC4LgO5Wvkz80H9S2m9GOBkjUcAEtuqgZ16LYvBfapCfvXHSu44CZ+5rkty/dNqW7A KgDY5kCR7iVT244jZT2ImC2QX20w+p8EZBf+7kL0K/0KegLHRKVjaEFbtQIjI9YxdfHy IDsN+dX9gzT/SJNHE8XMdYIQhyaUYZ1zS9u3xcigfSIUYRig1nih1YyLGiOf4PQpl8yK 8E5kpJmzoJiSHDFEChZ6v1Sa35cL0UioAl/rlpK8txrhGivNhZXu7ujwGtwToFCtmzig ATSN3WcAfGOdBn6plDgR/ssA278zG9kKEEkX1FhIuTGbkPEpdSc7X9Z0McVsdofVjYc9 eypg== X-Forwarded-Encrypted: i=1; AHgh+RoaN8OKedKPdEzX0E7fXbythaAWoiY9Wgpk8RYpJozbWnVa9HHpCCaPxhP3+lXTfsRF6ewOQVrTKFUaUS8=@vger.kernel.org X-Gm-Message-State: AOJu0YznfpnoSCuHVKD27byfFjyjQganizOlOQVCXkJu37is4wqP4xZQ 0er0K6V4IL1obH4GoJv0g7nALMQa7TRG65ofVU7TYfNi0Y2XuzCiJi0lXnOEkdJRivvJCrB4I4I cze4up+oygkZkaw8QgS1ElWSmvmJPuFiaO1iMUrrWHVRkqaZ0jDymMFphszC4k1wqpP5wnn3rJe aF79aO0WBUNHymbqkw9dn3JSfkTI9yLQj1GH8Y4m8dKmK9f21R+C0RsXfrrwNkQ9GMP6u1Ed6bh XvzGDEqu4ma4UPxEavl X-Gm-Gg: AR+sD103EaefGtIQSzFtR4KmbaMIxR9tikD6lkSX0NDFLfwR5KJ8cRL9zC0QYRhMjmP R52US6jiZThUfw52yn31eGITZL/OEMsBipv3GLb4POkhtMT6qO5mxfbkBoBUCXtkcikMPtCLH+M J5r3aEIyf59pUkEXEwoX8ti3zFYRnqO4ywIERzlqa9l1U9n6vvuRrq0JHQaCO05/4rBWIt+hqYs 7G0uI7esrnc3igG8RHwjlTMJ7ndreg4qSP7047NzCLpvSVvRQUTxdi3HXapVuEgkjRhUQwmk1SW 5+AmQ3r277Ix28hCMsvc6jrPfrNnfTl7kyG7UpaZyPhLdrjE1DjsWEydKGV+82ql2yuBkuXquqV lnrT4MKiX8g/3ry6lHP301J91LFYMbMP0ve0viZQPgYKhu+svBD7YSVJrS5J93OgXak5yzTYEzO /xoXsdiqFAKlAyNwf0igHngHwnyQ0YRm026g== X-Received: by 2002:a05:690e:b44:b0:667:ba5f:e32e with SMTP id 956f58d0204a3-668c796fbb2mr2023184d50.14.1785147401226; Mon, 27 Jul 2026 03:16:41 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-668c6f4bc6fsm595148d50.19.2026.07.27.03.16.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jul 2026 03:16:41 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e632390d2so413394985a.3 for ; Mon, 27 Jul 2026 03:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785147400; x=1785752200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=EXnlR8dRlG9FnR4UHV3rtVsyPMP4PaYSGN0799YN8n4=; b=B7Wdd3HTuNPjjKpxxV5x2L3WoQMwMgjFF2SUiZMnueqR5rQzmHgjiwXMOO8tV3KqNH 9bfq4UvxODR/BRIVx/X2iVcIkGVwzua3LjA8hr0WqDAL8wY2XrJd/E5TMVaAiE75wFn7 U0M77NzcMArMp3oyQb6UgF6N7K+2XDLP20iTg= X-Forwarded-Encrypted: i=1; AHgh+RoFEfNW4OuayISk3D0by+aFWD4E3QGUfQ6RFCA1ybhwo30Qz0+DHKgOkoH+PUTBYPQciMUbs6xWJympOYA=@vger.kernel.org X-Received: by 2002:a05:620a:2a09:b0:932:d9c4:3bec with SMTP id af79cd13be357-932df6bbcfbmr775938285a.38.1785147400027; Mon, 27 Jul 2026 03:16:40 -0700 (PDT) X-Received: by 2002:a05:620a:2a09:b0:932:d9c4:3bec with SMTP id af79cd13be357-932df6bbcfbmr775935285a.38.1785147399559; Mon, 27 Jul 2026 03:16:39 -0700 (PDT) Received: from lvnvda4076.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-932de51a7cbsm587994185a.8.2026.07.27.03.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 03:16:39 -0700 (PDT) From: Kiran Kella To: daniel.zahka@gmail.com, kuba@kernel.org, willemdebruijn.kernel@gmail.com Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, weibunny@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jayakrishnan.udayavarma@broadcom.com, ajit.khaparde@broadcom.com, akhilesh.samineni@broadcom.com, Kiran Kella , Vikas Gupta , Bhargava Marreddy Subject: [PATCH net v4] psp: fix NULL genl_sock deref race with concurrent netns teardown Date: Mon, 27 Jul 2026 03:16:28 -0700 Message-ID: <20260727101628.502042-1-kiran.kella@broadcom.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e The race occurs between network namespace removal and PSP device unregistration. When a netns is deleted while a PSP device associated with that netns is concurrently being removed, psp_dev_unregister() triggers psp_nl_notify_dev() to send a device change notification. Concurrently, cleanup_net() running in the netns workqueue calls genl_pernet_exit(), which sets net->genl_sock to NULL. If genl_pernet_exit() wins the race, two sites in psp_nl_multicast_per_ns() then dereference the NULL socket and crash: CPU 0 (netns teardown) CPU 1 (PSP device unregister) ====================== ============================= cleanup_net [workqueue] genl_pernet_exit() psp_dev_unregister() net->genl_sock = NULL psp_nl_notify_dev() psp_nl_multicast_per_ns() build_ntf() -> netlink_has_listeners(NULL) /* crash */ genlmsg_multicast_netns() -> nlmsg_multicast_filtered(NULL) /* crash */ Fix by replacing the bare dev_net() calls with maybe_get_net(). maybe_get_net() returns NULL if the namespace is already dying. Holding the reference ensures genl_sock remains valid across both the build_ntf() and genlmsg_multicast_netns() calls. Fixes: 00c94ca2b99e ("psp: base PSP device support") Fixes: 06c2dce2d0f6 ("psp: add new netlink cmd for dev-assoc and dev-disassoc") Reviewed-by: Ajit Khaparde Reviewed-by: Vikas Gupta Reviewed-by: Bhargava Marreddy Reviewed-by: Akhilesh Samineni Signed-off-by: Kiran Kella --- v4: Fixes done based on feedback from Jakub Kicinski - maybe_get_net() logic removed for assoc_dev_list - Added RCU protection on main netns before invoking maybe_get_net() v3: Fixed typo in the commit log https://lore.kernel.org/all/20260715110701.3775026-1-kiran.kella@broadcom.com/ v2: get rid of the extra struct net *net, by doing (!maybe_get_net(assoc_net)) directly (as suggested by Daniel Zahka) https://lore.kernel.org/all/20260707185937.3177211-1-kiran.kella@broadcom.com/ v1: https://lore.kernel.org/all/20260703112431.2860506-1-kiran.kella@broadcom.com/ net/psp/psp_nl.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/net/psp/psp_nl.c b/net/psp/psp_nl.c index 9610d8c456ff..43b066353c65 100644 --- a/net/psp/psp_nl.c +++ b/net/psp/psp_nl.c @@ -62,7 +62,14 @@ psp_nl_multicast_per_ns(struct psp_dev *psd, unsigned int group, struct net *main_net; struct sk_buff *ntf; - main_net = dev_net(psd->main_netdev); + /* device may be changing netns in parallel */ + rcu_read_lock(); + main_net = maybe_get_net(dev_net_rcu(psd->main_netdev)); + rcu_read_unlock(); + + if (!main_net) + return; + xa_init(&sent_nets); list_for_each_entry(entry, &psd->assoc_dev_list, dev_list) { @@ -88,10 +95,10 @@ psp_nl_multicast_per_ns(struct psp_dev *psd, unsigned int group, /* Send to main device netns */ ntf = build_ntf(psd, main_net, ctx); - if (!ntf) - return; - genlmsg_multicast_netns(&psp_nl_family, main_net, ntf, 0, group, - GFP_KERNEL); + if (ntf) + genlmsg_multicast_netns(&psp_nl_family, main_net, ntf, 0, group, + GFP_KERNEL); + put_net(main_net); } static struct sk_buff *psp_nl_clone_ntf(struct psp_dev *psd, struct net *net, -- 2.54.0