From: Dinh Nguyen <dinguyen@kernel.org>
To: bp@alien8.de, tony.luck@intel.com
Cc: dinguyen@kernel.org, rounakdas2025@gmail.com,
niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 01/10] EDAC/altera: Fix NULL of_node dereference altr_edac_device_probe()
Date: Mon, 27 Jul 2026 08:24:07 -0500 [thread overview]
Message-ID: <20260727132416.807230-2-dinguyen@kernel.org> (raw)
In-Reply-To: <20260727132416.807230-1-dinguyen@kernel.org>
In altr_edac_device_probe() dereferenced pdev->dev.of_node and
of_match_node() before validating it, which could cause a NULL pointer
dereference when the device tree node is missing. Check the result for
a NULL and bail out with -ENODEV before using it.
Assisted-by: Cursor:claude-4.8-opus
Fixes: c3eea1942a16 ("EDAC, altera: Add Altera L2 cache and OCRAM support")
Closes: https://sashiko.dev/#/patchset/20260719211238.589402-1-rosenp%40gmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
drivers/edac/altera_edac.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 68846f583eeef..d6ca68d74f78a 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -710,9 +710,18 @@ static int altr_edac_device_probe(struct platform_device *pdev)
struct resource *r;
int res = 0;
struct device_node *np = pdev->dev.of_node;
- char *ecc_name = (char *)np->name;
+ const struct of_device_id *edac_dev_match;
+ char *ecc_name;
static int dev_instance;
+ if (!np) {
+ edac_printk(KERN_ERR, EDAC_DEVICE,
+ "Unable to get device tree node\n");
+ return -ENODEV;
+ }
+
+ ecc_name = (char *)np->name;
+
if (!devres_open_group(&pdev->dev, NULL, GFP_KERNEL)) {
edac_printk(KERN_ERR, EDAC_DEVICE,
"Unable to open devm\n");
@@ -757,7 +766,14 @@ static int altr_edac_device_probe(struct platform_device *pdev)
}
/* Get driver specific data for this EDAC device */
- drvdata->data = of_match_node(altr_edac_device_of_match, np)->data;
+ edac_dev_match = of_match_node(altr_edac_device_of_match, np);
+ if (!edac_dev_match) {
+ edac_printk(KERN_ERR, EDAC_DEVICE,
+ "%s: Unable to match device\n", ecc_name);
+ res = -ENODEV;
+ goto fail1;
+ }
+ drvdata->data = edac_dev_match->data;
/* Check specific dependencies for the module */
if (drvdata->data->setup) {
--
2.42.0.411.g813d9a9188
next prev parent reply other threads:[~2026-07-27 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 13:24 [PATCH 00/10] EDAC/altera: Address sashiko reviews part 1 Dinh Nguyen
2026-07-27 13:24 ` Dinh Nguyen [this message]
2026-07-28 18:56 ` [PATCH 01/10] EDAC/altera: Fix NULL of_node dereference altr_edac_device_probe() Borislav Petkov
2026-07-31 13:49 ` Dinh Nguyen
2026-07-27 13:24 ` [PATCH 02/10] EDAC/altera: Fix use-after-free in error paths Dinh Nguyen
2026-07-27 13:24 ` [PATCH 03/10] EDAC/altera: Guard against NULL match data in altr_sdram_probe() Dinh Nguyen
2026-07-27 13:24 ` [PATCH 04/10] EDAC/altera: Fix IRQ domain leak on platform_get_irq() failure Dinh Nguyen
2026-07-27 13:24 ` [PATCH 05/10] EDAC/altera: Fix code leak on dci allocation failure Dinh Nguyen
2026-07-27 13:24 ` [PATCH 06/10] EDAC/altera: Add suppress_bind_attrs so driver cannot get unbound Dinh Nguyen
2026-07-27 13:24 ` [PATCH 07/10] EDAC/altera: Drop __init from ECC setup paths for re-probe safety Dinh Nguyen
2026-07-27 13:24 ` [PATCH 08/10] EDAC/altera: Skip ECC memory init if already initialized Dinh Nguyen
2026-07-27 13:24 ` [PATCH 09/10] EDAC/altera: Detach sb_irq handler when db_irq setup fails Dinh Nguyen
2026-07-27 13:24 ` [PATCH 10/10] EDAC/altera: Fix error cleanup path in altr_edac_device_probe() Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727132416.807230-2-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumar.l.rabara@altera.com \
--cc=rounakdas2025@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®