From: Andrew Morton <akpm@linux-foundation.org>
To: "Yadav, Arvind" <arvind.yadav@intel.com>
Cc: Balbir Singh <balbirs@nvidia.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <david@kernel.org>,
<matthew.brost@intel.com>, <joshua.hahnjy@gmail.com>,
<ziy@nvidia.com>, <rakie.kim@sk.com>, <byungchul@sk.com>,
<gourry@gourry.net>, <ying.huang@linux.alibaba.com>,
<apopple@nvidia.com>
Subject: Re: [PATCH v3] mm/migrate_device: Clear stale mapping after freeing swapcache
Date: Mon, 27 Jul 2026 15:43:30 -0700 [thread overview]
Message-ID: <20260727154330.cbe743a0a9518ccfe2437aac@linux-foundation.org> (raw)
In-Reply-To: <439924d5-b51a-40f7-bd96-42fa43eef0e0@intel.com>
On Mon, 27 Jul 2026 16:28:42 +0530 "Yadav, Arvind" <arvind.yadav@intel.com> wrote:
> >> --- a/mm/migrate_device.c
> >> +++ b/mm/migrate_device.c
> >> @@ -1182,6 +1182,11 @@ static void __migrate_device_pages(unsigned long *src_pfns,
> >> MIGRATE_PFN_COMPOUND);
> >> goto next;
> >> }
> >> + /*
> >> + * reset nr so that only first after-split folio
> >> + * is processed below
> >> + */
> >> + nr = 1;
> > We should also add a VM_WARN_ON_ONCE(folio_test_swapcache(folio))
>
>
> Agreed , but folio_test_swapcache() is not valid immediately after the
> split, as the order-0 folios may still be in swapcache.
> I’ll use just before nr = 1
AI review suggest there might be another bug in here:
https://sashiko.dev/#/patchset/20260727053920.3494211-1-arvind.yadav@intel.com
prev parent reply other threads:[~2026-07-27 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 5:39 Arvind Yadav
2026-07-27 8:00 ` Balbir Singh
2026-07-27 10:58 ` Yadav, Arvind
2026-07-27 22:43 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727154330.cbe743a0a9518ccfe2437aac@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=arvind.yadav@intel.com \
--cc=balbirs@nvidia.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=rakie.kim@sk.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®