From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D0D83BB10E for ; Mon, 27 Jul 2026 15:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785167484; cv=none; b=tyB7R1MmA5bMFCp2xPsHJHd+KRh4G7pkJVanLxJGucLxsR5KvVYS3l72V+bdHz6jZtbHBDOwZJhak00ICyNZozJir8G7B32zpYpVTydGxxHGooL3EuhHUMU/T5jSvDwMhdDTfiSEaHUfMO2oUQVpsPLG2C1L/hLs/7dg6waRJDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785167484; c=relaxed/simple; bh=jp7dYYoCq1NXnvCr+23gaJk3mfP3XYRhH2j1qXZHUdA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Iao9tDCb1Cst4QrQLL7hEXN2+i4LivOlOzgIXMCq0WPwplKGhZju8H2K7tLOMHzoZRY5SGb8P4O8PoYPoRUIXKm1USvSBSqOl/cIm7ygKR8CgfWnHaOYCKmitqQSXiUCqOpFl0h7DAtQbwj7pAxV/qupChdONSHcvgtytQituy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kxsk3E5c; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kxsk3E5c" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c998fd549a8so2024661a12.2 for ; Mon, 27 Jul 2026 08:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785167483; x=1785772283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dk4NfookR28OdkZMjXT+8GOJcuYrohVmOX6Ibnu5M7o=; b=kxsk3E5cZukIYwxF434kDC6Zadbsz1gu3rR6BGFtg4M78ckpCMUQwgVq96YMb8HILc Kb5eMpv44OVL3b8nYHG2MYyhqrM+eiHhKdCPBVsyHO5JfG91LK2WCrgDgxb0J5C+qyC2 j+craRwkgZ6baVQxBdO05Zsy696lDZ06FOkcCc3I3Xf+DJg040p3/qE7UshuDbqz/UkJ 3+EkBHPU5Mn+LbcNsYPuvnIXF3UYN/l170uiYNamjaa1GOyzSMKdnwKBo2Q0Hypdy2ta iNv3gTCTJwYGHkECNQxoLixUu19D9zZynpjTLpMvK5QyVI+9zP4/vKM0JAbS1drnd5QW 7WWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785167483; x=1785772283; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dk4NfookR28OdkZMjXT+8GOJcuYrohVmOX6Ibnu5M7o=; b=KEKuLoQ5mAzvsbf0CJrOhMXdGPk5M7vqREgUeJSo7dsWcqWtLUZzufT7QhNF6GKzNy bG+ESpvLFqfTWMMypElhnO8oi/RdHmXCeHmcBiPY2amkqXjnYS++RZPTjII3TgdjzogJ FbzWe574SIrs3El2XCJaaIsbGB11QaCSZSz+Ptg0FkDMGOrI7kXg1c/NGq6QM+TLIGJ8 ciH+4N2K/ePxle1I7sA0Cn0wejbS7GPC7cWn5uD5TidFPDYVJSMmGj3JSvyH+lSbX+Ad TggtO4w4UnybbhKmSQw5PqMdnsOZezlzoT/UMnFPe349GySCo8lounvNPiwblUEktVlg 3N+A== X-Forwarded-Encrypted: i=1; AHgh+RoaIrKf4b6GfSQ81a+M4Yqi3qN1vem75Ak4q/6maytQBsDt3I3nEhDmkcWh87jmbFD7EG6Pr+FO4qp/yOU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9ff6fjS1LUKl/cIGt0q6k5qoatIja2bO7OGVOhwlXEIlDzovP WT9+D7FZoKbZLejza53uVmpJTbIxYp/qbzU2Du0ctp0evO7Yno6T2HruwhhCI1aIWYk= X-Gm-Gg: AR+sD13r4IZZDllNiZgp6Zn/YdsYTuvAvmlPa0tXygzNGs6p4++Jw6KIjmZ2bew6wX3 +A2yb8XlOeck9PNVF/JnQiR0uw5hnDW670hRIrNc3NAea0yFin7QAUEfVmrGFL95qNYZn8YvV08 Lk4rZpUSprevXZXZGLP3Z1h1uj6XKDA1llY1HrTFzs7Aa+OgryPmLKUtox+nmc25NdplgY3HqQB P3EXhWVXkcaRnmM4NI1zOsfW42DKZ1J7aJaUi6YHetBUcMtqrG2yguD24zIgt1hXP/tNqFDeA/G 7aOeoEj+TEXRFIIKgLY6P6leR5JtVwZdQAyBfvq9PWHEUwJhLkosFJw58mSyyEWQH58ju+pdvgM tkYNkLCkwDFuE0vW8mQxK6PNRqZzhnc0NZ5I2ITumQ2RfveWfRCjrtu/Wwc/jLzJk6fDBz3XXmV iDEde5j34RZQK6CScMT/5MUnow/iZSSg== X-Received: by 2002:a05:6a21:496:b0:3c3:b226:f165 with SMTP id adf61e73a8af0-3c67e060027mr8904446637.35.1785167482418; Mon, 27 Jul 2026 08:51:22 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([2405:4800:5cc3:11a:1ac0:4dff:fe8b:4a69]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc549cacsm33942974eec.16.2026.07.27.08.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 08:51:21 -0700 (PDT) From: Cong Nguyen To: Andreas Klinger , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: srf04: fix pm_runtime handling on probe error path Date: Mon, 27 Jul 2026 22:51:15 +0700 Message-Id: <20260727155115.1855881-1-congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When pm_runtime_set_active() fails during probe, the driver logs the error and unregisters the IIO device, but then falls through and still calls pm_runtime_enable() before returning the error. Since probe returns an error, srf04_remove() is never called, so runtime PM is left enabled without a matching pm_runtime_disable(). This leaks the enable and triggers an "Unbalanced pm_runtime_enable!" warning on a subsequent bind of the device. Return the error right after unregistering the IIO device so that runtime PM is not enabled on the failure path. Fixes: 2251157b335b ("iio: srf04: add power management feature") Cc: stable@vger.kernel.org Signed-off-by: Cong Nguyen --- drivers/iio/proximity/srf04.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c index e97f9a20ac7a..337938657449 100644 --- a/drivers/iio/proximity/srf04.c +++ b/drivers/iio/proximity/srf04.c @@ -331,6 +331,7 @@ static int srf04_probe(struct platform_device *pdev) if (ret) { dev_err(data->dev, "pm_runtime_set_active: %d\n", ret); iio_device_unregister(indio_dev); + return ret; } pm_runtime_enable(data->dev); -- 2.25.1