From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAE18377AA6 for ; Mon, 27 Jul 2026 16:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785170565; cv=none; b=OSeUsLn9kUmezFz2YeRSockjlE4vn1Gh1FwtpqDiL6sI0CAw3ty8fY6Bk8AGeMzN+Dx/BUByE33g8XOKZztk2sy6vCgSZkE9n+B8lgpw8JgIXKffDfPSRRwgznfvQJWmwDJJZz5lm6Y1cJ5vQicXcqNNBypxVHph6gNKOP5eXVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785170565; c=relaxed/simple; bh=5iDeJYZCeHlUEOFlUtiloIg+gGjFgM3gS9AjSTu4e5U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jjyqotCXlsHEoSsT7z4475TIciqN7WSG/iW3C9Xg/m1l6gRfnRTqijB2DwKCbRKeS+heVnul5WO5qulqk4HpMaCoXCoP1sHrZ9WcgoiE1J264pp1N9fGPZj13a26L1oz8y4mSbbq/z5gHGp4r/fqW+PICXRjX+NM+Vxj73JpkAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N2MdP7yZ; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N2MdP7yZ" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ca2fad0ae38so2075576a12.3 for ; Mon, 27 Jul 2026 09:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785170563; x=1785775363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6/mja1ICKKRcKhj2TUV69tW/v5dEq/nIAR10ed1zRw0=; b=N2MdP7yZHLFHzG6fCLYxuMZgxmEhx/+4JjL8qelSZ9zJ1qIStq9nCq1WP6DP3PB44Y Cw34711FTKq3/nBVZWJ4mNcJNUsMlR4VTWdYPcYWNJXDgo/2JN+QgxfSpDa39ShB82Rd kkoR9W6pahkeLcnroGzmJBzmyGmf2Ml7hrKqRZUeWNGkSrf7X/Rydnbf2GprvGkqRSeJ heLxevUAgC8Pv9iMUpFyeVbgM1oSjdOlWKRBFNAG0lgigqRF9gXNNnHsU7N+OD4+2lul 4gOdXYDn0JUHhHeJ47jdx+f9eggb0vpPLFCCw7QN09e3zgDPoUNmzAG8QA5NgypHMZsp wzjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785170563; x=1785775363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6/mja1ICKKRcKhj2TUV69tW/v5dEq/nIAR10ed1zRw0=; b=EblKN1YebXW8HNDgKvPOfvr99yfurn2UaSum8wfL+TJd+E0WCvZQYsjR4WCPYjfa/f RUv9ejARmsVaUxAX3WF4MVfDXS4Jdq8/LytSWKz6V0/GCjavj3SXbNAuPPW4UpE8uGzT gTHb+aJ6REw6x/4RIyI9G5oc3TL8Mf8gGEYYQ14d8WhCgMt/MrCUbL+8pgUJLxNUZWPl s2yZqO9eGbLUtF3NHBZeL+jzdAhJMt3Jtxmoe6epdPiFySnrLgUmxBvXlSlvM5TusHBO /3/SHEoRqE5haC4BcwI2igm4T+yeEIc1xOa6Vbc6UH3nEn+uGd7IqJECTo+/kgNjQvfz Y/RQ== X-Forwarded-Encrypted: i=1; AHgh+RqmMgbVL51RjyLPBLzzXyaSVx6HzDOFHBP1ysuWa7HJm17yyuvTSkcsZPEg1/tVXFjISUAlsdq/29XJ3jw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+6WoH9evtLJStY9JCMgTbK/gxim2zU+uNni6EcCB/zu8DHLZR 10pfX0z/xfCmtf0agA6Cb0DaiCZ3rx9Ge4ClBB4Q8Vp6Er2c4CTyuWIS X-Gm-Gg: AR+sD12OkHjCg7+lLO7zNvlGH2dkuc9MRW79zqcevBCz2dZVV53OFwc1dbFuwUz4WVA 8DciLpzlj16IpK1KAFIG9wN2/++iV7yNb/JLR+jW+qreEJMN17WyFzkWLUtuwcW4f8NvmU2pDnN 3gDibnnYT0gs9ehIykYix+/kRX9Ds879SBeGdF/PmM+9aGoC4vzs+Jcz5Egdtqq3Du2bIGxpmzi iScqpAIs4w5EU4QGBLHzNXc+Uk0VAiwLSZsNWasl6pXRYPSdbM6hivxq8p1w38IdY7L35EQU7PU d7MrM3L4nxRwtxshKxWnbuME68MNmh1Rb9IXvy79lyDmq3Fqy0QHe43yLYz9C8zCjsmG8Hso2ZV KNnCeWoXWI+geYtH16eFrrAyz4p4W6mlbUR+FB3frmsLaZ+vIDbOfzC6oXgBfukvLOvxsFtew55 4EyhKJklGqj/7fipUgy6CxYsw6QYQiBW6JprHE6dmncHLCE8wn4C5ceWUSD2sEv35QCcl1AZsIB LpaOBk= X-Received: by 2002:a05:6a21:700a:b0:3c3:98d3:c20a with SMTP id adf61e73a8af0-3c67e06200fmr8594388637.47.1785170563078; Mon, 27 Jul 2026 09:42:43 -0700 (PDT) Received: from Inspiron-14-5420.. ([2402:e280:21c6:671:8b84:a60e:2cad:e760]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc59cfb4sm33227566eec.26.2026.07.27.09.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 09:42:42 -0700 (PDT) From: "Hemendra M. Naik" To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, jiri@resnulli.us, jhs@mojatatu.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, vishy0777@gmail.com, tahiliani@nitk.edu.in, "Hemendra M. Naik" Subject: [PATCH net-next v4 3/3] net/sched: pie: correct tc_pie_xstats field documentation Date: Mon, 27 Jul 2026 22:10:56 +0530 Message-Id: <20260727164056.106203-4-hemendranaik@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260727164056.106203-1-hemendranaik@gmail.com> References: <20260727164056.106203-1-hemendranaik@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The comments describing `struct tc_pie_xstats` do not match the values exported by the kernel. Update the `delay` field comment to indicate that the value is reported in microseconds, matching the `PSCHED_TICKS2NS() / NSEC_PER_USEC` conversion. Similarly, update the `avg_dq_rate` field comment to indicate that the value is reported in bytes/second, matching the conversion performed by `avg_dq_rate * PSCHED_TICKS_PER_SEC >> PIE_SCALE`. These are documentation-only changes and do not modify the UAPI layout or runtime behavior. Signed-off-by: Hemendra M. Naik Signed-off-by: Vishal Kamath Signed-off-by: Mohit P. Tahiliani --- include/uapi/linux/pkt_sched.h | 4 ++-- tools/include/uapi/linux/pkt_sched.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 9a86fa4d6846..26b7e6964adb 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/include/uapi/linux/pkt_sched.h @@ -920,9 +920,9 @@ enum { struct tc_pie_xstats { __u64 prob; /* current probability */ - __u32 delay; /* current delay in ms */ + __u32 delay; /* current delay in microseconds */ __u32 avg_dq_rate; /* current average dq_rate in - * bits/pie_time + * bytes/second */ __u32 dq_rate_estimating; /* is avg_dq_rate being calculated? */ __u32 packets_in; /* total number of packets enqueued */ diff --git a/tools/include/uapi/linux/pkt_sched.h b/tools/include/uapi/linux/pkt_sched.h index 587481a19433..9bc190f0b3cf 100644 --- a/tools/include/uapi/linux/pkt_sched.h +++ b/tools/include/uapi/linux/pkt_sched.h @@ -847,8 +847,8 @@ enum { struct tc_pie_xstats { __u32 prob; /* current probability */ - __u32 delay; /* current delay in ms */ - __u32 avg_dq_rate; /* current average dq_rate in bits/pie_time */ + __u32 delay; /* current delay in microseconds */ + __u32 avg_dq_rate; /* current average dq_rate in bytes/second */ __u32 packets_in; /* total number of packets enqueued */ __u32 dropped; /* packets dropped due to pie_action */ __u32 overlimit; /* dropped due to lack of space in queue */ -- 2.34.1