From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C428E446062 for ; Mon, 27 Jul 2026 17:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785174244; cv=none; b=PRCFT5fu0uisZKaosDo7vkfKjEiUp/u0LJUleM5lO4q4MqXfsbFkwAT+PuyTVESQsxAQ/VaSUUlnVTHvpinU/cFcUdgW5UjezH0DjmLyyM4JbBUkSruuV39JiG89uneisHa5vfAl3XYrdIcDVSV/5DLnJmw5LipPOR8SB/+34/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785174244; c=relaxed/simple; bh=6u7DX3+fo3Hpy1x1/AmOvfXdSTW4t/zS3PFY+/8vg9Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dzp9hBN0s4ar3iSU2DOaxlYd0+XbYqi2ZyXw8Z261/BQ/1zs+vNcPZI3g8g3Jb2sU1S+6oKyapp9E/Xak6mAtWnrnZyKHDcWewYdcZDtHwPvgjRfsJcUH1BGO9FdzTr6N8FkMDjX7YAdbAB9sZMHoYkMd07HS6pIp7zDLsZ9f10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WBQvujZh; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WBQvujZh" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c9b373d5af0so2176533a12.2 for ; Mon, 27 Jul 2026 10:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785174234; x=1785779034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=1Rex0V6TY2b3wOM9NcHSH2Irs3VMi6WKruAN8XyVVzU=; b=WBQvujZh7HHt1MnBGPtUnTolheT0bMgTkXFuzbnueOJ81PvXxXR1zu4/cFJpiEwvB2 Xg2SeUcKLS63Uqr/kYvHTJuxaLroYNrwyHst8EoMTVaHaWI+NZz6Rl1raGxuIn3E5kad WzvwvFRzw84HELZaqCFrr/HFDFw84AIzhhQfEx+Eif1gVqzPqfwDJFKahVoHK2wxlMhf Rl1vPclNXJlfwX76IZm7uKUTT9f4PGETGUd7TDJgXNxndCkd+1tEy5F46mSjwqBepyGe MRPWN4R2NuXvWig6DpQ5oPsp27rgZ6nNNvUdWDcEDJNuPWiItBDpSZnixGz9wicvkOc7 vU/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785174234; x=1785779034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1Rex0V6TY2b3wOM9NcHSH2Irs3VMi6WKruAN8XyVVzU=; b=BCJSD5on1ZxUHZjKapaPtfg+qDjGv+0PQdSHH7XsPeUzlh9c2u7VhBuHGNwwMJx0VP s6AgSGxzhWvNNeaU0v3Hp0xGoP0SEtV0MuexsxtlMG9LNm59HTxi3L3hbmfOl/hLX5f5 zVKXOAUCCfEf+x5N51ST5yVeHH5p07kEClOXWC4yJKIriwrLVtLqOD5ACPy4Wk8DSmBq pNDX+6fjZqnKT0FGLyx4xb9UFpvHVeqm/oL+M3DfH7qv1l9XSqDefLnj5n2r9jnJQwdR 6tQTiSDbtVEkVfWi6E8/6seLI7xrU6QZsdP/sng1KdwNWTAoipsx77hHoVQMUh4dtKjq pOrg== X-Forwarded-Encrypted: i=1; AHgh+RrqRmlMuOkouDh2HGZ3T7WLHS+niOUkIFzPU+075yZIzg0WDBHQwQgobiodtCpywkrMzcLJ1Tja4p9pRlo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn7EgSRCvi/Q/wpiizs6/Jh8cMIWax3B/A5utWobrjyW8ecgKm R0ATOWfMgBjCOMOZ/C5XcMIiG1JXYJqn267hMW/d0hG1TYXw2pK5aecR X-Gm-Gg: AR+sD13HBWmZon0E3ABrR1jZtYoTtDSPR6oAYJNpojz1clhARMZPD9e3L50iV/cMfU9 0J4h+Qd1dH5He4eAWOXUL5VkIy4WOQNpVkfVSaLOMRd41qiK8AtHlutzNCSYGehhgKMoAJuSKj3 2Onb78iZswI8hHkc8wTBZWr7px1uejzIvjCNTKDfsHv4L6R2yZp35Rf1jC+qzlb0i06Sk1qsxmg iF/s5ebERKvsEimots33orjZbaW5zONbAQ7B3byPx9bNldRBxmqMojp24ZX5FOF2BPb7Nv76iWs d6vnvl22mSP/H7rMV0U+1zulDYTQh7xMJkRAeOst4/63ogGFzGt1/aXz5oEs3U8w70hoTLcQg/s MVSBJfwdrF92kV3u71P3br5odJlLMydEXbFxoDAlpCHEZp8L12p35WWmgxFByliXNLidE20/wm6 +vPXe1lDEJwHRgifdqXPvLE5Xb X-Received: by 2002:a05:6a21:48b:b0:3c3:89cf:f3a with SMTP id adf61e73a8af0-3c67d9a912emr8955450637.5.1785174233680; Mon, 27 Jul 2026 10:43:53 -0700 (PDT) Received: from localhost.localdomain ([103.179.230.83]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e6461ef84sm17454981c88.14.2026.07.27.10.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 10:43:53 -0700 (PDT) From: Sreeraj S Kurup To: o-takashi@sakamocchi.jp Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] firewire: core: validate descriptor and sub-block lengths in fw_core_add_descriptor() Date: Mon, 27 Jul 2026 17:42:31 +0000 Message-ID: <20260727174231.2816-1-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Takashi, Thanks for applying the series to the for-next branch! Regarding the change in generate_config_rom(): I dropped that specific change from this patchset to keep the series strictly focused on the out-of-bounds issue in fw_core_add_descriptor(). `WARN_ON(j != config_rom_length)` acts as an assertion that the ROM block traversal matched the expected length. Replacing it with pr_warn() and clamping `config_rom_length = j` avoids a kernel warning splat, but if j != config_rom_length occurs, it indicates an unexpected state during ROM generation rather than a standard runtime condition. If you feel handling length mismatches gracefully via pr_warn() and updating config_rom_length is preferred over the WARN_ON assertion, I would be happy to send a follow-up patch for it. Thanks, Sreeraj