From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F70542DA45 for ; Mon, 27 Jul 2026 17:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785174820; cv=none; b=XhYmt3u81Pqo2vPWFIl/fGuuydAQyzOl7uETpZhUprBSql0B26x5cB9+es8zWtYBQbdw/1zzuGpRTpV0rgwt3C3yuC4QVltBqSoNKax+h6wSgC6wXT4HiDpEPpM+7tLK+bJDwKCAszsTgbVjy5xRjPGtGT/haVyFszZHi0RUdns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785174820; c=relaxed/simple; bh=cKkNC6xu54bs91lXkDnY86mSeEcUM/fp8tcHTHGcKaI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=U9/1ADePj1bBgbCYsf+EyKpD9y/gAvc60XBlwanDSTmj4vx1PLL2Se8r0mDaCMrar+fG5inwmxkHjFXyEuN52yLg+8jftQo38FxVYoxaccjXaDhg79uMHaHMH0GylXlZ8IqsbZSKyddK1i1EP/z/52OTFx8LGf6FZ+iq0d11Y6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SaG3I45T; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SaG3I45T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785174810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lcVPYQIeblJtEP+34yE/x7AhxVwpjV45NCnPDgJycms=; b=SaG3I45TDlZb10tfLHpuo77AlxmEzZct+RLmv1DyM3Kycak/8DNN48K2tYliwjCLNO+kjQ rPihliCXSVWbCyDgSt7hwgZBbfNdcjwCbVev5AYEO6/xXduRMuqH3WSMPWrajkUZduuV2M qV8GFVtWTUD74J4GAmWf0n7HE5aNMmA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-G1hfIIenPT2FTAPYIrG6qg-1; Mon, 27 Jul 2026 13:53:25 -0400 X-MC-Unique: G1hfIIenPT2FTAPYIrG6qg-1 X-Mimecast-MFC-AGG-ID: G1hfIIenPT2FTAPYIrG6qg_1785174803 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7FE0919775FE; Mon, 27 Jul 2026 17:53:21 +0000 (UTC) Received: from GoldenWind.lan (unknown [10.22.65.215]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F04541955F7B; Mon, 27 Jul 2026 17:53:17 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: "Timur Tabi" , "Dave Airlie" , "Andy Shevchenko" , "Maarten Lankhorst" , "Ben Skeggs" , "Kees Cook" , "Simona Vetter" , "David Airlie" , "Thomas Zimmermann" , "Maxime Ripard" , "Mel Henning" , "Danilo Krummrich" , "Lyude Paul" Subject: [PATCH v4 0/3] drm/nouveau: GSP runtime PM fixes Date: Mon, 27 Jul 2026 13:47:41 -0400 Message-ID: <20260727175246.642071-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Runtime suspend/resume has been notoriously flakey since we started using the R570 GSP firmware, and possibly was also flakey for some time when we introduced GSP support initially. These fixes get runtime PM to be dramatically more stable then it was before. Unfortunately even with this patch series, there are still some remaining issues that need to be fixed. These likely stem from the currently different code path that we need to take with these fixes in order to get suspend/resume working. While we're making progress in understanding what exactly we're doing differently from OpenRM that makes this the case, it will likely take us a while before we actually have things working well enough to copy what OpenRM does. Taking precisely the same path that OpenRM takes however, will require some additional work - and at the very least these fixes do appear to get suspend/resume and runtime PM working the vast majority of the time. Thanks for nvidia for providing context into what all of these various flags and settings do! Previous version of this patch series: https://patchwork.freedesktop.org/series/169457/ Lyude Paul (3): Revert "nouveau/gsp: fix suspend/resume regression on r570 firmware" drm/nouveau/gsp/r570: Set GcOff = 1 in fbsr drm/nouveau/gsp/r570: Enable S/R Display workaround in GSP drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/fbsr.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c | 8 ++++---- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c | 3 ++- .../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/nvrm/gsp.h | 8 ++++++++ drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h | 2 +- 6 files changed, 17 insertions(+), 8 deletions(-) base-commit: df0311845915442ab75d03ee89fb443b444c1370 -- 2.55.0