From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F327280329 for ; Tue, 28 Jul 2026 01:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785200803; cv=none; b=gKmGV9uxeBj4ebzforeWX396514y0UYaAqldnJ/JzoSsWeyQd9C24mH4z4qt5MPhNfCMNnRT2aEraj0QkECXAaWNBKeUBeFKd75dv1OcAp3iXTqbTM+Lnw8rujMFHPcuDUp5f/bMBukL1deKqPMhMuN7W+Y6/3KAYxNX7ZfX1sw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785200803; c=relaxed/simple; bh=t7T9MekS8964gOsB2KopfOrQbZghOJGGlKgCpR/Zksc=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=TE1ZjL1k+/7RD7dY/SkyWASK4OQg0Ji66f/jR05UDqUhRFHH/iCvz/lgTGBVWWtzDNyOcXuabLnZEvttcmHCWk6JSWC5IrIGTP6tMnIW9ANePqdDaDYTT3vcJ6AP/N/qlGvcnKinaV664BI0uSyJ4LUoc4cpXuPDKzHT9crZqJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=MyE74oIK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="MyE74oIK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C03C1F000E9; Tue, 28 Jul 2026 01:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1785200798; bh=PmhwqFxG4hIXpC206+thwZnVHJSxpqM2ktEHgQB9FNw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=MyE74oIKpNKUOWtZIoybseJk2SlKb3ZlG9DREi3qPBqyLO9eHkRtsNIt22cWj9hlv ozkVqrTCQDlfIiB1ibG9DLTdMBRymk8ntEKJ7/Qy3+x4tZLxaiyPhzFYHpwB/LdnQi QfcKVtd4aRXDjSCpIBfWtd2vcRuIKCkrVtaUwulo= Date: Mon, 27 Jul 2026 18:06:38 -0700 From: Andrew Morton To: Ramin Moussavi Cc: Michal Simek , Mike Rapoport , linux-kernel@vger.kernel.org Subject: Re: [PATCH] microblaze: restore the page alignment of swapper_pg_dir Message-Id: <20260727180638.99406eb86b56c8c3283383f5@linux-foundation.org> In-Reply-To: <20260727215823.1422701-1-ramin.moussavi@yacoub.de> References: <20260727215823.1422701-1-ramin.moussavi@yacoub.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 27 Jul 2026 23:58:23 +0200 Ramin Moussavi wrote: > microblaze handles TLB misses in software, and the handler builds the > address of the L1 entry by ORing the index into the page directory base > instead of adding it (hw_exception_handler.S): > Well that was a convincing changelog. > > Fixes: 6215d9f4470f ("arch, mm: consolidate empty_zero_page") I'll queue for 7.2-rcX. > Cc: stable@vger.kernel.org With this. > --- a/arch/microblaze/kernel/head.S > +++ b/arch/microblaze/kernel/head.S > @@ -39,6 +39,8 @@ > #include > > .section .data > +/* The MMU requires a page aligned page directory. */ > +.align 12 > .global swapper_pg_dir > swapper_pg_dir: > .space PAGE_SIZE Thanks. Hard-coding "12" is a bit sad. Can we do ".align PAGE_SHIFT" or similar?