From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCFB63C13E2 for ; Mon, 27 Jul 2026 18:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785178156; cv=none; b=Q/aGPw9BQH9KihqaZmLfXN4lwwAHo1bPFRiYTvcLCKicPn+HyUET//8tYJ/NKXzI6ympSVG9CgKUdP8asy58tfH4oA5X8Rs/ojqpnm6BS25Z3m4pwZ2DrV90lNgO4y/HJEGDlMpx1cQ3A1SHELTkJd8WZV4k2FQ6yWuQsFDdxrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785178156; c=relaxed/simple; bh=gjRCHi7E9q40XAs/FtWoHLouOKq6U/tlfkiEOPIIiwY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GdvsnISh5FR4ci1kmVC0jiggV4UY9A6vjx+KT1Y+SeqNrSJMJKRFOpjB6hU/gBAdy3lBPvGLw5FXVpQpXooE6pDh1YC93dXQzV+awhU7Chbl+mbrSAxrvgf4P+OIe489KYmHldrfRBBFJfvoz5GPy4S3wkVWwDmnP5KE/1Hk5mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CErUkmGy; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CErUkmGy" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cee9b74ee1so24263175ad.3 for ; Mon, 27 Jul 2026 11:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785178152; x=1785782952; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+kG0TOSSfRZaOeIFJQE2yOSnOHWGL8m22qKwF+ZDhYA=; b=CErUkmGyNHufS3//MTi4wsai6bXDXpVkpzx0R/54BIj8Y92aLVqS/nUNz2MiK2xy9o f1iu22Gq6QE+/sJTp/Jx+8jD2UrZvbny/gabJmKv14d7MjrRRhowgEa0Us0Kx9y+vfww H/JTnRCw5suTzxuwN+qC5kFJk7rO1nir24KayvFX9TfasH+0ijTRkkJVCiDUKGexMuyj ACqwwFlLmbbtTs5aQTofA1AXqrX92R5Yd2+6OwdyBlEcspenhqznDbTETMnCnOvu6mO7 STUmqMr71P/YPkrc+VHR1tmKIT57wlru/nOZYv79K5qR9hNvZzumPWl2r0rPKsCi29l2 UGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785178152; x=1785782952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+kG0TOSSfRZaOeIFJQE2yOSnOHWGL8m22qKwF+ZDhYA=; b=X5E574DdGkA/mraEMvH5vMILnbtkDiMclZS6bncPxzccShGSVSJqimiPq2xQatncbQ GN+s7Y1DlRC4cSze5FKW4NxNfnN0Q7fXohnL+h53tGmvxBF8MfFVX3OGl+74R+me63VE IsTYnYZZKHnlKzDHcxTXm5whtRoJYAo+lARjuFsCOxDSy9aZYwbuYs8Z5Ceucl1LynUz e8lMF5PhJ18WjMsoiyoZ+oJRi0sUZMYs3/kDO0VilZmM6SRCB2InyGELcpcIb/jt2kCK 5Y+hiCUljr3lQb4Cc249ihD3LMdttH4LoQmIUwHFmhttzooQ46rBC5xYk1ON9urOUUO7 SlWA== X-Forwarded-Encrypted: i=1; AHgh+RrwqT1oNR6Om700KTIM8ssWWiC/KSXV9SJqAsKtfGNhX3ZbTSykMcOy83mAmLq5pSVCUxtanHaLP5GEh3I=@vger.kernel.org X-Gm-Message-State: AOJu0YzsNEb/UF6GrG2Un8dETNNbopwsgcxlp9/MmPWEsmOv1IxqYGtN kbyhHHyfL300dVcDq3nqcaS50rTjDzdHvKxYZ7QlGn3xKOwZM+CCzj0H X-Gm-Gg: AR+sD13H/glUlEDM7SqnbykyaBgLWp12JClwnwn5YpMJSlFFIqDxQAGnNb5uvmg/Q2x 9Nk/7FHNi50hfbySjtQP6oxYYPLG6fF3/AlA21+pILmgN6+j0dif+fA+k7iR5h5bZe5CS4N5FIq B89xalcHP3zfXbLscsuDr0Ac727bVEDlE6tmT4KAp6I/FDWEZv9++08G6TpM/V2hQqVfcHBtnGa B6e7wBTG3fffSy4RAJ8H1EYvDu9qpp6eFG9qYXI7oZv1XLxegmWRyXSPGK7SLb9HvgxxtHXKRm/ UCk5s7lim+yU13noOyDGghGdpWcddJdEzD9uE0/Nq22atgBZWIQmCDeK6wrMP6iBLbeH5jRjr+x 6F1wa2yQh9k6gwDweHQ3o2FJitrd8RYOm/1VOWAe4NPTVngRoPpoqtQOAb1gepD0Ch44lXg5f X-Received: by 2002:a17:902:ebcb:b0:2c9:97a8:afe7 with SMTP id d9443c01a7336-2cfde8a53f3mr86689705ad.42.1785178152163; Mon, 27 Jul 2026 11:49:12 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde7d7b87sm40186245ad.57.2026.07.27.11.49.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 11:49:11 -0700 (PDT) From: Sang-Heon Jeon To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , Geert Uytterhoeven , Linus Walleij , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Marek Vasut , =?UTF-8?q?Nuno=20S=C3=A1?= Subject: [PATCH 4/9] iio: light: tsl2583: remove tsl2583_set_pm_runtime_busy() helper Date: Tue, 28 Jul 2026 03:47:41 +0900 Message-ID: <20260727184755.2055414-5-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260727184755.2055414-1-ekffu200098@gmail.com> References: <20260727184755.2055414-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tsl2583_set_pm_runtime_busy() just calls pm_runtime_resume_and_get() or pm_runtime_put_autosuspend() depending on its bool argument. Call them directly and remove the helper. No functional change. Suggested-by: Jonathan Cameron Signed-off-by: Sang-Heon Jeon --- drivers/iio/light/tsl2583.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c index 54fa426c5755..06da145569f7 100644 --- a/drivers/iio/light/tsl2583.c +++ b/drivers/iio/light/tsl2583.c @@ -639,14 +639,6 @@ static const struct iio_chan_spec tsl2583_channels[] = { }, }; -static int tsl2583_set_pm_runtime_busy(struct tsl2583_chip *chip, bool on) -{ - if (on) - return pm_runtime_resume_and_get(&chip->client->dev); - - return pm_runtime_put_autosuspend(&chip->client->dev); -} - static int tsl2583_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, long mask) @@ -654,7 +646,7 @@ static int tsl2583_read_raw(struct iio_dev *indio_dev, struct tsl2583_chip *chip = iio_priv(indio_dev); int ret, pm_ret; - ret = tsl2583_set_pm_runtime_busy(chip, true); + ret = pm_runtime_resume_and_get(&chip->client->dev); if (ret < 0) return ret; @@ -722,16 +714,16 @@ static int tsl2583_read_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->als_mutex); if (ret < 0) { - tsl2583_set_pm_runtime_busy(chip, false); + pm_runtime_put_autosuspend(&chip->client->dev); return ret; } /* * Preserve the ret variable if the call to - * tsl2583_set_pm_runtime_busy() is successful so the reading + * pm_runtime_put_autosuspend() is successful so the reading * (if applicable) is returned to user space. */ - pm_ret = tsl2583_set_pm_runtime_busy(chip, false); + pm_ret = pm_runtime_put_autosuspend(&chip->client->dev); if (pm_ret < 0) return pm_ret; @@ -745,7 +737,7 @@ static int tsl2583_write_raw(struct iio_dev *indio_dev, struct tsl2583_chip *chip = iio_priv(indio_dev); int ret; - ret = tsl2583_set_pm_runtime_busy(chip, true); + ret = pm_runtime_resume_and_get(&chip->client->dev); if (ret < 0) return ret; @@ -786,11 +778,11 @@ static int tsl2583_write_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->als_mutex); if (ret < 0) { - tsl2583_set_pm_runtime_busy(chip, false); + pm_runtime_put_autosuspend(&chip->client->dev); return ret; } - ret = tsl2583_set_pm_runtime_busy(chip, false); + ret = pm_runtime_put_autosuspend(&chip->client->dev); if (ret < 0) return ret; -- 2.43.0