mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Andy Shevchenko" <andy@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Linus Walleij" <linusw@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
	"Nuno Sá" <nuno.sa@analog.com>
Subject: [PATCH 5/9] iio: light: vcnl4035: remove vcnl4035_set_pm_runtime_state() helper
Date: Tue, 28 Jul 2026 03:47:42 +0900	[thread overview]
Message-ID: <20260727184755.2055414-6-ekffu200098@gmail.com> (raw)
In-Reply-To: <20260727184755.2055414-1-ekffu200098@gmail.com>

vcnl4035_set_pm_runtime_state() just calls pm_runtime_resume_and_get()
or pm_runtime_put_autosuspend() depending on its bool argument. Call
them directly and remove the helper.

No functional change.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 drivers/iio/light/vcnl4035.c | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index d13c5ff33e07..ce1bd42b0c7c 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -145,16 +145,6 @@ static const struct iio_trigger_ops vcnl4035_trigger_ops = {
 	.set_trigger_state = vcnl4035_als_drdy_set_state,
 };
 
-static int vcnl4035_set_pm_runtime_state(struct vcnl4035_data *data, bool on)
-{
-	struct device *dev = &data->client->dev;
-
-	if (on)
-		return pm_runtime_resume_and_get(dev);
-
-	return pm_runtime_put_autosuspend(dev);
-}
-
 static int vcnl4035_read_info_raw(struct iio_dev *indio_dev,
 				  struct iio_chan_spec const *chan, int *val)
 {
@@ -202,11 +192,11 @@ static int vcnl4035_read_raw(struct iio_dev *indio_dev,
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
-		ret = vcnl4035_set_pm_runtime_state(data, true);
+		ret = pm_runtime_resume_and_get(&data->client->dev);
 		if  (ret < 0)
 			return ret;
 		ret = vcnl4035_read_info_raw(indio_dev, chan, val);
-		vcnl4035_set_pm_runtime_state(data, false);
+		pm_runtime_put_autosuspend(&data->client->dev);
 		return ret;
 	case IIO_CHAN_INFO_INT_TIME:
 		*val = 50;
@@ -237,7 +227,7 @@ static int vcnl4035_write_raw(struct iio_dev *indio_dev,
 		if (val <= 0 || val > 800)
 			return -EINVAL;
 
-		ret = vcnl4035_set_pm_runtime_state(data, true);
+		ret = pm_runtime_resume_and_get(&data->client->dev);
 		if  (ret < 0)
 			return ret;
 
@@ -247,7 +237,7 @@ static int vcnl4035_write_raw(struct iio_dev *indio_dev,
 		if (!ret)
 			data->als_it_val = val / 100;
 
-		vcnl4035_set_pm_runtime_state(data, false);
+		pm_runtime_put_autosuspend(&data->client->dev);
 		return ret;
 	default:
 		return -EINVAL;
-- 
2.43.0


  parent reply	other threads:[~2026-07-27 18:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 18:47 [PATCH 0/9] iio: fix write_raw() return values and remove pm helpers Sang-Heon Jeon
2026-07-27 18:47 ` [PATCH 1/9] iio: light: isl29028: return zero in write_raw() on success Sang-Heon Jeon
2026-07-28 19:54   ` Brian Masney
2026-07-27 18:47 ` [PATCH 2/9] iio: light: tsl2583: " Sang-Heon Jeon
2026-07-28 19:55   ` Brian Masney
2026-07-27 18:47 ` [PATCH 3/9] iio: light: isl29028: remove isl29028_set_pm_runtime_busy() helper Sang-Heon Jeon
2026-07-28 19:57   ` Brian Masney
2026-07-27 18:47 ` [PATCH 4/9] iio: light: tsl2583: remove tsl2583_set_pm_runtime_busy() helper Sang-Heon Jeon
2026-07-28 19:58   ` Brian Masney
2026-07-27 18:47 ` Sang-Heon Jeon [this message]
2026-07-27 18:47 ` [PATCH 6/9] iio: light: vcnl4000: remove vcnl4000_set_pm_runtime_state() helper Sang-Heon Jeon
2026-07-27 18:47 ` [PATCH 7/9] iio: adc: rcar-gyroadc: remove rcar_gyroadc_set_power() helper Sang-Heon Jeon
2026-08-01 20:19   ` Wolfram Sang
2026-07-27 18:47 ` [PATCH 8/9] iio: light: tsl2583: remove conditional return with no effect Sang-Heon Jeon
2026-07-28 19:59   ` Brian Masney
2026-07-27 18:47 ` [PATCH 9/9] iio: magnetometer: ak8974: " Sang-Heon Jeon
2026-08-01  2:36 ` [PATCH 0/9] iio: fix write_raw() return values and remove pm helpers Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727184755.2055414-6-ekffu200098@gmail.com \
    --to=ekffu200098@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=geert+renesas@glider.be \
    --cc=jic23@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®