mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Dmitry Baryshkov <lumag@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] soc: qcom: PDR_HELPERS, PDR_MSG are independent of QCOM_SOC
Date: Mon, 27 Jul 2026 14:11:24 -0700	[thread overview]
Message-ID: <20260727211124.853520-1-rdunlap@infradead.org> (raw)

Currently QCOM_PDR_MSG depends on QCOM_SOC (it's inside the
"if QCOM_SOC" block). It appears to be independent of QCOM_SOC, as
though it was entered in the wrong location in the Kconfig file.

Moving QCOM_PDR_MSG after the end of the QCOM_SOC block fixes the
kconfig unmet dependencies warning and survives both randconfig and
allmodconfig builds.

WARNING: unmet direct dependencies detected for QCOM_PDR_MSG
  Depends on [n]: QCOM_SOC [=n]
  Selected by [y]:
  - QCOM_PDR_HELPERS [=y] && NET [=y]

Caused by SLIM_QCOM_NGD_CTRL selecting QCOM_PDR_HELPERS.

Fixes: 0ac5c7d933de ("soc: qcom: pdr: extract PDR message marshalling data")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: Dmitry Baryshkov <lumag@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>

 drivers/soc/qcom/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-next-20260726.orig/drivers/soc/qcom/Kconfig
+++ linux-next-20260726/drivers/soc/qcom/Kconfig
@@ -90,9 +90,6 @@ config QCOM_PD_MAPPER
 	  implementation of the service. It is a simpler alternative to the
 	  userspace daemon.
 
-config QCOM_PDR_MSG
-	tristate
-
 config QCOM_PMIC_PDCHARGER_ULOG
 	tristate "Qualcomm PMIC PDCharger ULOG driver"
 	depends on RPMSG
@@ -297,6 +294,9 @@ endif
 # Options selected by other drivers from different subsystems must be outside
 # of the menuconfig if-block:
 
+config QCOM_PDR_MSG
+	tristate
+
 config QCOM_INLINE_CRYPTO_ENGINE
 	tristate
 	select QCOM_SCM

             reply	other threads:[~2026-07-27 21:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 21:11 Randy Dunlap [this message]
2026-07-28 14:28 ` Julian Braha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727211124.853520-1-rdunlap@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®