From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 102863D6493 for ; Mon, 27 Jul 2026 20:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785182692; cv=none; b=kjhLbh3DPsuc81OKmsx6VYhicRyC+GYKC3X2aLn1DXW4klSv9R22Jl8BnEcwpm1zkJjYE5x1q5mRdUtA2AeEA2YUFFdV7xm86Tp3l2FDauhd44gj6zRkJL7UTnw3DP8j4HBACmH2gDM66RjzEKISaX3UQ6s/BU56P0cK4lIlt+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785182692; c=relaxed/simple; bh=XcvXLQlxS7Pr3e57S+wBcJe00z1ahG1O/bqchT3JOHw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EnqWSmeGkem1UHZCC8pTSB+WXYrvGkQPbxparZ6xWLaQVjEBopud9kGv8ch5pBfXxlXMX+d04I2oJEJ36Iqo0+PS//Y9+buhO5uRrOfKnRhkrHDcs00wVRZTR5dV6GkCXID/Zjxnf4nh8fRdDIp34Jquj30M6A1kv3z1VKnZVi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=Bv2KjBH2; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="Bv2KjBH2" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=NspwG6ABO/FYOE9rIEFlIMurhhb6P0XuMLDrCAYAYl0=; t=1785182691; x=1786392291; b=Bv2KjBH2hqjjuS2TQEf7s/uj/3zs7lCj1E1AaVMtsAZeZ0noMnBBrtZd1C8/m4gaFGUdmJJKXjS gwXQ++j11jdI5cBElAt/phYnnNCk71D6eD2mXT7Hhsxyv0LlOYLtyULxlbK17n3ocz+ezEf1KJjLE o+nC8DGLkexDO3o14caFsblGFLvVKu7rZngGfyerOvM8HwVGVP+MPjkJ00UUPtwMRsGI1RLsbeZq1 SIGUopWQqmVb1FRsD6l6FzmORpYnCkLxq1M6aJvKOLItgGReGY57HVrro+PzPODQpQnZ9XiKpwOUr 7HVW2JEa3uSrHgHulFP/J9XLEjDdRpIUOkBA==; Date: Mon, 27 Jul 2026 22:04:38 +0200 From: Andreas Kemnade To: robby.cai@oss.nxp.com Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/2] regulator: fp9931: Fix VPOS/VNEG voltage selector table Message-ID: <20260727220438.2a5bf1a8@akphone> In-Reply-To: <20260721095959.1855436-2-robby.cai@oss.nxp.com> References: <20260721095959.1855436-1-robby.cai@oss.nxp.com> <20260721095959.1855436-2-robby.cai@oss.nxp.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; aarch64-alpine-linux-musl) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 21 Jul 2026 17:59:58 +0800 robby.cai@oss.nxp.com wrote: > From: Robby Cai > > The VPOSNEG_table[] mapping does not match the FP9931/JD9930 > datasheet. > > The datasheet defines the VPOS/VNEG voltage mapping as: > > 00h-04h -> 7.04V (-7.04V) > 05h -> 7.26V (-7.26V) > 06h -> 7.49V (-7.49V) > ... > 28h-3Fh -> 15.06V (-15.06V) > > However, the current table maps selector 0x05 to 7.04V instead of > 7.26V, causing all subsequent entries to be shifted by one position. > > Update VPOSNEG_table[] to match the documented register encoding. > > Fixes: 12d821bd13d4 ("regulator: Add FP9931/JD9930 driver") > Signed-off-by: Robby Cai Reviewed-by: Andreas Kemnade