From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011012.outbound.protection.outlook.com [52.101.62.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AF963DEFF1 for ; Mon, 27 Jul 2026 22:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785190147; cv=fail; b=hS1d9hgoBJjAv5cMcUiZNFN780lNHrsXyQEm7W5FdPcBcKFiwyS3IczO+DapiLA77KyIYgG2Bwxdq4pNbcoj1Gqsa2B6ew0hXs9Qf85vZywq6koNaeMauWuByT0bPiWBkRc66Gu9NKkTaxW4aQb+zoLhuAgr+0XDR2wLdCeKlkQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785190147; c=relaxed/simple; bh=oo+n4yQjjlOnYRzlkcXNdd3Gf0M436IvV7B4YYfU6i4=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=LokQVTIY4yE4THwQ1I6rWmkTwhJn8Cs8q2TYLLefYXelYF36JAZN9LDcqNELxwNNPVOcx3uJwr9DVb1IUGPIF4cfXP9cKrhEL5ndueaNRM6Q5XUp9eWUFQ+ATJ3RiJE9HnO/WuHSTILsPvX9oWHDgtB7Ymy2v/pXFEE0Aysfh70= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=YgRRypwj; arc=fail smtp.client-ip=52.101.62.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="YgRRypwj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XM+ITerOLBl0vMoBpF2ijHBpiDz2qxrcJAKIn9EQFVkmnT24CkgLN33he6Mh+p8iC0Tuz+IZ2fojtFFzT+J2pLxDVgeAADb+6/fdDBjV0HMZIXE7In95397fc2BUTgdSK0FOWSSXB/C+QKEWktzWupunuoLVzebskVmBDXnDP4rDikVwfA1RvrJ73vwoBDsEGiL4KE7TQ3bt7GskHGDwi0nODpk4ze1pbEdtcXi2x59K7zCObXPxD1aeBpBztq2Z1Aifh36PanAR0t+I6CGbqwiXW4zwfoDVUGKdCdZ8AIkOaHP0yc9fjrD/MmqzgJRpvOn9nOoN0hF+qjbccAp+6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HOXLoF2DGlsQvzZmRP6VnG3rd3Hmk1fqXfD3zcKiCGM=; b=CNQisDY67QGxUdSti+NymVdHbFItHh+EhxIrIb63khpxfou1b8NuN/CqWC9o35sJ6LANsILPCrF766qVmZtn6oiUTHbr6jeozI0akgGgx43Voz4qHvpZMW0ILfTFf+FMW8PzOer1j/JtboPsbSGoG7TPWfjRFLJQ/B4jN7iNfy+4UmHn00A24X7WnpBOs7xpZJALgAp0mhm5A370w+k8ND82UYNJkrBxiw0GFJHhWICQDAo7FJpOTcguDJZdDlXOR5cUJTxsaf6wW3zp1xJsIJ7D2wofo66/EGYVLrn9wx4q1XJWqOVhKxOGhWsKxVbdxT9AnS3DJE01go/rZbxqag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HOXLoF2DGlsQvzZmRP6VnG3rd3Hmk1fqXfD3zcKiCGM=; b=YgRRypwjgrIx6yjy03dVRHdN1tjoF4zaOpeMGa/iiCGKOfouO9+Vd5UYeAnfULuoKSMxxkQzTJt6xs5ntEP4AL4R7NHyxfbBnqAiHecv5oPVmvWfNYbf3hNq57KHtvK/d0pPdYbTuBYD5k+pOuPO2BLKklzhzpMrgALC9IKyOfk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6374.namprd12.prod.outlook.com (2603:10b6:8:a3::18) by SA1PR12MB9546.namprd12.prod.outlook.com (2603:10b6:806:459::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Mon, 27 Jul 2026 22:09:02 +0000 Received: from DM4PR12MB6374.namprd12.prod.outlook.com ([fe80::af35:a7a6:6ca:7fcf]) by DM4PR12MB6374.namprd12.prod.outlook.com ([fe80::af35:a7a6:6ca:7fcf%3]) with mapi id 15.21.0245.012; Mon, 27 Jul 2026 22:09:02 +0000 Date: Mon, 27 Jul 2026 18:08:54 -0400 From: Yazen Ghannam To: Borislav Petkov Cc: Lin Wang , mario.limonciello@amd.com, tglx@kernel.org, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/6] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Message-ID: <20260727220854.GA941383@yaz-khff2.amd.com> References: <20260709075549.626095-1-wanglin@open-hieco.net> <20260722195913.GEamEhEWeBNt65mHmy@fat_crate.local> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260722195913.GEamEhEWeBNt65mHmy@fat_crate.local> X-ClientProxiedBy: SN7PR04CA0021.namprd04.prod.outlook.com (2603:10b6:806:f2::26) To DM4PR12MB6374.namprd12.prod.outlook.com (2603:10b6:8:a3::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6374:EE_|SA1PR12MB9546:EE_ X-MS-Office365-Filtering-Correlation-Id: f4f7af7c-9233-4839-6599-08deec2baa99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|23010399003|366016|11063799006|56012099006|4143699003|10067099003|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: n1/fa2SuCP8VreBlqEhZQ23V41KHAEjeJsIgejue9+SH7XDcj3dPrJiZKldImkrHgGgixhqMJvetzYBQzlIPfVMpoUT03roXVUb8wZl/tUMfuVtaJRsCWvbQjCeuSEJvYGhyBqITZPqygl6nQzrUIHr3gEL4r/7O8cQhfVY3XBVCAgPEdsZ92rcicsJ4djNDUZqW56DgD9m8k+mhLMNpVXeUVrCGDh5scZ7Ki5RFVgCrW66l+alYgMYrFSwQkiOYqSXYyvMqDxDrpZxdIpBG65xVF+zK6zUzfm201LdPCGsuNmEel1h+7sqZWe4pujKYsxXmzsKRYcWWd855Uz4VX2XcUwpqhSf2Jfq9JRyE6R3BRum6GJ20Qfol+Nbwk7heH5DWOm+NSI8nhdDEwHTWgql3YytU6xCRH8AwnkDnFt7HpOzTswAm+nCfF+RDG2bCJDNHtkZ8UFD+x5zf6L9B/L08JXzhYzibFWzGFbz+Wvbl0UUdF9yGrIZ+b9z8GVa3iuYiaqP9qkcdtKRmXWfOjftDHExh3Chj4Z3yD0qonZqaW1CAfXG9OKNb4vnoFjJPogfZR7Rt9kyackTnk5YdOxevDysYGz/UH2IBY4/7swo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(23010399003)(366016)(11063799006)(56012099006)(4143699003)(10067099003)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LKJv2PvW/gzoASgK5G/vcu84q4CswqTXERhsTs0dsHHbJ0kFf7E2mUXqBE5/?= =?us-ascii?Q?8vZtpTdOoSTbhjSCoB3dTDmSQsMfCCImvQ31U3xq/EBaLw2W3lcXLnkWq1DX?= =?us-ascii?Q?IlOYldDag390gd2i7lwy+KJBmQaXCIzHavRap1nWGyHBIZ2+SYGniV4xbE0f?= =?us-ascii?Q?VP7ilJRNaLV2EhrkeyACcRWBtIPm1/XXCT3p9JiG9NKzj1kh9GZtljYjv10l?= =?us-ascii?Q?k1WVSryfpuwsybgCLex1rCJHAJ/vmHFMOa5u2JKXMOJ644x2I1OMKx5Wv2f9?= =?us-ascii?Q?WsG8hir08dYZLOqdIFN7RPy1Iyj6fCu2KCLNcVRfPHeK2JVYKJZvTeCsbABf?= =?us-ascii?Q?nVpC59S6R7QNlwx33zEkwoogUs4B3mqHgBMKwO6ElJuM9zMjW1WwUClMqecX?= =?us-ascii?Q?HeHmZ5zMZ7OY2CDxVhfiWrMEHRBy+rz5xSDlcZwd7ccwCV0vsi3n9NgrlV3Z?= =?us-ascii?Q?xjr78VieW6wll2oWVrKM0aR8NfsZ7H5MhCdCsZc3YVkYC+IQ1j3OAmaeVtEz?= =?us-ascii?Q?FU8gtKj4Ipx46SVvy0r7fXveEXU7LiiY3xPjffgB2V/stIgnXwxGWvXEoEzG?= =?us-ascii?Q?y5XMGVsq9fO87VymcmwyUZRh/rsBoIQFQgysi3C15qpanCKkhOUpvS5gkPDf?= =?us-ascii?Q?StLTKKy6rioN+a3lO4V87tWSQ8FBQE98hvHcIJ8IgsEFhQsQ7ZSp9pnCuT3f?= =?us-ascii?Q?vqYTBC0XvUxchxbHuX2z2MA3z+gGAWpki/p+8M+Ws+8eDmhIMAPuZbWtPNjx?= =?us-ascii?Q?YUYAwAWPo+tTKGJEC9nPowPkCe14A/3Y265W0RPrm4aJxI1y6lz0jxEA0qmS?= =?us-ascii?Q?6eVr09UENYo5o81EFF4p8yR2lQ7z1qSicIiP7BYFk/C/2nWBO29yXNIlhAWE?= =?us-ascii?Q?SEoi/uXCYgc5O1QighI9QJ7gJYa3/8fidmMuBdWl7XnROA5mZkIkPTA6ViGE?= =?us-ascii?Q?yC/RDBLSPvk+d4PedNlX3kcDIlUiQRP2UGsAc2JF/TYiysnfICMkhLtAt2NK?= =?us-ascii?Q?5C3A3fcqjITJ8d7SiLcel6pilgg5Of3jJm6HgOGW0ihUPQc53zLdOVADaOmE?= =?us-ascii?Q?sMu7lZDEcr1fCTGvYaOvVK/lVxqw/9A0eXPDRVOmIr2TMd8yHjXOd49dcJPB?= =?us-ascii?Q?fArInv40gfRSofxe5L7ABSUJ0FfIDL6zTf4mErxepeByNdgiZ1P7fBW34rq7?= =?us-ascii?Q?D7kgGYaPBPAKIxhajEb2I+VVSpTMQdhf9mUjNKToMBKeWYPZW4q583kRuFP0?= =?us-ascii?Q?S3qzL7sap46ONQpFVY6+YyVm8Th4VqdCW67tu6IBUa+Riizl6mh7J9AFX3+W?= =?us-ascii?Q?ebBo0O4onRW9zHbag32saNwQy9OapYy85tZU23ZK+9GHtUCbZUna7EuHm2qZ?= =?us-ascii?Q?1aWQORPx8uGQUHJL4cedY4AalVJR1VQIrFSWijGVNcrolWRukdKzpYj4qhId?= =?us-ascii?Q?B73R7UetnHDpx6FK5cdDacmOIRpm30RCjqQQbX98hj4D5DEGXCvVFKK1Y/O4?= =?us-ascii?Q?FGIqB/3inyidLBhhpAWIRxRNnqClcjW3cmymqYNCbtAy84r6Gqcgwe8KIbXA?= =?us-ascii?Q?YWzKxAjCMR9uNk6s/J0rgHZwAPCAKBFD7d24H9Rr9XScslNPczKrHCuAga3r?= =?us-ascii?Q?fPDQoWbG4GMnnCPoBhbsMKyUcWc8VkLTtkyzxn+Y6viaSb5NB24w2xE+RnE7?= =?us-ascii?Q?mvEPDXWDQ7SU/OopAWAYJFJZYa3hy3hoP6w4gFeUjIsLT2q0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4f7af7c-9233-4839-6599-08deec2baa99 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2026 22:09:02.4401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b8045JzfkCCnh6OkMp53NAGKNVJcuk20XsjD7ctv1jyJMe65Rinu9F9qmyJP+JFise10dNsi85bPh6B5CE0Qtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB9546 On Wed, Jul 22, 2026 at 12:59:13PM -0700, Borislav Petkov wrote: > On Thu, Jul 09, 2026 at 03:55:43PM +0800, Lin Wang wrote: > > Hygon Family 0x18 systems expose Data Fabric (DF) devices in a layout > > that cannot be handled by the AMD fixed-slot node model. > > A bunch of issues Sashiko caught which need addressing: > > https://sashiko.dev/#/patchset/20260709075549.626095-1-wanglin%40open-hieco.net > > @Yazen, there are some preexisting ones in the SMN code that would need > addressing/commenting too. > There are a couple of preexisting issues. 1) Use-After-Free This looks like a long-time gap that doesn't happen in practice. The "devices" are the internal root ports. They don't get added/removed, since they're built into the chip. And the amd_node code is built-in too. In any case, I'll work on a patch for this. 2) Divide-by-Zero This one has come up a few times recently. Latest two threads: https://lore.kernel.org/20260506055528.476493-1-penny.zheng@amd.com/ https://lore.kernel.org/20260623211904.3674-1-jason.andryuk@amd.com/ Thanks, Yazen