From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F23C3B2FF2 for ; Tue, 28 Jul 2026 17:45:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785260736; cv=none; b=LWEQT0Cmwd0e58xGm1qTqjCYozz6naNmO6OESLXcCi9c6Q8OZE3tiN744RLqVsmRVn+YCmHCkKULsSN2WQQUQ0TBzpopjP88c72jMXjxe3EYYKzeYuIzoDbGJq7gys6xFCVEeFkrI0DbGvTI3N1fXvXe/r1Dpj3RySy0zhRbi1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785260736; c=relaxed/simple; bh=gStEzvgs7NjI1ffvpOOKeWsN7W5iJqPLd8nE6UkcCAU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jhILpyrb+GsJQsX/9hjryVY5VcqD6wo+qvw8NIl2BYMz7GLnHnyJWlqTiWtFKt7st1iXss1BALRvY20MvzK5enfu/0H6HHoVm2kQTsEBD7U3HENiy6iTv0uTkvL8AVVPvSgdT8x5UkRSeUEPkLwd//HUFLnKe6HY8BNdZyXka94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Yjr+DPBl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FnQpqIis; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Yjr+DPBl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FnQpqIis" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66SHbgd73883679 for ; Tue, 28 Jul 2026 17:45:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1gjUqTR9xujL56+1zqXoD7uw6MiEVy7r/K7rNUJtK7I=; b=Yjr+DPBltEEFJbC1 wHF7mS2LSw23CjS4bgXLm3+AdaaSq75u+CbOh2lqjFrjqyXNJRKIKY70N6e1P2ud RaKc+ZGvQsgO8DmuX2E5LXf8YBzqNf+8mvo9uFfm4qCSTgG5CnX6O5xWRBq5yQUW H+dxawAsVuQDv7TCSfluQhk3dOEyF0RwOsZrQTpurzlyqH1LR3wqL7Ha0MjcEJ4B +U86Eu37RXHj++c9wyI2IjGn7kWdKC8Z+CFItCGuo84RkAGVZ8kwq8mZwO11U13e o2C0YF0RKWPegEG2PZaKHJjg6BcWnvUFAUepiHYd5lBhulv+t4vI7tnhTRXjrBzM 8pFA0Q== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fq108r13f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Jul 2026 17:45:34 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb5cc1e139bso1616a12.3 for ; Tue, 28 Jul 2026 10:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785260734; x=1785865534; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1gjUqTR9xujL56+1zqXoD7uw6MiEVy7r/K7rNUJtK7I=; b=FnQpqIisZZxdfHlN9AmlYzIQRgQBWuBQms+2++7r7cW0QCJrRZFyS7Y0xeiRBuPl1+ nWfMn1ih7JbUnI+tUpdlS5uP796qbNKKwL8GYOwqi17AC2GT9tZDgMpy7EpAjbMaG5Rr oMTTnvpzPtW+dLZ0oY/t1GG131qe6ngNGZrME8HiGpfFr3t0wzIUxYKljQhJ6EDBBNmA riA2u542YaMqOqPD/GbX+f1BjT0qeKMuQETStH5GpDbQFTw34j8H6h6uHBwilMyBKWmM lTKMVBDLn2JVSsuB6rR9Bhzi8yuNeXF6yhodAzMNdfzJjghi+3kepKSuMNV8/A4vcauC kLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785260734; x=1785865534; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1gjUqTR9xujL56+1zqXoD7uw6MiEVy7r/K7rNUJtK7I=; b=OvYxUKq3KEt0DCFWdzCuNk5g0/J7j7nHxdPyMSSghhpsQfa4k6U2E8Nsk6Ce0SThhH tPt2Nz1dvxwOArmBzVoNtRMQTi2TdPPmoAMKeUHJbE0CayCoLPXnBNpiVWNx1/gJwRIK ZZPeBxM0BM0nWWUMihOLTQW7WI3jxli9m5sBX9L/CledBDacOs1BKuY1uVNca7FrZp84 CRImvEMA3L0XZ+lz713kUxJOUaDQ7lMmBwLFDz4YwOBNnzZFYWuroT4S6hIzfNPzcRsG +BDIQp13x+vnxcnAi8M3UcpaA3v2VXmQROSsxSsR9M2dBi0bQhcLbs1rlFJY6OQUT6wY 1jsA== X-Forwarded-Encrypted: i=1; AHgh+RrFZ4OoSvbZmScHtyA94Wm8r47zkSAGliJS8zLZEo1hgBGCf7KlO3U0ao20PrraKbXWq3uQGa6abZG7J1o=@vger.kernel.org X-Gm-Message-State: AOJu0YxT6A2LWPn6hQz9AUzn13jMkVyFtHDqQ+yhoYWATUdrlOrl/xI7 ZGcdExTXhUlkDzKBIToLiN6Ezobxdugo/n1EXNYvH4PtInSTzZ6yE4q7aF1Cv9/qET1aGnF43e/ EteV6R0TX4VcthRt4BuN6SPTuuoYCKEZ7wM5PUqqfXVmfvBOPdGM5eP3P0CDG57lrV3U= X-Gm-Gg: AR+sD12y1sWiPDIjOR/eqma295hJYXwK2Gtm6iOKyjcqksVAS56zGtK9iWQzYzx1BMG T05ooB57l2cdjXrcedoIk61Sr7dLCAmI3hXhSt4HcdZ/ozC86fWmB6wI+8YuAGpOnThzINXnG/H G4HssgKD74SYrNSLlpst7TGlYUts4tn/eZENrrzthntIfE53UfsVFbF2s8p+Hf91OBQJguC6GmX ZoxMMFOgNhhJitOJ253OS/TEuI/y6VqwaPCtBmJPYRbyNe6gNpMwWxT2dc9zmslvFMwR7lCplRv qBRG1/2W94adVefzlxRSQqzi9OaFYIdep4QndFT3tI/vpWYdWT0nonUx0z2jNoRouEbd8dl8ASu upUn4tZxTW4efmoQpwAMORLKPR09dTjbc+un61TfW2FEeoyMJWxCYA5IKYfRRQ+XFzia2JQ8PP3 EyD7BuElkmb0eZ X-Received: by 2002:a17:90b:268d:b0:38e:85fb:71b9 with SMTP id 98e67ed59e1d1-38f6a311026mr4103316a91.4.1785260734193; Tue, 28 Jul 2026 10:45:34 -0700 (PDT) X-Received: by 2002:a17:90b:268d:b0:38e:85fb:71b9 with SMTP id 98e67ed59e1d1-38f6a311026mr4103283a91.4.1785260733774; Tue, 28 Jul 2026 10:45:33 -0700 (PDT) Received: from hu-ajainp-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e7273cd9esm749553c88.13.2026.07.28.10.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 10:45:33 -0700 (PDT) From: Anvesh Jain P Date: Tue, 28 Jul 2026 23:14:33 +0530 Subject: [PATCH 5/8] platform: arm64: qcom-hamoa-ec: Verify required I2C adapter functionality Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260728-ec_add_more_commands-v1-5-771abd65ee1a@oss.qualcomm.com> References: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> In-Reply-To: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> To: Anvesh Jain P , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785260700; l=998; i=anvesh.p@oss.qualcomm.com; s=20260313; h=from:subject:message-id; bh=gStEzvgs7NjI1ffvpOOKeWsN7W5iJqPLd8nE6UkcCAU=; b=4hRPZy16gtfLknzVZFnG3R0ewTlG4RYVkBHY4haPX+cv9BGYOjLpsuon29h/psfLt2/Cxy1GE sOLgGg9vkzHAvmQIQZ7PuNDLql4V0BlVlYREqPm3Fsf7ZpFGTnBSXMv X-Developer-Key: i=anvesh.p@oss.qualcomm.com; a=ed25519; pk=8o9EG7gkPe2Er9y9UVCx8MTdcFCwU8Pa54hBZPuduXE= X-Proofpoint-ORIG-GUID: iX4yu8cL5PsH0aHS-Zn_HOICUJCTlXbR X-Authority-Analysis: v=2.4 cv=fufsol4f c=1 sm=1 tr=0 ts=6a68eabe cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=CFGf0PpD_GUA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=rzEn2H2MjajWylKlqLQA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: iX4yu8cL5PsH0aHS-Zn_HOICUJCTlXbR X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI4MDE1NiBTYWx0ZWRfX/dOWotNPsFNZ ZhDh7KAuP/LnArsMPADloZZhEezcOM5q9P/rtk1ZxBeoB6cy7BYaaVoKHUa5YgFuhn4qYjbNCFs 8WQBiQ9DAJUY5Fs18yMyoFFThnuopdw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI4MDE1NiBTYWx0ZWRfXwndfl7MWA2/q 0+43TShoG6q51ZNJyxT6tDTdnCpwA7Jknibt1M706OqKDFsU52JHQ5UkbPc3Ioo+UT7OVQ1tSxC xJTR4Zkjra60XBlL4aT4qMe+oRXkw+/Qycc5QWa+q1oDgpPWMXAUmLbfxJ1vxk2Em5cOJXmz6pd qt47OWppq+h/Y3v2X28kXU+AeG7FQ5lKy1Ve2U2Gp+kiw1FjwyICKKEfmZRkDHLUuimns63IRjZ 2N5p6RPEno+CBhV7eY8lfBUAcGrYBXNHOjD9+PyDZAjWexlmTnTQjJKMOsYrHxdMeW6T+uzh1O0 XpHRNkK8NVNOsrk6PP0EvRyrJO+9ITyG2of14ncU3OoyDWx/c52pltndbJ3YQxS/ivztR6W7Xzc 4XtqSSpBhMOT5Nzx7Uw0SK/N4pBH7txGU1pru8cZ64GB7TDJUxjAYpMTjF/8m21n9Zbj8sGXRr6 hPvWHRKnK/zD5pQhGiQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-28_04,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607280156 Check the underlying I2C adapter supports both the raw I2C transfers used by the fan RPM/LUT commands and the SMBus byte and block-write transfers used by the other EC commands, and fail probe early with a clear error if it doesn't. Signed-off-by: Anvesh Jain P --- drivers/platform/arm64/qcom-hamoa-ec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/platform/arm64/qcom-hamoa-ec.c b/drivers/platform/arm64/qcom-hamoa-ec.c index d0c45d9970ee..a420a180a194 100644 --- a/drivers/platform/arm64/qcom-hamoa-ec.c +++ b/drivers/platform/arm64/qcom-hamoa-ec.c @@ -1195,6 +1195,11 @@ static int qcom_ec_probe(struct i2c_client *client) unsigned int i; int ret; + if (!i2c_check_functionality(client->adapter, + I2C_FUNC_I2C | I2C_FUNC_SMBUS_BYTE_DATA | + I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) + return -EOPNOTSUPP; + ec = devm_kzalloc(dev, sizeof(*ec), GFP_KERNEL); if (!ec) return -ENOMEM; -- 2.34.1