From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E15181A6814 for ; Tue, 28 Jul 2026 00:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785197777; cv=none; b=L+zWiwuDBmiX6XdHJQVlKqlwBPFRgEAPny38O6QIrnjvyjaqkA+ubVoku8d0qQZMAAMv2MIeQyfN1r4ZX0O8TdqUe/IPCsGevKOEnMHc3TbMPMKgwABgzK2UCDFWDaFsyFOJpE35RgZ5aprXcgzbo+/q1XC7yByzAqPVFe+vdEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785197777; c=relaxed/simple; bh=9yo7oQrKPLRlMrthYw+pO7x0jHae0Vj5AYr8R8OfkZg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rrYnLWVP9jIvTu7pVvdajSvbYmjFw4qcmvnSL3KxAWThXtDKmhXzf0+68MgFosz3YjvEd39Qx8OxfY4HdYUs0m67mjMl26md82ZqurtTK0cIOSDXzuQzCciDoiyMCgT0e7KaC+CRhmnA2ULUmQb/k79KFHY3h6KlKl1cmOJYiPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e7Sydo/q; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e7Sydo/q" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cfd2e4e83cso6789215ad.2 for ; Mon, 27 Jul 2026 17:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785197774; x=1785802574; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Rf2C74uNnPKCuHC6/DlLKvpy+zpKmy0yi6JZQYXqMV4=; b=e7Sydo/qOo+P6VnfB1xAmMio3wKs017k9PDoKqA1FtvexwoeDrlbYy3iqTmELHcwzZ 7QCRCOAvWjJsykwYos7X6d3mvx9Skb3pUJvUBMGojgnX+JyRNZeTHa6JaXiUS9x+9L3y gcIsioQ0oTqCrMBwHhiI1xQExDsqWzPWNZQF7WRticuf7C4M3XAFp2X3HLgqo337FR9K OhmbejQfNDdu78AKzfAuJMDS4itkzlX+uZKDOq4XuRqwhapRr/7Xb+6fnrEt32YCTojo 47Df/xfyOd40HFJsK6jGlh2lHu5m/qgd/1PTbG9gyK2/R0YoghSHr1OqMv++Y/9Xnr/b 6SvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785197774; x=1785802574; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Rf2C74uNnPKCuHC6/DlLKvpy+zpKmy0yi6JZQYXqMV4=; b=bapWBr9RyoPMpG4RcuUEiQJ5ASN0JuqeXK4nqXIDFu+HF+hSf7yNJ+T/gRprBcyiWM Ir5MBMz3TYpzQrdaG79KooztDGFfZuMJvvDMpOgJSdVb+vbX8yns6mDr4WgLyYldQ3EZ k8tGXmUApHteVfFTTA2/ivElcU9fJbk3cMGWi1OiBXOkjU+e5MQ3QCesVFUbetcgp7iL /gu/9Ds3F7rT7iL6kI1O8kGkvrB5GuxGcPM9V372GO74oMCRSWfZYXcW84PtUXWzqhKj gn4b0k2Lv+AQK31kGqdVUK+YSwT4iuVlA6DagV/zVdlnxp2JOgsypF9x+mR+T7Vvuy/l 2paQ== X-Forwarded-Encrypted: i=1; AHgh+RqHrF5EbiX5kzSMFS459ZyryjKEV/4bqLqaQJMtg4mu/bxAOnBJi0nsznUs9aOFF2BF92aKyI4sfn7rcOU=@vger.kernel.org X-Gm-Message-State: AOJu0YxUHVF1jxrdvwh72iP5Y42G7yNtcIx1HJfRMo+CZeBc6g4oVm5P IILLMdmkQz+tHHcE3+iHGqgLRZvQ5/G70iAnWbBnn7fJ1XjL8bKRYVecfO53kx6BavI= X-Gm-Gg: AR+sD12hVDEXIyEvsP9km+AdOdNK5/2Sbqnaz0rKkVeDsyJs5osNffpbWap/CtDFRFM ew+g0IgXQ8RgKuUcLMCF6EU2zn5fWt61ZfU4bB537zE+F2QIqVtZNGg/ZEHkd4oeFnjAINTr/+O Ptf+IEMTvaiulSRFGp0Ig3cVjpBbM2gu1Xop7yp/wMgT89YOJJzFsCqa+Sl5oLOwIvsO8b9kMq4 EXVji0Tdlm8jB8f7/9AJndVbCKsCY4B4raImBJYpCykmqg1kvSX7vNBLmbv3wTByAKsDsQqRg/C QuzP+ObTyEZP+jWBBwCJYAFF7COTp9Z5EPH72OkAs7MpR+S8FrMtP2JNg6syydUVLqeHjr/Zti+ /pXNv9YefU05OQu/lxTp6bsOJ4y/v2453xasaYYT3wfgLXJZmRJSB40rZvEoXwH1bX3JHyZnJVK 8jFgOac6cUXbkDhFez8jAv0Zim2ImFPQkdRRQ= X-Received: by 2002:a17:903:4587:b0:2ca:ecf6:9105 with SMTP id d9443c01a7336-2d015aded11mr952495ad.1.1785197774210; Mon, 27 Jul 2026 17:16:14 -0700 (PDT) Received: from FAIZEL-KB.. ([2001:569:5b64:e100:37da:2f8a:5b33:6b68]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2cfde5e2a78sm43408555ad.26.2026.07.27.17.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 17:16:13 -0700 (PDT) From: Faizel K B To: Shuah Khan Cc: Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Ricardo Ribalda , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Faizel K B , kernel test robot Subject: [PATCH] media: vimc: sensor: fix pixel_rate type to resolve do_div() warning Date: Mon, 27 Jul 2026 17:15:45 -0700 Message-ID: <20260728001545.331638-1-faizel.kb@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vsensor->pixel_rate->val is a plain s32 field. Declaring the local "pixel_rate" variable as u64 misrepresented its actual range and made do_div()'s divisor look wider than the 32-bit division it actually performs, which is exactly what the do_div() coccinelle check warns. Revert pixel_rate back to its original s32 type to match vsensor->pixel_rate->val, resolving the warning correctly. Fixes: ec1e620b2454 ("media: vimc: sensor: Add pixel_rate,vblank and hblank configuration") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202604191731.10nxGZ92-lkp@intel.com/ Link: https://lore.kernel.org/lkml/CANiDSCs9s03DUjKwcPgDtZt2QJ4i0FGwab4zpEP+wCawagSC2Q@mail.gmail.com/ Signed-off-by: Faizel K B --- drivers/media/test-drivers/vimc/vimc-sensor.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c index 83dcc9d61ee0..7cb544fdfddb 100644 --- a/drivers/media/test-drivers/vimc/vimc-sensor.c +++ b/drivers/media/test-drivers/vimc/vimc-sensor.c @@ -97,18 +97,14 @@ static void vimc_sensor_update_frame_timing(struct v4l2_subdev *sd, { struct vimc_sensor_device *vsensor = container_of(sd, struct vimc_sensor_device, sd); - u64 pixel_rate = vsensor->pixel_rate->val; + u32 pixel_rate = vsensor->pixel_rate->val; u32 hts = width + vsensor->hblank->val; u32 vts = height + vsensor->vblank->val; u64 total_pixels = (u64)hts * vts; u64 frame_interval_ns; - /* Sanity check, pixel rate is fixed and fits in 32 bits. */ - if (WARN_ON(pixel_rate >= 0x100000000)) - return; - frame_interval_ns = total_pixels * NSEC_PER_SEC; - do_div(frame_interval_ns, (u32)pixel_rate); + do_div(frame_interval_ns, pixel_rate); vsensor->hw.fps_jiffies = nsecs_to_jiffies(frame_interval_ns); if (vsensor->hw.fps_jiffies == 0) vsensor->hw.fps_jiffies = 1; base-commit: a52e6f7923c17a672135b485ffd96fbd72f46267 -- 2.43.0