From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2D151990A7 for ; Tue, 28 Jul 2026 00:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785200174; cv=none; b=aQU3zQruHKG/fCEGvR/bNekComqpooYd3jpHWDTq6x0kOr+0ZGe4lfx9sizhKtQfrbGqXksZo5lVZY2Dc822ExfgrZ2K0eC4kugbtjS3YWs4/kRcADeclE3QgyDFBnu4zMK3Uw0EqFE1EGfDvEO7fAm+dHAhIwWyAq/HCUkgfhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785200174; c=relaxed/simple; bh=rkQC3N9SWUGIPocS+zbd3VYqzWw5ikHPCirvXOvVCtU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MvxFFjjbVBfTmh9i+pZg5WBEx/rlqNhsrK0HP5SCoweQ5j0nyQiX5390A/EjqIiY3utFFbtAnl6iqFqYB4wHOLN6x+oibAp7guy+QWBDuSv/XCjDKhmruaXSmUMTUUi4IL/JZ6171LSI0VIlfIfdY0Y795rwqoSJdXH/SnDYda8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rVyso7Yv; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rVyso7Yv" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-84e584c7a5bso1616192b3a.2 for ; Mon, 27 Jul 2026 17:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785200172; x=1785804972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=n9aCltKzYK9V1VDRk179uRnNfROwdaBxdq5wyJYZ6KA=; b=rVyso7YvLBd6gvpmHuPu7RLJ+EC7FIR7Chr3MpBanGG13yihj5y0hBNcBkSbxznDxD bXs9DXbUiCrvU9ktD4d1mq+hS+ozXKaGTRn9O+ideW/CZp+kknC+V+Rf/Os9ehcUTHHP QNjBo8fyyzH/VVUz2XvqOLpSGpADnRCWd8Km8kemMSfE4z2LPB2WdMl1Lv7eV9CoUQ8Q vQ7NqYTd3IgCGbSDI0ulLG7fW1c3sLsukbOEKngvFL80SDI5galrnUWeHvPMP+P6gJXj dzch+m5Uze6fHlvc3oToEGc0sY7mvTkWEffQajHmqg1HJHTG66tQ2W3noPog+c2MyWH+ 1v7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785200172; x=1785804972; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n9aCltKzYK9V1VDRk179uRnNfROwdaBxdq5wyJYZ6KA=; b=i0r/DxoeEO53VyhvcspVo3aWzCCF+GA6ixOyCKAITFudeYioLZo5Emi5U7W1Nc5tHh 3CEp9jr2RcuYwcyBrWkBOvzZbN6hot1Ari21HdjriAs/EgGNmBW8xFyJofwRgXs3/pms 5ZfJ71d6lGiIA8jISxSgDxo0Vo4He8VB14YphE+J/G84jvdjPazQbJybgqioXIrWEmiD ILgKnjd7rZmbiyJT4RIzGb3L7CLxKGL8Jze5CypIc3zPToFMXGvI1tV7MD0FZsu5J3eU rf4kVQYZsy4Ox1WH6xrWH5HKfxLxiAnMw6zYzkN4usya8Ynk43jyUubFl+QPaxCxs1mF reHQ== X-Forwarded-Encrypted: i=1; AHgh+RrS1B0f4z7ERnwyvT5w/VOdnzxrGjntcOXQErQihuSW1Opb1JwG7FzQ3B/ghgiwlPHWGupmwCCvdQu/LvQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyeYRQ/O/LinTSmGgTFgw3DHJms0IDBzp4UKbc7x5HvopO63F98 ZcTNgBPmorUjAadm+ORHro5B45IWQIveVSB+XVBQFoOACEMdQ+omDaar X-Gm-Gg: AR+sD10UCWZ1wjbJCPaqYts6MYrFqgUN9rraftiPQUdDKyJPQ4nzS0dqINIpU+ezNcr Z4jgIBw6nkfgVRxuCww9CMH0Rt8BActLhKYLElIRR6r5ROyK4mRw9P0oVORaH3sv+9QQ4Fz9pDF JDjHiWK0uNLdjBFF5rSt8Dy1RSMV4ABFjhK3nq/3BzDJPrIV6VisiR/x+3MKQEWC4QC1xX6IEei +vLTRbo3Sj0YOP40INIIQ42aPrIEHJ42H39Vga2SWNwW9qz4LzAUIa2jlcJqzqj04p3PfVxV9sG miRxznIjEhTuEYvyjYBo+zfjvYIa1qzuT6avgQYcEkQzfYCX9za0Mtpg9ISwYGGFEfCA0PKquAW 7DqgooUZvfH4KcFgPvlbnFpzE9KyMcXewiwOBAQimuVb2REt0wXw3qRM6jivTMmAk0B29GYpvkk pZlmLiTs/y/QGAobzswKV3y7dQjcPJK/SyzNaJXCaoDjXLELs3h4QPv5yesBU3ZU8YEpQ/PyOHo FtVwRZY90SqRn77/Yxq3eqymJ+uwxlKtQ/4bv/WVfJ0D8eCVE/3ldk= X-Received: by 2002:a05:6a00:22c5:b0:84e:89a:b8ec with SMTP id d2e1a72fcca58-84e931ec68bmr181761b3a.11.1785200171996; Mon, 27 Jul 2026 17:56:11 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e533ce57asm3736218b3a.28.2026.07.27.17.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 17:56:11 -0700 (PDT) From: Rosen Penev To: linux-rtc@vger.kernel.org Cc: Alexandre Belloni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] rtc: msm6242: use devm_platform_ioremap_resource() Date: Mon, 27 Jul 2026 17:56:10 -0700 Message-ID: <20260728005610.575268-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the open-coded platform_get_resource() plus devm_ioremap() sequence with a single devm_platform_ioremap_resource() call, which folds the resource lookup and mapping into one step and returns an ERR_PTR on failure, checked with IS_ERR() and propagated via PTR_ERR(). The rtc-msm6242 platform device (arch/m68k/amiga/platform.c) provides a single IORESOURCE_MEM window (0x00dc0000-0x00dcffff). It shares that resource definition with rtc-rp5c01, but the two are registered under the mutually exclusive A2000_CLK and A3000_CLK hardware flags, so only one RTC device exists on a given machine. The region reservation now performed by devm_platform_ioremap_resource() therefore introduces no conflict. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/rtc/rtc-msm6242.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-msm6242.c b/drivers/rtc/rtc-msm6242.c index 80e364baac53..6f28d9c2278f 100644 --- a/drivers/rtc/rtc-msm6242.c +++ b/drivers/rtc/rtc-msm6242.c @@ -188,21 +188,20 @@ static const struct rtc_class_ops msm6242_rtc_ops = { static int __init msm6242_rtc_probe(struct platform_device *pdev) { - struct resource *res; struct msm6242_priv *priv; struct rtc_device *rtc; + void __iomem *regs; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; + regs = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(regs)) + return PTR_ERR(regs); priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; - priv->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); - if (!priv->regs) - return -ENOMEM; + priv->regs = regs; + platform_set_drvdata(pdev, priv); rtc = devm_rtc_device_register(&pdev->dev, "rtc-msm6242", -- 2.55.0