From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0553EE1D1 for ; Tue, 28 Jul 2026 07:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785225396; cv=none; b=OkUFAyWdDYN5LbkZz5K+JNXrKTPwgbP8VfdaVz1zu+iqH0PQJVAfV/Ge1r/QTso4qYLhXbQcqWzt1mS2riJmx4cnChXCxj1ZRhC01Gz10Iyondxnn8wVkOaCtBtxLJ59ELQqaZokxw5i+gLe0Sc/LneAe6xZoapssHDjJjiJ5B0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785225396; c=relaxed/simple; bh=RfMZahzZP+QSUjftA3fik+FKYBcIoa8sYMqbW0xKvwM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mtoOTlDbyuAnct9ipH+3ORRnQzHD9E+K28ofxU4dnBsgaSlEC062JKJqE9y9nMIBBYwkM2PuELhkCeUjre4Wzayma5zwWbHPR8KUQH2sD0hbgEoQYnw5vd3MEgYV3T4cWXBk85WbeaKtTMwRfr5I+byirUtZT2A+xkUUs7edo3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Angpv7Nj; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Angpv7Nj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785225394; x=1816761394; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RfMZahzZP+QSUjftA3fik+FKYBcIoa8sYMqbW0xKvwM=; b=Angpv7NjNasKiyfpdhQ+aFNyvWhI6iDFrUvc7zZWcxCX/RznCHuyIMyZ cSjmd+XlK3Ccyl6Qg3gGV+IiBQQ0imKeDMf04ob8SCOjwGXub+T7DLIdC y3u7mxtCeJgEHbjVgA9y7lnsZifJme/VkwA32l+3wb+mTMOaDt5Bf65ad MqXHFv1okBBYIth0nkYx1YnGbVyWBFBCStDqQjSW/akzynqfqiI17rqSj 1NFAIhXwTroOADl8f0pn2eayAHxuEDLabn9HAALSpVmZQNJvD1CM8OWzc LSKduEa4I/4dNBS454HQ0NcjzE73nmFP2YLloUHlG3tQmQdNWLcsch+Qf A==; X-CSE-ConnectionGUID: 6zZVFxnKQtOxYdEaQAR5rg== X-CSE-MsgGUID: kMBbybGqQHC4+aHbwKfVog== X-IronPort-AV: E=McAfee;i="6800,10657,11858"; a="84780907" X-IronPort-AV: E=Sophos;i="6.25,190,1779174000"; d="scan'208";a="84780907" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2026 00:56:32 -0700 X-CSE-ConnectionGUID: WQPP+1N7R2mrlQ0WoKLm9A== X-CSE-MsgGUID: mUGzVesASCG1Zq/ZcmiaiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,190,1779174000"; d="scan'208";a="261611112" Received: from intel-proliant-dl380-gen9.iind.intel.com ([10.49.109.61]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2026 00:56:30 -0700 From: amarjeet@intel.com To: Len Brown Cc: Kaushlendra Kumar , Malaya Kumar Rout , linux-kernel@vger.kernel.org, Amarjeet Subject: [PATCH] tools/power/x86: Fix write_sysfs() return type Date: Tue, 28 Jul 2026 13:24:22 +0530 Message-Id: <20260728075422.10977-1-amarjeet@intel.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Amarjeet write_sysfs() returns an unsigned int even though it returns -1 when write() fails. This converts the error to UINT_MAX and can cause callers that treat a nonzero return value as success to miss the failure. Use ssize_t to match write(), update the receiving variable accordingly, and explicitly require a positive result in sysfs_write_string(). Signed-off-by: Amarjeet --- .../x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index 0dc959e30076..6db7620e7b00 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -867,7 +867,7 @@ static unsigned int read_sysfs(const char *path, char *buf, size_t buflen) return (unsigned int)numread; } -static unsigned int write_sysfs(const char *path, char *buf, size_t buflen) +static ssize_t write_sysfs(const char *path, char *buf, size_t buflen) { ssize_t numwritten; int fd; @@ -886,7 +886,7 @@ static unsigned int write_sysfs(const char *path, char *buf, size_t buflen) close(fd); - return (unsigned int)numwritten; + return numwritten; } static int sysfs_read_string(const char *path, char *buf, size_t buflen) @@ -911,7 +911,7 @@ static int sysfs_write_string(const char *path, const char *buf) len = snprintf(tmp, sizeof(tmp), "%s\n", buf); if (len < 0 || len >= (int)sizeof(tmp)) return -1; - return write_sysfs(path, tmp, (size_t)len + 1) ? 0 : -1; + return write_sysfs(path, tmp, (size_t)len + 1) > 0 ? 0 : -1; } void print_hwp_cap(int cpu, struct msr_hwp_cap *cap, char *str) @@ -1016,7 +1016,7 @@ static int set_epb_sysfs(int cpu, int val) char path[SYSFS_PATH_MAX]; char linebuf[3]; char *endp; - int ret; + ssize_t ret; if (!has_epb) return -1; -- 2.34.1