From: Grzegorz Nitka <grzegorz.nitka@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
richardcochran@gmail.com, andrew+netdev@lunn.ch,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
arkadiusz.kubalewski@intel.com, pabeni@redhat.com,
kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
Grzegorz Nitka <grzegorz.nitka@intel.com>
Subject: [PATCH iwl-next 0/3] ice: expose TSPLL state on E825 through dpll subsystem
Date: Tue, 28 Jul 2026 11:13:11 +0200 [thread overview]
Message-ID: <20260728091314.1420656-1-grzegorz.nitka@intel.com> (raw)
On E825 devices that own the source timer, the TSPLL can lose lock when
the TCXO or TIME_REF signal is disrupted. This series adds monitoring
and recovery for that condition, then surfaces the lock status and clock
source selection through the dpll subsystem. It also fixes the clock_id
generation for E825 generic DPLL devices so userspace can unambiguously
map each DPLL device to its owning interface.
Patch 1 adds TSPLL lock monitoring to ice_ptp_periodic_work(). Placing it
there ensures recovery runs regardless of whether DPLL init succeeded or
CONFIG_DPLL is enabled. Lock state is cached in pf->ptp.tspll_locked via
WRITE_ONCE()/READ_ONCE() for consumption by the DPLL worker.
Patch 2 registers the TSPLL as a DPLL_TYPE_GENERIC device for E825 owner
PFs, with a fwnode-backed "time_ref" input pin. The pin state_on_dpll_set
callback switches the clock source between TIME_REF and TCXO. Lock status
is read from pf->ptp.tspll_locked; UNLOCKED is reported unconditionally
when the clock source is TCXO to reflect the free-running oscillator state.
Patch 3 changes the clock_id generation for E825 TX-CLK and TSPLL DPLLs.
Previously they used the board-level PCIe DSN, which is identical for
all interfaces sharing the same NAC/quad, so userspace could not tell
them apart. The new scheme derives the clock_id from the permanent port
MAC (with a dedicated tag bit distinguishing TSPLL from TX-CLK), while
other DPLL objects (EEC/PPS and non-E825 paths) keep the board-level
DSN-derived clock_id.
Grzegorz Nitka (3):
ice: monitor TSPLL lock from PTP periodic worker
ice: add TSPLL DPLL device and TIME_REF pin for E825
ice: use per-interface clock_id for E825 generic DPLLs
drivers/net/ethernet/intel/ice/ice_dpll.c | 479 +++++++++++++++++++--
drivers/net/ethernet/intel/ice/ice_dpll.h | 4 +
drivers/net/ethernet/intel/ice/ice_ptp.c | 80 ++++
drivers/net/ethernet/intel/ice/ice_ptp.h | 11 +
drivers/net/ethernet/intel/ice/ice_tspll.c | 122 +++++-
drivers/net/ethernet/intel/ice/ice_tspll.h | 6 +
6 files changed, 657 insertions(+), 45 deletions(-)
base-commit: d621cef13189b54ee67019d170a6d8ec727785aa
--
2.39.3
next reply other threads:[~2026-07-28 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 9:13 Grzegorz Nitka [this message]
2026-07-28 9:13 ` [PATCH iwl-next 1/3] ice: monitor TSPLL lock from PTP periodic worker Grzegorz Nitka
2026-07-28 9:13 ` [PATCH iwl-next 2/3] ice: add TSPLL DPLL device and TIME_REF pin for E825 Grzegorz Nitka
2026-07-30 8:42 ` Nitka, Grzegorz
2026-07-28 9:13 ` [PATCH iwl-next 3/3] ice: use per-interface clock_id for E825 generic DPLLs Grzegorz Nitka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728091314.1420656-1-grzegorz.nitka@intel.com \
--to=grzegorz.nitka@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®