From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12C7737A82F for ; Tue, 28 Jul 2026 10:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785232821; cv=none; b=UkTQISCZa8ld2L5wLMrsFOxqdkpwr/mC1gymNnKs43E7iR5zcYdFV7Dsp6/TCycq92p+XudmuU/4HvXHM18TInRKNPj+myn8QPB/fkW+GdGITjhoMr/wLi+xCkhseoTTqhmBXCg0hynMCbl+aUV2AMgPUHqUIfHr3jz9cXEAB4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785232821; c=relaxed/simple; bh=fo1Hg4A40prtXvbTJpQwIbWm9AuPnauij3dGDjEgjFI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=seXtCyDemQyPGbxVdjMpAjNfe61H9vKoYgP6MX8+fs8bWBDKxO62i4ux3q1XvsAgFqA0ny4qw2Pie7AW1t2MrvQtW7zFuOuaNZKBwAq4Rc8J8eeYrSnZCph9BU+osxhtbieCllIg6c0VsNdMI4LTngiIfBCjhmnvdp0cAmvBsjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZJiJY7x3; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZJiJY7x3" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-84a2dcede83so4946309b3a.3 for ; Tue, 28 Jul 2026 03:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785232819; x=1785837619; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NNVbJiZIg9bWYtKjgcIObr2+FVZvVS9YUs+1Yr6aAjI=; b=ZJiJY7x3w4pQfdoo24DMKdhH7Jrp7sPCOdZCZwvzl79rq2TcjDacl/zRVS8lfj1jti 4v85xratxWtYbJ4DjogEub2cFRsCAZ7QSf+wODesRP+NmKtFYD+FGe3AGHbQfQ3R9x+t xbBeVkv13bFp6Bzk+pNiRFMeeTj7YS8p1jsxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785232819; x=1785837619; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NNVbJiZIg9bWYtKjgcIObr2+FVZvVS9YUs+1Yr6aAjI=; b=D1QyZU7HxheHHleER/HsrGmGLC3OTvlaML5vJHoEWIN4LuV/NPNBDPbSa7EGxHaffd Qq0LKd2EYLoeQpLN4SDNcAhspcjPhY8webAqk0o43aKxT4glUwHOoXih1kNJqRhwEaAL g5SZPiZ+212qHVGqB+AmAaoqj2rgyCetNeiy7Cyc4qaBfqIPvymx5CcbOFgS9iZ1s2dW RtbKcdmAwkJcmqogNU1Kz4qNprEHYk4V4Lo4Wd5cI8kfrgsJLKojUcn29/kRctAFqkX5 9kKwz2S9VeTUlcBwU3SsVIq1IQgjk4rYfHDtgvpwgOxZiekGtSMWhXBuIgjym4DtUiV4 axrg== X-Forwarded-Encrypted: i=1; AHgh+RpBd39VY2wLGatq/Z+LfJfLWt4e1Z1CZiXexCckUrGuwVDMDXZZYZGsTqo/Zxun0+SlSps8CO15kWR8brk=@vger.kernel.org X-Gm-Message-State: AOJu0YwAcr8g02Z4QdmNaVp4aLq0zZvHHj9MV4CpBnfFaqyMSIKr3E57 MZhfsUg1noNKPOIZbK6cqo5I97w4VjoOJO64ziD4P0nFwctCfkGrACAIDGKiVqmI3A== X-Gm-Gg: AR+sD11NmVi8dn9l4Od0dtgcaGI6D1Mwuo4PG8Bezqlj4QgbM7mXWRk7Bw4aei8uS5g HsBK9JCEsZaKJ7yzKqADqLwTQ+5zLhJezDOWp1cj3ByukLlk6WJWqbcItUDXF7PfwCa3/KjqFRl 8034w5SnBYexcMTdZlhkw4bxvcrVCRpofrffSaJ2OQPb/hYJfNSssUSj22f+f3sU7Y1p1HkEfGF aYzK78lA8tIdJ9m1M8ZWVowGVTeh2uHRY8iBaPzzsqAGc3U9/UcPj1zwTtIB0Py1r8j4tSAR45M dTGXYnnjwpcif2YYky5HCmZQCU0w8gisQvHEPOZLa207OMjAQ4hYZFMnPHsE1zsdEpwWYd/WXSy eCBvkKGVTDM3bQeLtsXcjBJZbpGE26IE1xeBCdayi/CdAS4ZLnCdf1mLiYifIYaet9nBbaY3Y/n 9dmwvQEWZhQm4GThdf1fCYTvnYqUaEzlD6TL7YJxYR5QT/7C/I8QNDhBRVJAE= X-Received: by 2002:a05:6a00:f88:b0:82f:50cd:e586 with SMTP id d2e1a72fcca58-84e931b4ea6mr1734667b3a.13.1785232819283; Tue, 28 Jul 2026 03:00:19 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:c85f:b2bb:a077:d544]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e530079f1sm4113113b3a.0.2026.07.28.03.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 03:00:18 -0700 (PDT) From: Chen-Yu Tsai To: Greg Kroah-Hartman Cc: Chen-Yu Tsai , Bartosz Golaszewski , Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: hub: Set proper message when usb_hub_create_port_device() fails Date: Tue, 28 Jul 2026 18:00:04 +0800 Message-ID: <20260728100005.413868-1-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Right now when usb_hub_create_port_device() fails, it prints a separate error message to say which port failed, but otherwise leaves 'message' set to the default "out of memory", which is somewhat misleading. Allocate some memory and put the currently separate error message in it, and use it as the error message. If the allocation fails, use a generic version of the error message. The allocation uses devres helpers, and will be freed after the message is printed and the device is cleaned up. Signed-off-by: Chen-Yu Tsai --- drivers/usb/core/hub.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index b09b43669658..fc4879d9c623 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1751,8 +1751,15 @@ static int hub_configure(struct usb_hub *hub, for (i = 0; i < maxchild; i++) { ret = usb_hub_create_port_device(hub, i + 1); if (ret < 0) { - dev_err(hub->intfdev, - "couldn't create port%d device.\n", i + 1); + char *msg; + + msg = devm_kasprintf(hub->intfdev, GFP_KERNEL, + "couldn't create port%d device", + i + 1); + if (msg) + message = msg; + else + message = "couldn't create port device"; break; } } -- 2.55.0.229.g6434b31f56-goog