From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E623B6346 for ; Tue, 28 Jul 2026 12:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785242208; cv=none; b=ue1ScHv1QQKfPPVechdizznkCMcDcJWq6JvvPeRXCG6/GtBsh52qSZBS2/pU4bXkw2pAoKCoSFp7OV2Wp+og0vYceyf5JYwjCNJEB+hJlpPdbVKMWU9/ox/R7EST3bO91EY8U+W2W3VuRR7GE1IotZWCZYP/rYwNkwpuSIHQwtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785242208; c=relaxed/simple; bh=E2tVbOuiL3zZIsrPmoBv2m3MRk4qa7mEJqzNwfTQ4cc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XjmNJTW+XrjchI41kDI8jRYsgTONxBGMTVResAnLVTHNgP3lgGHBWftKRRNX1JQkMj7tXqvt1kDinetW7LrfyXqf8yowo9kxc9FQRZGHEOUAuDrwIco0H63VL08UwLQsgFY0ddoImMZhIMSAAH1JMDHg4mjYZyyWwxu/3ReBk/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DOzSWkDd; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DOzSWkDd" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47f703a9d05so2541101f8f.0 for ; Tue, 28 Jul 2026 05:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785242203; x=1785847003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dx6GWFCsmDgAOCrs6zu5XboEn4YjvCkE11wpK+q8SAw=; b=DOzSWkDd+x3Y/AJrRjWOaE+m2fqtAvs7ypmAH5HoyjLe6AIia2+jnE0eYAIuyiZVpf cxAV9jw0wbGM6qwZ56wRdR7wBc6ETxzCoAex8dMqgYqooxONEDhJLBHMtEo4tA/ZWAfq izGA+e3s1WTCyPdYO6ppqxtW3Z10DuxbEvkXTXgoS6YphrYyhHERMiUi1k9WPVBYw1AX UtAq9LaDC5cZ3qf4RN4MssWGBXN7B/slp864/cRZRZJZxNA5shIVL4V23oqbOD6UCRyq t/wnwlaFW0cxiZQ8ZNk2w/KvtvgNnHuuoJEQVApflAhxai6IJzwyB7ydErbh5jbGZZt9 EU8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785242203; x=1785847003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dx6GWFCsmDgAOCrs6zu5XboEn4YjvCkE11wpK+q8SAw=; b=MrlqOW2FhLQaRkr0ZFvc9wEpv73W7GlLfJ1Afgk682UQPQJJ+FuXI/at5ArzxeJMMF vIUM7n/4MuV5ow3hnLQq0TBzGivyAWBHBhsojRJKH7b3/tm9P6M6Arkc02N26uCl6KDE 0ipdei8IPQUEAseWqWNRCqPSOIR7lPGrTdDOrHfbMEXDqiiO321C0U4IJ9uQq/Aqh5B/ YiidUtmowF0ixljjPn9r8lZpAirqizGLTc/lqxUHttOmUtXo0oQFvS1BsBBvjFilp9kJ knexa90k07l6Ot0UBHEH15Jj4BkSEa1tn9k8o/GNjPj9TCrJgo+w74Oztm6YhWC4fpGJ YLrw== X-Forwarded-Encrypted: i=1; AHgh+RpYgsBuSTMNA3+WuP+dOuWmrgYGMuxP3eqKWtD16yX13zOht3YvtNounMH9pHFJQSVMUimegnILqVtnILQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5fPRUmiEYnsnQ96K7RByUsogRNw4OnFeH5Mw3+Sllvwih/ab7 iohtZRPEYNpA7a6cO33Z5IcO3ydnU5ca8XkOSG9pn+a9fyfkCZP7uc3v X-Gm-Gg: AR+sD10y1CTdwwtFdp9jQqWrtPM1G3yNRrtBMoT+m6+GgMLbn2FpIxDVLCOqoSjBRXl r8xfUSnOCQ9SC1yEZSavy2mA02rrmuU0G1j9TdkbIQl2oY/SIM9ajlp92ME7M3zw54R1nxa5TbC yCvYPrI2RnzLEsWjcXVi4QwcFx9A6kYhAlW0uVZEvA+c2I5ae+XugYbEE8A45Zb0O+BjJ82HSJn TKoyLGXLtF14p0loxOKPIwtQwRLq1mGqpImd1eMq42qRIXorNcjhMIMNwv3LOtIpOoTToY4cqQa cSpfmHRM6RaI/Y7AfCct1Gb0sBzF8YCrFmY9w5q45MAZJpWC/N2c8r3RxelFKfrvq2uw34NsTKO EHDgq1vMtMmILItQsSre4ObH2OAvQayV7iMt49UTXnYU4RZEuWmsKp61afUAnPXM136tn4Q1WKr BhORaRXGJ0WsOSWLHMv5AjzS79grZjbLpE3SHPmMAZpUtuGrE+1+2jzTiOC+bmmNl3Z7Sdjw+sy DJVQdEE X-Received: by 2002:a5d:64c6:0:b0:47f:9751:cb3d with SMTP id ffacd0b85a97d-47fb1e5d0eemr2530235f8f.8.1785242203081; Tue, 28 Jul 2026 05:36:43 -0700 (PDT) Received: from XPS-15-9560 (80-15-70-17.ftth.fr.orangecustomers.net. [80.15.70.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f96b9abc0sm37365418f8f.32.2026.07.28.05.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 05:36:42 -0700 (PDT) From: Olivier Tanoh To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Olivier Tanoh Subject: [PATCH v2 1/3] staging: rtl8723bs: rename mBratesOS to avoid CamelCase Date: Tue, 28 Jul 2026 14:36:31 +0200 Message-Id: <20260728123633.79735-2-olivier.tanoh19@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260728123633.79735-1-olivier.tanoh19@gmail.com> References: <2026072851-foil-womanly-4837@gregkh> <20260728123633.79735-1-olivier.tanoh19@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix checkpatch.pl warning regarding the use of CamelCase: CHECK: Avoid CamelCase: Rename it to basic_rates, which describes the content of the variable, rather than keeping the Hungarian notation prefixes. Signed-off-by: Olivier Tanoh --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 6 +++--- drivers/staging/rtl8723bs/hal/hal_com.c | 6 +++--- drivers/staging/rtl8723bs/include/hal_com.h | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 8b0502a1881b..627d778fb093 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -180,14 +180,14 @@ void set_mcs_rate_by_mask(u8 *mcs_set, u32 mask) mcs_set[3] &= mcs_rate_4r; } -void update_basic_rate_table(struct adapter *Adapter, u8 *mBratesOS) +void update_basic_rate_table(struct adapter *Adapter, u8 *basic_rates) { u8 i; u8 rate; /* 1M, 2M, 5.5M, 11M, 6M, 12M, 24M are mandatory. */ for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) { - rate = mBratesOS[i] & 0x7f; + rate = basic_rates[i] & 0x7f; switch (rate) { case IEEE80211_CCK_RATE_1MB: case IEEE80211_CCK_RATE_2MB: @@ -196,7 +196,7 @@ void update_basic_rate_table(struct adapter *Adapter, u8 *mBratesOS) case IEEE80211_OFDM_RATE_6MB: case IEEE80211_OFDM_RATE_12MB: case IEEE80211_OFDM_RATE_24MB: - mBratesOS[i] |= IEEE80211_BASIC_RATE_MASK; + basic_rates[i] |= IEEE80211_BASIC_RATE_MASK; break; } } diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c index 80a775437751..2f472afc5261 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -247,13 +247,13 @@ u8 HwRateToMRate(u8 rate) return ret_rate; } -void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg) +void HalSetBrateCfg(struct adapter *Adapter, u8 *basic_rates, u16 *pBrateCfg) { u8 i, is_brate, brate; for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) { - is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK; - brate = mBratesOS[i] & 0x7f; + is_brate = basic_rates[i] & IEEE80211_BASIC_RATE_MASK; + brate = basic_rates[i] & 0x7f; if (is_brate) { switch (brate) { diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/rtl8723bs/include/hal_com.h index 7bbf62cfd825..17bce0f88bac 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -112,7 +112,7 @@ u8 HwRateToMRate(u8 rate); void HalSetBrateCfg( struct adapter *Adapter, - u8 *mBratesOS, + u8 *basic_rates, u16 *pBrateCfg); bool diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h index 0c2bd51b6bc2..ed6c5001c68a 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -430,7 +430,7 @@ u8 networktype_to_raid_ex(struct adapter *adapter, struct sta_info *psta); void get_rate_set(struct adapter *padapter, unsigned char *pbssrate, int *bssrate_len); void set_mcs_rate_by_mask(u8 *mcs_set, u32 mask); -void update_basic_rate_table(struct adapter *padapter, u8 *mBratesOS); +void update_basic_rate_table(struct adapter *padapter, u8 *basic_rates); void update_basic_rate_table_soft_ap(u8 *bssrateset, u32 bssratelen); void Save_DM_Func_Flag(struct adapter *padapter); -- 2.34.1