mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zxyan Zhu <zxyan0222@gmail.com>
To: maxime.chevallier@bootlin.com
Cc: andrew+netdev@lunn.ch, rmk+kernel@armlinux.org.uk,
	alexandre.torgue@foss.st.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	hkallweit1@gmail.com, mcoquelin.stm32@gmail.com,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: phylink: add phylink_pcs_loopback() method for PCS loopback support
Date: Tue, 28 Jul 2026 21:22:27 +0800	[thread overview]
Message-ID: <20260728132227.4051026-1-zxyan0222@gmail.com> (raw)
In-Reply-To: <2c0c6864-99ea-48d6-a889-c886bb91c351@bootlin.com>

On Tue, Jul 28, 2026 at 10:41:12AM +0200, Maxime Chevallier wrote:
> I'm actually seriously wondering if we shouldn't just stick to MAC
> loopback only for stmmac selftests. [...]
> Using an external loopback (in PCS, in PHY, somewhere else...) doesn't
> bring anything to the table given what we are testing today, which is
> internal stmmac behaviour. The MAC loopback happens at the GMII level,
> so everything we are currently testing happens before that.

You're right. MAC loopback at the GMII level already covers everything
stmmac selftests actually test (DMA, filtering, VLAN, checksum offload,
etc.). PCS acts only as external transceivers beyond the MAC boundary
and do not bring additional test coverage.

Given that, I will drop this PCS loopback patch series.

Thanks for the explanation!

Zxyan

  parent reply	other threads:[~2026-07-28 13:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 12:07 Zxyan Zhu
2026-07-28  8:41 ` Maxime Chevallier
2026-07-28 13:02   ` Oleksij Rempel
2026-07-28 13:22   ` Zxyan Zhu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-07-24  8:52 [PATCH net-next] " Zxyan Zhu
2026-07-27  9:38 ` [PATCH net-next v2] " Zxyan Zhu
2026-07-27 19:46   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728132227.4051026-1-zxyan0222@gmail.com \
    --to=zxyan0222@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®