From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631EC43F8C6 for ; Tue, 28 Jul 2026 14:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785248243; cv=none; b=uSl7XpMQ3v7h96pXWfnF2KeAutLZaNHu0U5lug+5WqK+U9VXOcpn9QVmWpxosqdleRAeJ4owI0Nc9zJrMFc7dE12TFirZsFLV1aqqSXO+1CO3ex/N8lhzSJGAc2Zct/Rk+MUY8uq2fuLFgA6Rxx0ugcDEUdQXOEVDCnnPj+Mj2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785248243; c=relaxed/simple; bh=EdVkFbtpplFmnucffU6hGrzDkhgdlpdINMGBgZFsL0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l9F5ufKuFeBuf5t7TPrwA1LHNCfkjEX8iLfWS6wlRDMx1lIcnEskFa2Nckm49ZXEpCDUSQZxW2cUeBdOYUp0REfZPjYtcluKKeT+FjDv2X1tL7/YcX2WipT0uERajSkmAhRKXbBSNkf+6waRmXJQxcE2McsVPYalSPXZj1mfmCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VoryMx/O; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VoryMx/O" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-8eeadbc5e21so28364876d6.3 for ; Tue, 28 Jul 2026 07:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785248241; x=1785853041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UCAZLkoVBQcESsb1+bFs7MFWU1Mwcnz5Qa6bnHCVZ/w=; b=VoryMx/OalvbWiGg+8zHiBB4b6nsSJSbsByuZUbZK8yYCgaREHfnGziQBSxBzsJQSn bsZGVF7WrNLfMNYVMXbrod4Vw0/xmkkrHik69PojNH/AqDUqGCrjoBBVCrh61SUg6m6r MsuQPW77zcYMfNKLO3ytSM6ZgWzwOPME8l7J8b3D4FAxzAWylO2gvrlrVxaIh9/tZVYe 8ZjT3koSg0r46q5W3NnOZBX64glvFqYrCH4C+6x+YJndO0uDAu9gMSsJ7KHq65KeuFoe OCA/+lBep27k0UN3vQFtE+0wNuejIuBBhFKz5mBb4DQuOd1mJ6F4LiiWfoRmkyYZxXHH HBmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785248241; x=1785853041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UCAZLkoVBQcESsb1+bFs7MFWU1Mwcnz5Qa6bnHCVZ/w=; b=EoktN+XcxIsygGV0fWBNabuaqGyJRuyotZf28D8COocj+87N8UU+vANT/+tiG7tRQP cIek51NZqcdJQfRa94RMJ0y7w8KwmnQu97x098HKUfurNj4UDMhwGSfEIePTZl6DEEib KUzb+LNn9Rx0HgWjdvswrKCJ3IlRR/bezFoNyD+bPpX5BNygUX3WMrNYOfT46HfSS/Fg 8utxT1+kttCYAoNVGMwQmcG1uuwEu9skc7XCDffBCqzo7/2cjMqH8TuZaHFzgXWj5y+2 SXAX6rA7M/MpWkURjc2bUy31XX8sytwLc9Rdb+iQsolGqD6aHNQlk2Ukp2OPm0YvM7oo rARA== X-Forwarded-Encrypted: i=1; AHgh+RrG33CR27sqZRwaPxBDF+v0rWd1+o9+Rd3QaYbOrFqtgqa6W8A6ojrkns0OaY2Z2Txv/5CWChlE2LmpauM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9EgiMbMU0CPwlHLn0Ob9m2cb4+tX3MLenQa+CsyWFYCW6Nzqw +UTOvoEVYPEwCWx+UctOXiOqPdS3im+RjDDwgxCvaF5wGR/TLH079Whg X-Gm-Gg: AR+sD13+Mm542FAn/cBFyxvVFq0PA8kS5qEFZEQPIdtT6kl6nXVPZvTuOLqv2v72sNE eu1AUvxq/TS6lPChTu8NXps4h35JuWsxK7be3hdqj1Y75zwEFdcxGGjQnKctosc0ZqQwiw/8VF6 VOOTQdBURgsz9oeCvVAZQ2qzlERYd91CZGQ51GNptJU/+pSvdkVQ3yxPk1218BS/n9qDZN1r/dW IK874aXoCaL2e9hGxPSzl6aGiHB93f8JIUqCCXzOnhjRpEOLe3BDwmGq3XEU4G9vn0ha1PoO3jB IMUCd5vBnFcAqgOOFiGl/C0ap40nWpE3Jge02byWsUsBW4nZksC3mi3HTv9x8nWqGks7X0+0EBA 9/EsO7XZ3fPJQXvap73FxmmyQFajUDGwQV0iURzwl2i5xGZCEKWcl6NsvFDhVJe698RAJk/hnLO y7OwBzy+KcHtiw7kIvVfdlTl+gV32m0GEfNIba3ZcYQjwUUpjp5NOZk9BbdKIjs1FK02w= X-Received: by 2002:a05:6214:4017:b0:8ef:5103:df9e with SMTP id 6a1803df08f44-90816f64b6fmr28948866d6.8.1785248240970; Tue, 28 Jul 2026 07:17:20 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dd3b56esm85856d6.26.2026.07.28.07.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 07:17:20 -0700 (PDT) From: Yifei Gao To: Bin Du , Nirujogi Pratap , Mauro Carvalho Chehab , Sakari Ailus Cc: Sultan Alsawaf , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yifei Gao Subject: [PATCH v3 0/2] media: amd: isp4: fix error handling in isp4sd_pwron_and_init() Date: Tue, 28 Jul 2026 14:16:48 +0000 Message-ID: <20260728141659.62310-1-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260727183500.298036-1-gyf161023@gmail.com> References: <20260727183500.298036-1-gyf161023@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes the error handling in isp4sd_pwron_and_init(). Patch 1 makes isp4if_alloc_fw_gpumem() release partial allocations on failure. This is an independent leak that was previously masked by the deadlock fixed in patch 2: the thread deadlocked before the teardown that would have freed the buffers could run. Patch 2 reworks the power-on error path into staged cleanup. This fixes the self-deadlock and, once the deadlock is removed and the error path actually runs, the runtime-PM usage-count imbalance and the MMIO access while unpowered that were previously unreachable. The staged error path in patch 2 relies on isp4if_start() cleaning up fully on failure, which patch 1 completes, so patch 1 comes first. Changes since v2: - Added patch 1 to release partial allocations in isp4if_alloc_fw_gpumem(), as pointed out by Bin Du. - Patch 2 (the power-on staged cleanup) is unchanged from v2. v2: https://lore.kernel.org/linux-media/20260727183500.298036-1-gyf161023@gmail.com/ v1: https://lore.kernel.org/linux-media/20260725203640.915626-1-gyf161023@gmail.com/ Yifei Gao (2): media: amd: isp4: release partial allocations in isp4if_alloc_fw_gpumem() media: amd: isp4: fix self-deadlock in isp4sd_pwron_and_init() error path .../media/platform/amd/isp4/isp4_interface.c | 1 + drivers/media/platform/amd/isp4/isp4_subdev.c | 28 +++++++++++++++---- 2 files changed, 23 insertions(+), 6 deletions(-) -- 2.43.0