From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7462227456 for ; Tue, 28 Jul 2026 14:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785248249; cv=none; b=KodKJMlhgZkAoysisAgNR++ZlWGGkf86hnURbqInrY+LT9gE2bv/FRyQWOPtlRg/0KbtccqcDL/wpN/OHVhqSHWqh2Rm28pAn+5Zh9CPOrlCATEipI59Fns0w8bbPqstqgHJJqywN6iQg2YqJmcgichh7oBIfTS1xnBdCeqWsmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785248249; c=relaxed/simple; bh=smzarBw8hIXsOkcyD63/FxPZ8x4SkIwRndC9J2JSFsg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lhfvQ3MpAdHJHxVp4B97eiXzkT/maNXPcLte+uc0IZjOLtxFb0X2bZQpYGPbYLYrdIkRw2jNSzftmztCdUWov/YpDuvnkhOvF2uyI3PimUMUE3XKWWjWj1G3s+t6ZMc2VF53+JeJjKpEJrvgBlN4j2rJrJbovjdhsky3aZXO9+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UlgyhZun; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UlgyhZun" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-8efef6533aaso29323116d6.0 for ; Tue, 28 Jul 2026 07:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785248247; x=1785853047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RDLZZq1JNAih3SrfuWlz8fYPYEmLTTGnMNftSwGkOyk=; b=UlgyhZunb9h6z69RAwhP78q7O6nQbxcAYcCeFXg6jin03OMZWlHIo+l8AEip1XpAgQ rjE2TIQnlhKwOXgs0djIsf/xI3WiLEgkBtt6fjgl4x6PTfExcSBjK2VBlI2+dQrk8A+r pDI8cbZeOZqE6ciJMmcQ4RJgOcLdy9tvOr15su4lvI/Ndg3X2NjLxduWDE0prkn0wBip DJdicizdyc5foKTrvHyFYgfXEcQR2BNlnKgkMyqHGKcKGxTPnNfH3Wc0Oqpy6hVvEkG6 TUV0W/K6K+dGuuw7yu6J3m7aJEWIWBtxjqEAZfI18toaza2nkRJlfhuvvqKcEvE7ygFX B44Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785248247; x=1785853047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RDLZZq1JNAih3SrfuWlz8fYPYEmLTTGnMNftSwGkOyk=; b=YHZ63zx8erRy+jINK6jLQQ2Tm39xL9Itsm/K6OUhaRCeQW+z3hFDtkAn2tPmlCQi7n uTzExz9tHncuw9l7BrYeoi2s7d9KWcBKfEMeNXPWRPs2TTfujU+KC8wFp9QBHMeZt0RW 1SRoMIokN/egsJ9UJCgjwKEleOau4beQBCliKRPduwnpNATvIUdkJL3vNvlNPA14k3OB +Iysixsqh0mipbXp9RN/9QkS6rnWjOArE/2HJY/ulQRug1mHMjenGh055QnTBY/LZJ75 dH7X6uaZ9epEr/AMjpVGAjMeuX7ik4bdvj7VssS5o6c9xgqT/LcUIpx7mNiEkI7eF9Np 0dxw== X-Forwarded-Encrypted: i=1; AHgh+RrpKoywG6NUZCZqU11h9xlfAJiLlx9639cXfrBR24aPU2mPORH5dH+NkyEIZ60FMVzjX2UZ0urE+Bbv4sA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1beOOu9pgS/usYTIyjlcHXXe+ZiiCwk7o0m1A71iSfWlvdIE9 4D4384DMlJNpTCt7+SNqKDuMFLwDj8ZSnP3S0amBbQUbs+/E3DIS2bspI7Mu8Z30 X-Gm-Gg: AR+sD11T2tqjayxRqchhH0f1FP/7/J48gxscx0m1cqwoz9ghnr7Q8B6h5IzAwmJ42cf 9ruHTilUi4+n0EOy/oAwtIYC4UII+g8KJCB9bNHilNZd2j3MuHWJByicKR62TECmCEoougWBUPm tcq3g1ZpXh6PLurBnJMYvwD/wP7ZuyNMZyK5ukxY22imGy0Ca6QuVu5Rvho57chSuHbWFa4Afmj VdSi4C+eBOqo9dxVumx5APYSm0WiX6cCQZKxgrqMIdPKXP2r46wxrNcr6ljwo/b5n0FI73crLGC Iby1Un2tTNmmjtL8xURAhk0itSB6+gTaWcx6gEahWY3JWI7YxikaJvVlkNFQni0rPpqOTRWTErf D6pVeDX+B2YK8MK7NJlV430tx2Lk+O9YfwkZ9EIeNBv9ibI83HfPFVNN/fep+HUvm9HkK4Duo/s IUN420n49uEBtMgoJx+xFAdCRibdyBlrGkHcdshUBuKqpf4q1h3AxxBUvn X-Received: by 2002:a05:6214:1cc2:b0:8ee:756a:f1cb with SMTP id 6a1803df08f44-9081730669amr25567036d6.28.1785248247344; Tue, 28 Jul 2026 07:17:27 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dd3b56esm85856d6.26.2026.07.28.07.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 07:17:26 -0700 (PDT) From: Yifei Gao To: Bin Du , Nirujogi Pratap , Mauro Carvalho Chehab , Sakari Ailus Cc: Sultan Alsawaf , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yifei Gao Subject: [PATCH v3 1/2] media: amd: isp4: release partial allocations in isp4if_alloc_fw_gpumem() Date: Tue, 28 Jul 2026 14:16:49 +0000 Message-ID: <20260728141659.62310-2-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260728141659.62310-1-gyf161023@gmail.com> References: <20260727183500.298036-1-gyf161023@gmail.com> <20260728141659.62310-1-gyf161023@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit isp4if_alloc_fw_gpumem() allocates several GPU memory pools in sequence. If one of them fails, it jumps to error_no_memory and returns -ENOMEM without releasing the pools that were already allocated, leaking them. Release the already-allocated pools before returning. isp4if_gpu_mem_free() is a no-op on pools that were not allocated, so calling isp4if_dealloc_fw_gpumem() here safely frees exactly the pools that succeeded. Fixes: 4c5feef6a62c ("media: platform: amd: Add isp4 fw and hw interface") Signed-off-by: Yifei Gao --- drivers/media/platform/amd/isp4/isp4_interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/amd/isp4/isp4_interface.c b/drivers/media/platform/amd/isp4/isp4_interface.c index 8d73f66bb42c..8e3616cce479 100644 --- a/drivers/media/platform/amd/isp4/isp4_interface.c +++ b/drivers/media/platform/amd/isp4/isp4_interface.c @@ -201,6 +201,7 @@ static int isp4if_alloc_fw_gpumem(struct isp4_interface *ispif) error_no_memory: dev_err(dev, "failed to allocate gpu memory\n"); + isp4if_dealloc_fw_gpumem(ispif); return -ENOMEM; } -- 2.43.0