From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB21F39183A for ; Tue, 28 Jul 2026 16:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785257783; cv=none; b=pPou3zoK9E4Eg9pUvKaWwPrtB662O83uTA7xS3w6w7V1iGfLrgp0aMv2MJdkmR7MkfunN4JulrJ27hfUzyVDkvoEsSWqGauqn2qSCQsC15Ivn3uxtoR/nkjRZFmouubN+Qc8QayiTPdDUsID9b7sl+RfUqjkBPymMo49Lr7PHfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785257783; c=relaxed/simple; bh=Q55LOEsEppqbIbdIMi4r+VcEICQBaQqaDDPUFWfsy1U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hsfQmVLK16KmaeVluAzExxUvyZACjkeV57TGXY2nVXhq1hgLqnxgvlB55OThqlBt34+MsnQ4gsqQ37XjlFY+j5ARYffFEOEIfaN8dgJhUOqB5p6KRZtOZ8sNI3Lja2fXvgWPOT1p85oh1/ThQzK6GxNbMRM9cYKnMhOUjhIOzRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k8VdIuJv; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k8VdIuJv" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cab973140bso1709545ad.3 for ; Tue, 28 Jul 2026 09:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785257781; x=1785862581; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=j+4klrRFig0PGwHGsDr8CnTLSp9SLq5VsHOMKnbKx9s=; b=k8VdIuJvnoavyko3y+fwjjMQTwyTeZgSCYLjHHTsArnr7sWxM1yswvX5icczcgnt/P b/Tjmgd/7x+nlypky1EMsGHSSyThBUrNuHDaJAtyvx5GoQuV0AZivBkI7KV+Nb0Byhdj 6o1NjTvejTw7TscmhefJu9gCLS6bsJixma5CSl6Ec/RjHtW3urxMx6cFSOOxKWRaNLDo lPH65BPA/IIUL1dK4AgQBl/BbT2U7lPEcFiF9uKLGuAwHxOJwvqwQw4wJFkLOsi5wb+H SQ5dgddMGvpsq0FYJG+345WIGEWW3FPhjgrjf/LgOfBRvihc/VmsufGYWheASIzgLpnD XYww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785257781; x=1785862581; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j+4klrRFig0PGwHGsDr8CnTLSp9SLq5VsHOMKnbKx9s=; b=kX5dDhBvs4S69Vdl+5736KAlDtgaNJEswRuyxYCOPRjNSkzHppWc1/LXC7rbr2XDSe n4W8sfyIKDu4tSVIGp3rp0lTNbvdtMkejstFo8tv9IY1RBs0T8vf7GLxqG8RcPe5NLSN 7Frvck2YwjNjBX68EIeQlL79MwHAyw6jNyACbBwPrZvABrkFWPKuRyMhUYMhLAfVLjiI WDqmVJuLzWjyOC3kkUvipKeFXMWswEs2y8whO+gjDjaYh5b8wcIYD68rrILKeB/AFXvp 4by2md1TG01NcD8u6KYKtBSbJa0vBOTIdQswNWCc06fesDnu32IwQxI9oS8buAXmvw70 VHqA== X-Forwarded-Encrypted: i=1; AHgh+RpP/KVzwGkZn1G8B3vc6Xr1KGuENIUOTkyvZVoa3hes4kCzkT8h4oBOmRSWdGtn11gTtPPvune4eyt5Z9w=@vger.kernel.org X-Gm-Message-State: AOJu0Yyb1/wqJlk5BUkFZngXsrHhEbht/N4i+uzrnNowXVzvOguHxAof 1eW24ZTQlwSxbFkbFii+u+AhN0mltG0IPZovjVdZYaDAFfI2UQJmJKI= X-Gm-Gg: AR+sD11zHqD7Xk4A3LHwuyCAyOvJ+D854tz4A7WjlXCXXyLqWumQEp1W2mn3k87Uoj6 JnpLtk/iaLmQz5djRxMF0Fsjm8ZgrIeB4xoaad3pPGrIs9o1Or4NCJswJ5JRnUQqHOyrFWlWoj/ Bk2Zg8pYsAppw8o90tfLRAUvPnTo7I9JBAjF7eAIX8O6lQ0Tz+eTxNFznDHdB5mD1DDGxKtkXjV IflsqOcE6EBR0qVCXCG9Cj7FaOPm2NqHZYkUS4ZUCKM7fxaWWCAA2YpMaERMJMUFrP0FrOxFndQ hSjLumQDcaiKJXA3lWhu7Ub57jUI0iQP0RtiCS1U8A2HLqD24HOe1XKhAH3f4/PJerIh2EeRExg fZT1o07V7T0uI9GdViFMZey0cnHKBZIz8K8fVU3WcczUPeiQmlU3cB7rFzc46LWH88CieR3Gmpi 8MpbMzI+aGc8DjEzC/dHmaOKMl/IvNoT9kC1WQWJyLyq+2UoBDmImvMETWjrSEm1R6ex4qi41aY 0vYmWz4k+vBhXzCRI7m2mCQxHPxjyV8MTvBDHR+ X-Received: by 2002:a17:903:390d:b0:2c9:ff83:41fa with SMTP id d9443c01a7336-2d015ee24d7mr36695345ad.24.1785257781202; Tue, 28 Jul 2026 09:56:21 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfe1ab9c71sm51112215ad.73.2026.07.28.09.56.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 28 Jul 2026 09:56:20 -0700 (PDT) From: Myeonghun Pak To: Alain Volmat , Raphael Gallais-Pou Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Thierry Reding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] drm/sti: dvo: Remove bridge on attach failure Date: Wed, 29 Jul 2026 01:55:59 +0900 Message-ID: <20260728165614.25847-1-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit drm_bridge_add() registers the bridge globally and takes a reference. If the subsequent drm_bridge_attach() call fails, the component bind callback returns without being considered bound, so its unbind callback is not called. This leaves the bridge registered and its reference held. Remove the bridge before returning the attach error. Fixes: 384764c36116 ("drm/sti: fixup for bridge interface") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/gpu/drm/sti/sti_dvo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c index 7484d3c3f4..4978e0acbf 100644 --- a/drivers/gpu/drm/sti/sti_dvo.c +++ b/drivers/gpu/drm/sti/sti_dvo.c @@ -459,8 +459,10 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data) drm_bridge_add(&dvo->bridge); err = drm_bridge_attach(encoder, &dvo->bridge, NULL, 0); - if (err) + if (err) { + drm_bridge_remove(&dvo->bridge); return err; + } connector->encoder = encoder; dvo->encoder = encoder; -- 2.47.1