From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 656F8471CF7 for ; Tue, 28 Jul 2026 19:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785265700; cv=none; b=gnNtRpPmCifV9r47p/o8hZFO6Ay7CmKQbVSWQHMBoNkW1ZLb1eu/0l1L2QLnfmy39kpcdo2pV/o0iGUGyIZBBlCWJYf2+fxEyIMR0BnEw3N9vIEDwhYO8FUNfJi7vz+JiA743m6uJlPrpjvHOWoy3ceCxWGEqWgEWDyKAiEa1pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785265700; c=relaxed/simple; bh=C0aNUaRR1UlcZgfZTjoxt18esB+0rm7CJBlEEQYVGvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h7O0Y4M+WGunvUoQWrAUQFbSDrQM2mSAJFzBs+g0f5d4xJnugjKQ6aX7dIoNAiOjlqOjV0h5g/6kurHlsX2mfpkDYjn8WPXqoOJVlIgk9Zh/Cihuo6XjfJDrVDIdy27Nmtgq1mplHuDvZt/wVTNRdfhzS2a3cFWo+xWSela37ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rwPIzy9h; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rwPIzy9h" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-8fcc43c48f7so1199616d6.2 for ; Tue, 28 Jul 2026 12:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785265696; x=1785870496; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xVZ6pIwSayMA0MEYw9sT7Q03EoLYjNgoRfp9OrMyddY=; b=rwPIzy9hRg5BttFXRT1HdjeFuBGZ02CWNHQcYb1P+1QJpcyF5zPoJD6GO59ydzw1vs aHqpnd7Gz/zo5XscDsgweEY6M3NOpJXkTGjrY3GqGqEyJKz+B+s8M2gDWpZXsLO6ZVnt pdFHwK5tElnaCRQ7agQr9H//Jnvl9uvxKozf1xxGWY2UQvQfef+vXw6tBBLNUQJZGOYD YACnYUgilFAWc2h7u52z9obDzPk9tk3hDOKLQsWDA92emTQfk0ivq7gwbXIKUKAJqVZw WTAzNlryYhFYELxntxZNiRj2f1WykUE2SFgetnq3Yx/7G1/4I9fkKTLhFCfWS9BcIK+g ibKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785265696; x=1785870496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xVZ6pIwSayMA0MEYw9sT7Q03EoLYjNgoRfp9OrMyddY=; b=JL03lAx2g/Peo5Zi/jg0AS+FxNRve+u3x/3X2B3SUOD4sPJsO7sAu2ABwob9V/x/Ry JIeuqc1JWSAfTEBn8l5Mc1Jli7UeLSMT7zdd8/IMlvFNcTpvBJO9aq6e5yq3NBmXb+JW wdnPvV1ycrA8hsuOmlUl0tnr2+Pv8XWpKPGQb32H7skrtOu1YuGVZmf4MYaXS2P+Ef9A ULZKMMc6TokVBVUb30dS1x55uifaknqm3ColxhhTxe+UVBKp5PKhC6nLo7w/CP9sB7nZ wyPLSrfA1DWJ07Z/lE2s8MVF1kcBkI+cYdGgRqW40XgqNPgqNPsaiYkPONNwp4hgl9it kQIQ== X-Forwarded-Encrypted: i=1; AHgh+RpcD9AWxZF9PRzL8/EzAS0ptuKS75uLonQyF3SMlGCLPzZVxS2SGUVTsT4FH9Qy2JaU1dUCZ2QHsJMZRzc=@vger.kernel.org X-Gm-Message-State: AOJu0YwIejNvJkBVeiUz/zH+f4i2KpPaSyIryWZgqrad5BEwjhnTiy0Q 2bYUEuhwxOmdapKP6DzjdDGKpljO9l8L9WRJo6KaMHNTUMBDQfDJSHG0 X-Gm-Gg: AR+sD13WidS1DZ3OB21MQfRH+HSzpyJ+gjQss2tGSeW2gtQkt8ltAz/eCOoIimoOYHc huICEuOqS8g9dsHgIURqFI5EMhDopE9pmufrF4MVtRn3e6bAAl+KDo/x5a6nriln6FX8Xs8IXP8 MJtjyiv5I7CHW6LCtVev5Iwi38lG5TKZ0peVRRPKEjEFhS49Mri9hmb6IXZYdW7jSrcr+56yEES oDMjDHwo0OTUUrCvIsWN/clmuJl1D1Ju3YnPKhx2/WzNQVzP78afLqPgsFH8WlHj8yqRAkbgg7a u2IMdU/2JrMxrBqrddas8rHT/syZCE38el0OXSvxVkL38me3ZpCfdt7Mo/6cpjYWHi5iDgi7xm+ q4AmKAGztOTk2pyhzTrYC8yQpJzQuGCu5IeSr/Kw01QzzFe/BB0E6GDn4OBbE+CHx7CvxSydzPw W9sSOF0uptT/dhTX0yeJ5N+4VHj56yN7ImV9RZc3m+186fpK9q/09akt1JNIqVahUayTE= X-Received: by 2002:a05:6214:54c3:b0:907:88cb:2ac7 with SMTP id 6a1803df08f44-90816fd59b3mr46466606d6.24.1785265696133; Tue, 28 Jul 2026 12:08:16 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dd68434sm5556936d6.38.2026.07.28.12.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:08:15 -0700 (PDT) From: Yifei Gao To: Bin Du , Nirujogi Pratap , Mauro Carvalho Chehab , Sakari Ailus Cc: Sultan Alsawaf , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yifei Gao Subject: [PATCH v4 0/2] media: amd: isp4: fix error handling in isp4sd_pwron_and_init() Date: Tue, 28 Jul 2026 19:07:38 +0000 Message-ID: <20260728190754.363464-1-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260728141659.62310-1-gyf161023@gmail.com> References: <20260728141659.62310-1-gyf161023@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes the error handling in isp4sd_pwron_and_init(). Patch 1 makes isp4if_alloc_fw_gpumem() release partial allocations on failure, an independent leak that was previously masked by the deadlock fixed in patch 2. Patch 2 reworks the power-on error path into staged cleanup, fixing the self-deadlock and, once it is gone, the runtime-PM imbalance and unpowered MMIO access. The staged path relies on isp4if_start() cleaning up fully on failure, which patch 1 completes, so patch 1 comes first. Changes since v3: - Trimmed the commit message of patch 2 per Sakari's review; no functional change. Changes since v2: - Added patch 1 to release partial allocations in isp4if_alloc_fw_gpumem(), as pointed out by Bin Du. - Patch 2 is otherwise unchanged from v2. v3: https://lore.kernel.org/linux-media/20260728141659.62310-1-gyf161023@gmail.com/ v2: https://lore.kernel.org/linux-media/20260727183500.298036-1-gyf161023@gmail.com/ v1: https://lore.kernel.org/linux-media/20260725203640.915626-1-gyf161023@gmail.com/ Yifei Gao (2): media: amd: isp4: release partial allocations in isp4if_alloc_fw_gpumem() media: amd: isp4: fix self-deadlock in isp4sd_pwron_and_init() error path .../media/platform/amd/isp4/isp4_interface.c | 1 + drivers/media/platform/amd/isp4/isp4_subdev.c | 28 +++++++++++++++---- 2 files changed, 23 insertions(+), 6 deletions(-) -- 2.43.0