From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B0D247252E for ; Tue, 28 Jul 2026 19:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785265702; cv=none; b=q/aWpFRlTYYGzkDmKirzH6wEs77W26ebycNi00fmQTCBohMiL+kwliufDidJjExs02Ix9ahvqYVsG/8VcaKJi9wdYELBDJinXOkeO5s9GUXN26BERiWS2IcxpJJMldT6T+r3vd3yiNizGqfgw3v+lPmTS7PGggpxClTcHcAJHZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785265702; c=relaxed/simple; bh=smzarBw8hIXsOkcyD63/FxPZ8x4SkIwRndC9J2JSFsg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rQ8xuN8gizt5ckLHyZAzWSPcH/MyUxVulsKQrEkTweaccwOMJpjP4Fl2/taYVfmjjbkVtIigZbW30qnPMgaLMRUQpWmHoSpuDgP0eASecWO7S8GdqPKPksZQcY196rCc67K+M5e8P+NC3peuyWLzNC8i8qRbaI4eZoaBgiCD1lU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NdndjI9/; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NdndjI9/" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-8eefd0c5f59so1217916d6.3 for ; Tue, 28 Jul 2026 12:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785265700; x=1785870500; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RDLZZq1JNAih3SrfuWlz8fYPYEmLTTGnMNftSwGkOyk=; b=NdndjI9/sF4KueZhuSoMbPVcA9n6pTn3cRgG96Mha+08BX/XZxYmUVFt09MPZlAI2f UjNySYXdwtZKRjMGodSgt4nyXTgJIjAVPkoFs2z4F1s+iqNFZynHcEHCpRB09mvW8qdS 0Y4Wyeu4vS5ZZxS0pElWf+7Y/WliIkjKT2m+H81eTH3uRJKPI21a/W23s4ZS313cvj6k fZUPQhlKM/fSCEUb/qg+M+fxANuU6j/kM1g0NUk/qUAKP4W6kIor5SKe9k3Kb1XEyimS W2FTqyPAeOGuE3js5qjRNNQZS78McMchkdbIWKo7e8rPLzj/YXNGz7RXDTI2xaPqrJS8 Lvwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785265700; x=1785870500; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RDLZZq1JNAih3SrfuWlz8fYPYEmLTTGnMNftSwGkOyk=; b=FWWw+l3dmKh2X4T1+GQ+/gfN9rS4duTLMVhwbqLwZnJ+HfYP5FJQLmlCFnDOKpnI9n GEy3dEbmwOkHYIl9tQhALtwUPEukIoKdAga1UIXuY9tcAKk/C7OxVTGRjT5wLyEz5OBZ LKc3BAS4fC5kWlwKBXKskp3NudAjX7yW2eiA/ea7RaB5pqCNyQjcgftwnMfdV5rB4Asv LYgAftN6evkNO0o39dGY2D+cJ7Q1T5RHWH6yFosncX9kmCMWgy1J9LVpEFtDzeyI1RRl 5WweN17wjGlAFswy7Njg8aUFd3sAGe4lqnQHC84HKO015atbYOA+xJ8u8SH8dI82UHmP yWmQ== X-Forwarded-Encrypted: i=1; AHgh+Ro73vslJV75lPvL8oxgVhTY3EetbmLt41zwyBtLo5DT6Dx/eLpO1UXpKeH9x5FOUHhzYYOirFH9imTHPfM=@vger.kernel.org X-Gm-Message-State: AOJu0YzBNosVSBSO9X/ez+efvFzErDD9jZzNYLM0j0nKS0h36Oj6EFO3 gL5Zd81eaFHdiJG1eFLg13z1pgVAGDyf5nl8/M4KVxQOqnROhZS3hdbm X-Gm-Gg: AR+sD13Co3CjVgSmvbpNLalmRqUZPa34GWLXbJsNQlCVC16Hli5qFwz15Le2c8IyblV IkCU6R/0w9LMKcDvm8YkZfFZzLmv4k0CGybSwWbz2QgFOkGYKT1DwotVWeqlANxU2oJdIxi4bYM zm2WctjdZImORx4MOMbzurH2512R2KV43IFBsYVHYN1VwqhRbRAvMZOIDZi+HdcWRaxN9MlEa8H sV2r2jY64FyenBLuQaL9B1wDEhwuub/VeEu/GyudREKTj24mDDj6LL2R+f/iaCQL2tz5RO++FZu UvhRQ+NeULtZU6+R/yu7ROlHpuWanj6nYcggn2PlKw+XZxlHx5psOZvYGZaRK+4E9bos2uNQEmA MbcCw42WtN8ECqW/IeT1dyUDf5dvg42dezRKtee6o88oIVZ80jt45j6oBn8T1gKRSzKMy+QFWVv Xmdry+a4e29TBmUsnA+OXDIwhaGYBP8acKnsP+SwTnj5nCG37ajr3ybGfnkBxGqEuXpQ+LvUWY/ xhJpGnkvcqoCXnMWiLwlajsyAlvRhE2tcs1Yh2yCk4= X-Received: by 2002:ad4:5c47:0:b0:8ef:1fc9:9361 with SMTP id 6a1803df08f44-908173eff7fmr42591076d6.48.1785265699853; Tue, 28 Jul 2026 12:08:19 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dd68434sm5556936d6.38.2026.07.28.12.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:08:19 -0700 (PDT) From: Yifei Gao To: Bin Du , Nirujogi Pratap , Mauro Carvalho Chehab , Sakari Ailus Cc: Sultan Alsawaf , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yifei Gao Subject: [PATCH v4 1/2] media: amd: isp4: release partial allocations in isp4if_alloc_fw_gpumem() Date: Tue, 28 Jul 2026 19:07:39 +0000 Message-ID: <20260728190754.363464-2-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260728190754.363464-1-gyf161023@gmail.com> References: <20260728141659.62310-1-gyf161023@gmail.com> <20260728190754.363464-1-gyf161023@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit isp4if_alloc_fw_gpumem() allocates several GPU memory pools in sequence. If one of them fails, it jumps to error_no_memory and returns -ENOMEM without releasing the pools that were already allocated, leaking them. Release the already-allocated pools before returning. isp4if_gpu_mem_free() is a no-op on pools that were not allocated, so calling isp4if_dealloc_fw_gpumem() here safely frees exactly the pools that succeeded. Fixes: 4c5feef6a62c ("media: platform: amd: Add isp4 fw and hw interface") Signed-off-by: Yifei Gao --- drivers/media/platform/amd/isp4/isp4_interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/amd/isp4/isp4_interface.c b/drivers/media/platform/amd/isp4/isp4_interface.c index 8d73f66bb42c..8e3616cce479 100644 --- a/drivers/media/platform/amd/isp4/isp4_interface.c +++ b/drivers/media/platform/amd/isp4/isp4_interface.c @@ -201,6 +201,7 @@ static int isp4if_alloc_fw_gpumem(struct isp4_interface *ispif) error_no_memory: dev_err(dev, "failed to allocate gpu memory\n"); + isp4if_dealloc_fw_gpumem(ispif); return -ENOMEM; } -- 2.43.0