From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 999763B777D for ; Tue, 28 Jul 2026 19:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785265910; cv=none; b=fZTnqxaTZLFWwm26p6Er/hIpOZ2n7ojMglxFRxbV+YlgoGeQjyN9zumP5MCOEZYAv2eeE2Uui1cD110Eak1UBne7tAU/nbO5Elb8xRgeZ1L8mlpRtQP1L1RzepIU9F4ZYNZEqlU4vF5KHwIJ3iaj+R/TMTKUItFOPzk+Q5fABmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785265910; c=relaxed/simple; bh=2Cq26Os1YYml7ySX7sq0FFrtje2EO3bOEcgDwVVJsrg=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=EXWYvWj+zrf0Zhmn0Rpkt0xYfRuUZPsPLa4/jcl4UArlKZZg6j8x1WxDec450aRBZFJgIElGilJxWBLX1I2MXTbKyxVM1jCUTO/sI8KLDgfYL2F2WbHneR0WUMMwV7m13s8qeJ9jFvFowbBJ6/4ir5PMBl+n9JEpoOh8r4ZXqs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fudapTEu; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fudapTEu" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7eb64371a2aso177737a34.0 for ; Tue, 28 Jul 2026 12:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785265907; x=1785870707; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=KsgU+jaIJSPOtOW4fRT9Ixh2JPmbi7dF3B+OsSALrFE=; b=fudapTEuELG5NCi3gUdTrH9cMbeKXrFsc+5o6yLmD/PVgyVG81BGXT0WWbWCeNpMb0 agBHo7YeaCxtZZcgNBPolOcTFknaTdJ8UZQ/op44ZucHowonok4Z34GWr/BR2laEybSR jHs2R7LU9DJlxVGNSfYGm8fvytPyTzSl87FtkFMiH9AYPYR/ytxhdzLVi2NoBwDgbG48 ogBKSqFoTP9KeY9Q9eTG/ztdNjPn8e/zsjBAktHTNp1TveCXrJTWWGYmfkd0bSCDORp2 V6AiC83zbV3hUYf3c3uTvEMldaHyeHnroicbCTObXX12fSRHfHreLpx+dRQtBcG7CbFy pRdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785265907; x=1785870707; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=KsgU+jaIJSPOtOW4fRT9Ixh2JPmbi7dF3B+OsSALrFE=; b=Z9khvaGhBjGrtWPK/8T0TR/HZDD5jsxBxEe1j2ZknK+ASXzujuopsIF5s5v26a4eRm nY3j6jpErbjvvuOVEL/b/noUELFpFV68I32XEYt/vq4ugVa3GQ3HjXx0yJCsbs8DwAWc C5dNsjNxru1SRVwE51t5MWOqs3vn+Gl66iiVec24nGvRIrCTtE+0FgTmMoW8smBGrf1P R4fl4lG69OdXwRTv6PQkXe9yCDRZ5H9i+oVl+VIJqMhf2q2EzRWTS2aEcNQtxN59lu8Q Jtmm89dAv+UhCzvEGwZ+uweKDslSemNITHnGROQ7ywvWNzTyY/Me6LF+qF7ZWrUsudpl D6Jg== X-Forwarded-Encrypted: i=1; AHgh+RoufNoY5PPwcbErqqTF+ehBTAn0vZqGeW7yH6dw12CZ8QwfOsQVRZoocHxiSKBdOJV8ug++MN/S9O1nF6A=@vger.kernel.org X-Gm-Message-State: AOJu0YxUhM1Em4KMcpNYpDmRu85tWMbi7Pv5FU5p6JgBv6833/e3ZikN x88/nPbJrk0I5nGq03LHZddGdyGmbzcsbD2nx2KNmaE7PvcCviGyfFHX X-Gm-Gg: AR+sD13bJr3jj8WLedp3G4Pg5dtqwerI7/3mZwt+qD2FxsmsHJY3mXnWqaJk9y7F6HD GCg1kH9J+1p/nukp55Idx1QuU2cqF7vu++AWsDrWYr+ItbSkSjCOSqcGvR4sz0mBlTWAQNjpLaB JrAW/1xpPsydcldKWUMWkgloTOuPGsmMpbDMwT6G0WXsYaWp4HbXg0y9naz27zh+Osu8Rn2fXBe hmszNsa4Rx7xlek93pm4qOZleAWU+6XM4yeQCnGoxBbKtEnVPyyrTaMojRGb6dUpuHbG+8nBWH5 wv2ryA4YRo+3Kl28lKeegxDYeU/33JvBezaVgpNbGkcDYMCh71xcJM+1FSv2F3hiTiBLYl9Pq4k TFKVdLc8cDd5YRsOQBn5zXbdS7XHD9ofHmO+EA6B/KDc/Z2I0WogN+jEg5Cy3go2dB2M749YL5Z tLSUW3uJCnGA== X-Received: by 2002:a05:6830:6102:b0:7df:5fc:3fd8 with SMTP id 46e09a7af769-7effeebf16bmr2243434a34.1.1785265907477; Tue, 28 Jul 2026 12:11:47 -0700 (PDT) Received: from localhost ([2a03:2880:12ff:2::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f00d5f3aebsm473712a34.9.2026.07.28.12.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:11:47 -0700 (PDT) From: Will Chen To: Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Wei , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] bnxt: fix memory leak in bnxt_queue_mem_alloc error cases Date: Tue, 28 Jul 2026 12:11:45 -0700 Message-ID: <20260728191146.1744825-1-will.chen.tty@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is a small memory leak in bnxt_queue_mem_alloc: when bnxt_alloc_rx_agg_bmap() succeeds but bnxt_alloc_one_tpa_info() later fails, the rx_agg_bmap allocated by bnxt_alloc_rx_agg_bmap() is not freed in the fallthrough cleanup cases. Simply free the rx_agg_bmap in the err_free_tpa_info case, as this is the only remaining error path where rx_agg_bmap is allocated and needs to be freed. Fixes: bd649c5cc958 ("bnxt_en: handle tpa_info in queue API implementation") Signed-off-by: Will Chen --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 7513618793da..c30507dd824e 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -16267,6 +16267,8 @@ static int bnxt_queue_mem_alloc(struct net_device *dev, err_free_tpa_info: bnxt_free_one_tpa_info(bp, clone); + kfree(clone->rx_agg_bmap); + clone->rx_agg_bmap = NULL; err_free_rx_agg_ring: bnxt_free_ring(bp, &clone->rx_agg_ring_struct.ring_mem); err_free_rx_ring: base-commit: 3f1f755366687d051174739fb99f7d560202f60b -- 2.53.0-Meta