From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74D5A47254E for ; Tue, 28 Jul 2026 19:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268046; cv=none; b=YPMii5CqCNa8YyicMofuHCN8+qBhdRpwX6yV0zwP5/CobxFFavt2hozlethE4T4A2rZ+6Ys6D0l/s9Fba2f/4e7N59nCi3NfGeMBkhUE731IPa9QrZAljom8bs2xLjCt8HE60mDIRVRuh4UTU3GdX/JZc5r5d8NEU/RyukVL+lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268046; c=relaxed/simple; bh=53Ch3mlN8Z1SIL7GE9UYSm9RybDWpSkaOiwvLUXPRDs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uiTnGwnKNe3Ko71Lj24CYtdkUhAs4AMQbYsYmkLDV/o86sxCK7wrcE6pmWRRHcWJHi6R2tbLQHjwgLO/cI86FOf2HvQbCC9HORexiyqoU1DtlEmd4IsQoHaUfIdxqGpAkCTy2Nr+mhzbsem3fxsBnoOSmtPjiOFsxUc1emmV1Hc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=MLHF6u8h; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="MLHF6u8h" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-8f186025973so2195646d6.0 for ; Tue, 28 Jul 2026 12:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1785268043; x=1785872843; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VJ+l350a6OlsWiNiaSEE/Z8jsj56ru6jIVfVE/WM2fo=; b=MLHF6u8hhPC3nRM7moqZu6jbVNM9kXgXMnEYt9HHZuffiLRzN1X/dFflQO68VFV7Bf vTyCmeWIMuxb8HjokIQ4q/1y5B6Mrrrm2mpUMuinBsMKy1No7kxxzk9J9C0+iplnMp20 5ac5yIm64VmsjMgS0LAyyz0v2O7tR/pdpbAMG5usmqtO+Xet01vBcyblKsHxCxpsAilq KTfyAOT8saSSVS4NpbdM1zm8tvBlvaXCMkTxodJQF940hwZQ9hPTxYFUIKi8pe5JHlra FpGrYdlAufdyWJcr0fhps/0M8Kf+QuCaaqWBLgVk4PPX6fyZe4V01lIURxt9onv01O4t 8Rog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785268043; x=1785872843; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VJ+l350a6OlsWiNiaSEE/Z8jsj56ru6jIVfVE/WM2fo=; b=mFwFFRWRFaHXsLWgJd+hYJ0ymJ69o5Gl7cKFXwEQjJsmh9UYyqBlLSOfIjjUbprGOc DEPLWUAjsXFj7Ckx9jZ1Pg7LrKMSCufVsqwjv6NCZEJeBzLJJdCaUw04VKxxrX+KI5Sy ZJobZjQ44h4hNnARkMf2B8ObOP2D3ehKwbhH2Ot8ShLBlbYfC1BWKHX4UtfmT6GDFSUD Yr/mSLtz1hr7WBUqiqMwLkdGBMfy/Cbgm0EKCqAzHBtbaTNQl9cYGoFWJrd7yTtv/uCg wVbwN5htDfqvpBJKwKCHNCuvGJ1uOStJBWxMzb206nQPvOwTUSwLqF65RB5yrXubLee9 /HVg== X-Forwarded-Encrypted: i=1; AHgh+Rqjr+2hLTaA87dutySvE4iAX97bCYkBtI77CB+/+bfxIWSLox13V+Z5fcKI5m+sx1uIf4sCdCZQghprqRs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5/YjBI4oTgv5con7uZNnnWFSyy0R3oL5MUeyk+tXE+TyNVO/1 0KEMfJaBv2XbU/QjngmWmONH5ggT9NBI96L9+8uZOKNUspls63I6VekcqRcMViSnZiQ= X-Gm-Gg: AR+sD12ijDNPLA/dLTCBaPuweWieRzXNpMI+oz1L1lvELnhj73NIN3oHHmPu6DnwLGY 97D10T/vvoH5D3QKixRbFBti3CvYcFs4rAToG01M34Y2I3Am30VmJFwJw8Y09fswEKAMu3K7yA6 6sr3RebydRXhnE5qX8Ad0R3tVSlZEBH2cmcD9smx6p7yDOLfedwXnEELdRGHwXCGmJy49JxPfe8 tHkh2V72vwo5YY49p5lB1sr+xVA860YGxzCk8IuHZGB6kvyPEox8d/FZslvyxiQ6cavSIP8qCBD 8cwCODKTwzncYaVLlsRFJiJNSHjUr9uhTK2YLY/D00OFG1dDEj7cCgqsKzW3088vev0BZn+xPgU pgx2X0DIVxV7n1mXesztS+t9N5BkY04UKIHKZKq+hFV8maNeC8Ra+fFtaMmshdB0oyhCjzFZnKi bsaf7NXaD2Es+r3pGV2EFR/NA/UNLW004LfzpGv9VBhmH5rbZjVYrsItfFP1JbxypsHMQLTIImW zFiiVz/V3+AIKQfB3ZWbvV2IOdWBwVnAuyoL8Sgi5Z540ZvndxfRDO55FT/3Q== X-Received: by 2002:a05:6214:21ee:b0:8f4:821d:95f7 with SMTP id 6a1803df08f44-908170026e8mr41209526d6.18.1785268042709; Tue, 28 Jul 2026 12:47:22 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dd6b539sm6700176d6.41.2026.07.28.12.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:47:22 -0700 (PDT) From: Gregory Price To: linux-mm@kvack.org Cc: damon@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, sj@kernel.org, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, vbabka@kernel.org, jannh@google.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com Subject: [PATCH 1/4] mm/damon: defensively skip zone device folios in damon_get_folio() Date: Tue, 28 Jul 2026 15:47:11 -0400 Message-ID: <20260728194714.3713735-2-gourry@gourry.net> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260728194714.3713735-1-gourry@gourry.net> References: <20260728194714.3713735-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All DAMON physical- and virtual-address operations obtain their folios through damon_get_folio(). That helper already excludes ZONE_DEVICE memory implicitly via pfn_to_online_page() and folio_test_lru(), but this is inconsistent with other callers in mm/ which test explicitly. Add an explicit folio_is_zone_device() rejection in damon_get_folio() so the guarantee lives in one place and covers every caller uniformly, consistent with other mm walkers that reject zone device folios. Signed-off-by: Gregory Price (Meta) --- mm/damon/ops-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index d7d7f100389b..d8bca7355b4f 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -32,7 +32,8 @@ struct folio *damon_get_folio(unsigned long pfn) folio = page_folio(page); if (!folio_try_get(folio)) return NULL; - if (unlikely(page_folio(page) != folio) || !folio_test_lru(folio)) { + if (unlikely(page_folio(page) != folio) || !folio_test_lru(folio) || + folio_is_zone_device(folio)) { folio_put(folio); folio = NULL; } -- 2.55.0