From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 013423D5241 for ; Tue, 28 Jul 2026 19:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268048; cv=none; b=hyLiQwpxK/CyFDntBr4v95vzmp2QYl+LINZTjnXBI26YVjzxByqbwZl4CBqpuBxwgxHr7H92I/zr+/jcjC2RumY7WhLxISJmscREL41ltwsDnY6XUI/LlRnj82wiKviBWBLdBDSLLblnxNrB/Ia/IXmkF84kVVGeZWyK0Lb3EQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268048; c=relaxed/simple; bh=IK8bhalTgcn89FsoJhNsDE34YEq3nhk+YmitLrNz4WQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HW9YaRJN0GZzaV5tA71VvN8RJtmitwF1Up53AMtJ9T3YDI3ROCSqZ4M9UV2wtEfDrC9EEg/Cq9giZdnolGszyyoXOCBuueR+2dQucjp3IMKixSO/7P+IEW3RtdF3vRyTdDUiE0z+HDuqMdxfk/9egpS7Rx6BYgPgJKuVD29gDlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=jvvgveMi; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="jvvgveMi" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-92e67555e24so16267485a.3 for ; Tue, 28 Jul 2026 12:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1785268046; x=1785872846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jqMrLj14znUg+sEtuaSkWx5HGI/GWtvDstY3+0sa+Dw=; b=jvvgveMiEJjWDe0X19bmHNKjkuoZ49iFBO2rcynP+8M4Z7KflmeZa+nnkbEuF1xrk5 3WKAhL+sIJ2ErMPh2K1syFu/bI+mFXu7BC+hiHv/nr3zHZNLDw/GSjlVPbPpw0yYeX5B D3FDN0PSgKPvxPHTd+yrJME13V7P+MW9qzu3jcGLjclZJ//cK1OLyNVF9vNnOyxyD1eI QJq25FviN/AjWYDMYA2RBQxbg4k3EfGjos3QDxV9OYtSXaoEQ/Gp2vH/zdIFij1XFNKY XovSn2nANuxGzWDVU/tEz449wawnjY1wej1jBN56i81I1ZPLhHJzIegpRqYqhPOrbdrv GVfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785268046; x=1785872846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jqMrLj14znUg+sEtuaSkWx5HGI/GWtvDstY3+0sa+Dw=; b=AoT33lASq7pA6vgHeO6pxtNqfFsKv6+U0ojOKUee6N7FI39deIirNCsysyHb1X/9Sf 4xlqwdjr2bcK+rwmsReRQo3O/B/GetgG0590qW72eGrdAcoNFn701O0vOdWnT1FD8gVw WRNZYmuhg02wW5fI8umdQN4YLQRh4s/xUs3LjA70mPM04r4SVjTW5q4ix2uhIeCEFE1d DpM7zq93ZqW9SP4JQXvB7FplTc/yDDDWIPDD5LxTKGPXVQU3k+3AzmRHlSiXdctQ/yPQ zuPrgv7T8CpdNuZi/zKzfMsZBgOI0ge+C4lC1U8XSPGuXe8ewjuO28pcmZwpe+FAhKb4 L4DA== X-Forwarded-Encrypted: i=1; AHgh+RqalNJJkfu/DQoRkh1tvPZJrQzc3imuscY376cE19dgLS2pQB7UteCcIh4SnJizLhc5G6+T3Ew5Pl5Z4OQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyBhOAQ1pQ9Q8rHCydu5Fp74EgdnY8FwgxuTDcht5q3C5u457W3 vrYROmqaDGiNGB9Z2BVza6rFUDYorEtZNCmOK3vNrCoefco2OYNVT7n+d0ArwVr2wv4= X-Gm-Gg: AR+sD13asSqq+a6J0PkbfEY+dlDQWOWsTBk1Jms2jFpJCyQkPLu0ZVXF1H/qSHsoCcN NVE+TUlD6aOdWhcXSY26Cc6p5Fh2Xn+PTAWU7ccL5zpBKjp8B2Gcw7xlGBlF+qpSl+ArsGxFPbD fBEKtk4Rwn5kFPj4+1AvlzwOJQGVcpdeMqHQ56czUXVfPCSddGanSWrbD2ZrACSdLF7aLpOC4a4 8Rtb+cvcUcrPnoBPY4EMI1ePWGXRjw+D5KMHpIReq/X43fPGB8aysnPZAMufM848Ce61fxddQSA zBY68LwhFgtU/+i+6QqqQ0ctMZpkzJtF/2iWOelaL7Y1eVTdM2bJ9ggKcXS8OQVZrPC0mQgVF0z 1EC8wn2rHa6vZQCmxA2K4EO3DAgkTfSxGsIh4C1LZQyOd1wtAVO9n8504jRHyi1nr5dXW8xbpZJ XxSOlIG/IZZSk3NEzp/xvcSnNA/uxOypYBCUe9Ek/8A+/+QzcpCW7KNfeoTR1GdA3o5t3U+pQYF 21Va3t+NTwPt35fFRiP4/QwvDvB1kVIgmVKso3OnQsjD0qPkQ== X-Received: by 2002:a05:620a:40c2:b0:92e:caf1:7705 with SMTP id af79cd13be357-933027a9447mr385229585a.49.1785268045825; Tue, 28 Jul 2026 12:47:25 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dd6b539sm6700176d6.41.2026.07.28.12.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:47:25 -0700 (PDT) From: Gregory Price To: linux-mm@kvack.org Cc: damon@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, sj@kernel.org, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, vbabka@kernel.org, jannh@google.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com Subject: [PATCH 3/4] mm/madvise: skip zone device folios in cold/pageout PMD range Date: Tue, 28 Jul 2026 15:47:13 -0400 Message-ID: <20260728194714.3713735-4-gourry@gourry.net> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260728194714.3713735-1-gourry@gourry.net> References: <20260728194714.3713735-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit madvise_cold_or_pageout_pte_range() resolves the folio backing a PMD via pmd_folio() and ages or reclaims it without checking for zone device memory. The surrounding guards do not cover every zone device case: - can_madv_lru_vma() excludes VM_PFNMAP and VM_HUGETLB VMAs (so device DAX is filtered) - !pmd_present() branch above rejects device-private and migration entries, which are non-present. - A present zone device PMD - e.g. a device-coherent THP - is not filtered by any of these, nor by pmd_folio() (unlike vm_normal_page_pmd(), it performs no special/pfnmap check), and would be aged or paged out here. Skip ZONE_DEVICE folios explicitly during MADV_COLD/PAGEOUT. Signed-off-by: Gregory Price (Meta) --- mm/madvise.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/madvise.c b/mm/madvise.c index 07a21ca31bad..ffd6a68320a8 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -395,6 +395,9 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, folio = pmd_folio(orig_pmd); + if (folio_is_zone_device(folio)) + goto huge_unlock; + /* Do not interfere with other mappings of this folio */ if (folio_maybe_mapped_shared(folio)) goto huge_unlock; -- 2.55.0