From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095AA3D1713 for ; Tue, 28 Jul 2026 19:47:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268051; cv=none; b=GWmxEMrn+mu084LslD4oq9J79bDRoeU1joMbV7BCXlH8xZfD92jNWlDc51NuR2qms3BWcIiCjJsPDaF+jPapMt6gCD3S9jn2+iefqgWzjO6UikfCBXF4uRBtZwS1wu/FZ8xyh0Y2cai0y93PcsOhR+tx93RQutjg5MZkSbhaa60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268051; c=relaxed/simple; bh=kIrfus/hl/pctQx7Y9xBksIrFueXRHfHKGKjTDmfFcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VwLdlsxAU0X5moCtN7pTssjul4Z2B3lYhH5hatTHbYcFcifcwNj8b4SDw2F4YTPKfAyqGh5q1aw9bPI6AOFu+2b+v66ADrVzGAffiS5v2JTa0E7mAaYoTDclRAzi6uhNHX9McYs2FMS+ujserd/cR//vxo9ZOtit2GkO7DR3BXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=f2J5xonv; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="f2J5xonv" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-9034b6b7674so1537526d6.0 for ; Tue, 28 Jul 2026 12:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1785268049; x=1785872849; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lFasOBUZoPmfk9ObuRJF8YRYjBN1D6LiYKjqRhex4gk=; b=f2J5xonvMWMuQYfL0TqHY8AJ4j4dLmLm0jinPZbkPOqT7iiDoa0TiHC4UlM2rjjLmp wuALjovdFvOhisLmdJS6U5bBGxCA9aobiSBeQYrn8MaKm0og6x7njCSQF6jTyN/i6/jf ZZgY9kSUgiDOjeByRJApL0dqYAdnOEimAoO3V9AMXCAlRXGL+4OBl6wf8smMD2OtdsGw 7gUXf5Zxes7173zr32k8x5WzsmSQbCi51aqEk1fXHFSczYAmai2XB22wDESz+LG01txv +FcnUS+xSbtcEZXv5tmQCsRPtMTaWlMVSOMkwX3jPkyJ4lTf1Y5hr4xXoPBhc0u6Y5lu 0oDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785268049; x=1785872849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lFasOBUZoPmfk9ObuRJF8YRYjBN1D6LiYKjqRhex4gk=; b=IWcXlCS3pWEH6v0+ws32ZnRRJgA4iO9Ci2adpj8EhMLpCTPizxNVlwdJcOv98xXA+/ 21n0IOcMAVir4nB3O7BzdFW+TwzjWIV8+O+UTLpYxCm/FyjLeBiGcqfFyOk7orV4w7ga EK2FBaUS3pWeyDE8KVRkhzXvQVwUK1EvOpzouK2mQAZI+ja0u6ATBwOHmwNSsKW6P6AD FGkQIQbDRVAcrC5O+5t5sHg91QLblap7mb0XrfoVMZ6wvZLvzeVvBQV6aymcJqZzEBia fEOPexo/NOxHXc4l1XLOuwnJowisMn/sJIgfxwWrvkKVLyb5n98HEgnmaq6Qwl2dGWPz n/ig== X-Forwarded-Encrypted: i=1; AHgh+RoSvRuw8DwKENHS2MEp2A2DI6S8GWyX9hNxAM3WP+OxRGUVAvkHcokhFqNOkNYO1dh5YenXEAjTj2REqCQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywuyl8ACBuf/K+qyEOuO45+d2jsSvKesodnigirstcPS206+ioC O9YbpbBh1m+HvIk7RAVbxPUbfKzvNlXLWOBrFH2PBGFLZSujwtaxjfoL/EbPEdrdYUs= X-Gm-Gg: AR+sD12bIcAzUlJUYchBrkL+oYz0RSZ5tGWP7qBx7IEUbpEKTQHS1Psak8+rXYPo+A4 J+D4g+p2JvSCsVNKMCTaI89x0mjrpCUJpNdUkPFhmpzsPN0nDgTd1XXGy5H1lQ2J7Cebm+tsM84 P0VocFiLvp+EIXe0vUZryo0SuAjqkfpbQGYNAWlhgneXFhkF0XG5ghfBa2jJvzSMUVG48w+WXhh 9nt525xkCjU3T0+4EzlNgcgNgPHFhl8imMWucEQp0q+/d/huxDPZV86FasSg0JVd69QcYAgbQCN r+fRrMWPnyugJj0fgZJh8Psyoks+QU+u0hcu8vPRsc1JOqlP2SpILVqbTNAa0CtbnrEIVmM3Is/ bqbL1knyYLftgM6bXV3aYQE3T4ohVpvGoHzErUuxg2byRBt/3Jz9yhc316CdxoIVcvcU6FOnLwb qk2Y/jywkKVoL4479mtt1m3PJHRHagiZvz+QTwHUKI4r/ErfepFSfgouw9SvFgrcCeDRRLeDzeA YTWMG6FwYtprR+mtr2dU3O4EOhkAFLAj4mnkbrW2tXvBlQ7uA== X-Received: by 2002:a05:6214:4847:b0:908:1bd5:9c38 with SMTP id 6a1803df08f44-9081bd59cc7mr30163246d6.14.1785268047908; Tue, 28 Jul 2026 12:47:27 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dd6b539sm6700176d6.41.2026.07.28.12.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:47:27 -0700 (PDT) From: Gregory Price To: linux-mm@kvack.org Cc: damon@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, sj@kernel.org, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, vbabka@kernel.org, jannh@google.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com Subject: [PATCH 4/4] mm/mempolicy: skip zone device folios when queueing folios Date: Tue, 28 Jul 2026 15:47:14 -0400 Message-ID: <20260728194714.3713735-5-gourry@gourry.net> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260728194714.3713735-1-gourry@gourry.net> References: <20260728194714.3713735-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit queue_folios_pte_range() already pairs vm_normal_folio() with an explicit folio_is_zone_device() check before adding folios to the migration pagelist. vm_normal_folio() alone does not reject zone device memory (a present device-coherent page in a normal VMA is returned as "normal"). Mirror the explicit check in the two other walkers. queue_folios_pmd() uses pmd_folio() directly and can encounter a present zone device PMD - e.g. a device-coherent THP. This is not filtered by existing checks: !pmd_present() - only rejects non-present device-private and migration entries vma_migratable() - excludes DAX and VM_PFNMAP. The early return also means such a folio is no longer counted in qp->nr_failed under MPOL_MF_STRICT. This is the same pattern used by queue_folios_pte_range() (skipping zone device without failing). queue_folios_hugetlb() cannot see zone device memory - hugetlb folios are never ZONE_DEVICE - so the check there is purely defensive and keeps all three walkers consistent. Signed-off-by: Gregory Price (Meta) --- mm/mempolicy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 5720f7f54d94..bd79e61a40d1 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -668,6 +668,8 @@ static void queue_folios_pmd(pmd_t *pmd, struct mm_walk *walk) } if (!queue_folio_required(folio, qp)) return; + if (folio_is_zone_device(folio)) + return; if (!(qp->flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) || !vma_migratable(walk->vma) || !migrate_folio_add(folio, qp->pagelist, qp->flags)) @@ -797,6 +799,8 @@ static int queue_folios_hugetlb(pte_t *pte, unsigned long hmask, folio = pfn_folio(pte_pfn(ptep)); if (!queue_folio_required(folio, qp)) goto unlock; + if (folio_is_zone_device(folio)) + goto unlock; if (!(flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) || !vma_migratable(walk->vma)) { qp->nr_failed++; -- 2.55.0