From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B9A422E3F for ; Tue, 28 Jul 2026 22:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785278548; cv=none; b=nY2CVb36rVhtxmWCnQg6rN4vDPzhCbvpSRTXgOP54vgTOM2sDbXjzkF19tKP01fZ4UCDIBB/AyVd7hQn7ddlykmoBPH1L2tz5yzawz+79HjZvFdabvxdJTFB8/NooYXLTq2n0evTyE7W9CgT56rVH1IMPnX/KYlQPn8VbA+Ese4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785278548; c=relaxed/simple; bh=AIaB5I76MWLkDaE51/hOPv4UytZ0f8Ty3GAVN9lTEBI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SWYn2Fj2FErjnR3lPrUXDbCoCTKTOs2weVgoIA48iZh+bZlEs+OB5QPVF7mkOaBsQkvy94zc5hRkd5Y+y4vSIvf5FJ9/jeOMJSn/yspK0/0uBBs8djCqn66MiHcaL/jPlQbbLwUkOB0t21Jbnmjqgu8F/+ZM5GwZSgh7xBYHm3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cwQ30XWI; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cwQ30XWI" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cc73e322dbso4637325ad.1 for ; Tue, 28 Jul 2026 15:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785278546; x=1785883346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=DzP3draKYRTj1F850nyh0ki//dsuTjC4ly33CxuMaFs=; b=cwQ30XWIPb73p/eTv5TFVMimo8pL8bke4tGDaOJCOsK2m+V4B/IzJQZLgqZWGz/tsO jqcaleBTOGf/FAm6+CB3GX8jbg4/lYFlLMtemw2IGXfUAL3hjjBiCXIATMfLPF5x2Ghf 6xtahu0hRabsPGZFiDtjQUcz7qeqn6uXi2E35kWvWyWZl6X7Midd2f2dTj0D3w6PkoZj BGG1O9sZ2t4IcXy8PlePyOFTmOJqMzp6brFaPZMkai8n7xMRxa3YtwXECbztwUj78pK8 1iwabrNj0zlXbC0HevTE8vxRh/32eWfhD9Vq7wqAUUjrdKUYHtoJD+rtpvQ/Le7keuLx U35w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785278546; x=1785883346; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DzP3draKYRTj1F850nyh0ki//dsuTjC4ly33CxuMaFs=; b=SAub1pZC2R5dNeFzkSAtG6rt5mIWctwiu6Y5MRtAy6wmaiRC8GZ2auDXW23wPDdTyJ VaDGYfwrEyZ7Sz3xpXHO+CsZaO98lh5VJov5T0lZJbEa3zmJmBXao1ZB5sER/W4l21F/ 2dvWcObWe9bP4vhxpzfzVdBATW1OXUELfItWZjD4bkYecvJOcnofpkMLxzwPD1GykmAF vbIS2lm/frNOerq/iXnIX1HzBmirpxBB2WLPFRqvMYGkxFgx+aUql/7ebw9gPspzong4 Kc6ibCXHlDe23JQOuqBGrHQSvA/7+f1t9hT3/its3a1NNuHXtlFVZCwzWedq7U8G/UhC KA1w== X-Forwarded-Encrypted: i=1; AHgh+RrJPzP4cZDAldP7Rn9AopzWq5hdr8r6zxt0DAwlyTBD3/w9KY0EkekOAEGwjdTDINxzvOtypJNsH79YeT8=@vger.kernel.org X-Gm-Message-State: AOJu0YxV5B6s1CmH1IVxiA1fYq6vsswyC9H5C7XcYQQtOKSqsrjNYeu8 NlD+rXoiHaiZqqXiuqjd0cCqp+eXP1xhM/bwzHmyErTNptx0eNE82LSi X-Gm-Gg: AR+sD123LA4oepBCx2HojeKP77OqV2npSG/3TOewrqY7r2uRgP383IQOmkbcOnUN+Ch b9vKz8FPA2eXaXNbmclskq4ltzQ/NYakrEld+773zzMm4xACcpdyWaNoSu5Pp/A5NxVCYjIQ7uX +I1FoAM3xkhUN4aX0yAPu8vI4ZgcBM/hXg60aEsDbZjf3iBdJ50UEXydJCJmjF4T2zJrXt/rqSm wnxqOVqPHkLF/5zVxzm/JCcgqu2n3oWUIhG0ownFCT1gvb/x0ALusedUn3Zlmn4Xxxw6sb1BrNo ojss+Omv6yOF+pjuDa6IiOibA1t75v14DRGwWdr5jPRE7UspJcN4OteSpl7isO1aXye309YkTrY GinqKSD0MmV6/iQ/W8Pv25Y5lrxpToDkfSc2otJCfyjg5nEopoJ+kXu/KgUEot6bf5BnD3c0aUv oVpXGbg7RChmrZR1tnCHKO61nr+TTINnPN20oFrpr2PxSoqp1w8+ihgSjbP759zsU3BQjhFYooj 3MZ5OR9bR663ECuhO+Yvu4VhNsTHGREW4J2Wf3OTbukZwQQtRZvrVer2nc3j1nkLml71fMGZqtP tJzkATsLVXTMW9ySkqk78CUidrcJVAEsU2xw5w== X-Received: by 2002:a17:903:1b24:b0:2c9:d8c6:1dc3 with SMTP id d9443c01a7336-2d01598435emr49118595ad.0.1785278546164; Tue, 28 Jul 2026 15:42:26 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022bfa240sm2317495ad.65.2026.07.28.15.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 15:42:25 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Srujana Challa , Bharat Bhushan , Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: cesa: clear cesa_dev on _remove Date: Tue, 28 Jul 2026 15:42:23 -0700 Message-ID: <20260728224223.82278-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is already done on probe failure. cesa_dev should be set to NULL as the driver checks that it is not and errors saying that only one device is authorized. Signed-off-by: Rosen Penev --- drivers/crypto/marvell/cesa/cesa.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/marvell/cesa/cesa.c b/drivers/crypto/marvell/cesa/cesa.c index 75d8ba23d9a2..f0da4676b15f 100644 --- a/drivers/crypto/marvell/cesa/cesa.c +++ b/drivers/crypto/marvell/cesa/cesa.c @@ -527,13 +527,11 @@ static int mv_cesa_probe(struct platform_device *pdev) INIT_LIST_HEAD(&engine->complete_queue); } - cesa_dev = cesa; - ret = mv_cesa_add_algs(cesa); - if (ret) { - cesa_dev = NULL; + if (ret) goto err_cleanup; - } + + cesa_dev = cesa; dev_info(dev, "CESA device successfully registered\n"); @@ -551,6 +549,8 @@ static void mv_cesa_remove(struct platform_device *pdev) struct mv_cesa_dev *cesa = platform_get_drvdata(pdev); int i; + cesa_dev = NULL; + mv_cesa_remove_algs(cesa); for (i = 0; i < cesa->caps->nengines; i++) -- 2.55.0