From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE8637F01D for ; Wed, 29 Jul 2026 02:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785293755; cv=pass; b=FNvKSf05pv2DyQqK6UYVentYbskeaIeDZyD/gz8PF9UE5rxXac8eOYar5spdlcf78ikQEL1dbqTiq3uiRv06uWUCdbR5leBwrbMHh/I0/GLL2gGx9qr9IecJkYz1azLBCr4CNbReZEZZw4ZdOFQ3iIhVCxlvSwG7Vo3YcBCfcAA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785293755; c=relaxed/simple; bh=4tGiJGWiK+TDM+P28WpbzF6ffBP1X3E56TrK7Eumeb4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VOa4oCaukSB0iozXHeqvbvvfcGND8/g3J1Vel3/mVZNr2qgXahpelTnxzWIMXhIoh4fY63e4Kzf0Zl0Zfmyqfp4en3vFCIuavTfFurNNH1/VeSGltBhj7OXq3vtpQemhE4he/GwgvMXbcYp9lgRMFKEp9bNyz0WCJ/ONXCFmDvE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=HN5iaAnu; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="HN5iaAnu" ARC-Seal: i=1; a=rsa-sha256; t=1785293715; cv=none; d=zohomail.com; s=zohoarc; b=MWOcDqOu8qSN7wKhuYVjwGK7PxkI8jTbKmHM/r+Mxp0Hy1IVsLN6ow4UU/gMM2SHMytjusewAchiVX1pNZy38DqN3fYh/yqMVNgz0J2kztEXMiBj4pBPOnHI/lgZcncaX+YhIwjL4WcmZsfUsF592fSH+WL95Z5E++ey6bMFU9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785293715; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=BP5/wAbs63zBetMW8skc22XV1Xey5EptZ2k+GBHOSS4=; b=kRIyNkKhaSrwKS42VXLyYQuKlgSiAyO+kquDTFI6pcVxdtfMvuWWRkrNspfqPROglHhDC4MyCJrFFPiL1QLimrVAoH3PlMYRvqTXE5O7NdsSOKHuw6RJuTZQkawj5TxoKB9ygvz6xR6LkHcenspCoApmb5SNvBOJLbFDYVBU3jk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785293715; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=BP5/wAbs63zBetMW8skc22XV1Xey5EptZ2k+GBHOSS4=; b=HN5iaAnuTDITAtRQMg8pTR2+5Y5syt2HjRL9u2FKvQRGdrS3mDWdqx5oC9wtW/r2 KyySrCx3l+Ot1JTXyI8Ne5RymbXQ17GgCPw6TJD75Y++C0A9WtbgjLzfGjOD5odxp5S LDhLSIyuAqOdNrPIicwygELBpq7JMsjYJpP4+EtE= Received: by mx.zohomail.com with SMTPS id 178529371322340.34210520390218; Tue, 28 Jul 2026 19:55:13 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Wed, 29 Jul 2026 03:54:22 +0100 Subject: [PATCH v4 10/13] drm/panfrost: Move perfcnt GPU disable sequence into a helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260729-claude-fixes-v4-10-01968f2ec77a@collabora.com> References: <20260729-claude-fixes-v4-0-01968f2ec77a@collabora.com> In-Reply-To: <20260729-claude-fixes-v4-0-01968f2ec77a@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2779; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=4tGiJGWiK+TDM+P28WpbzF6ffBP1X3E56TrK7Eumeb4=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqaWtXumKOUpooa+B2E/TKXKl6CVC7n1CKKJQZe fyH9pmFgFOJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCamlrVwAKCRAOJn5M7lND PckJC/9m1YsxpiU+NjqtkEDKVSb3nG84Y2D5AZfpUuPxMSRX80NzrW2waiR21nvGG4UzKSFlgGV o9qGcK8t3XEJH/HWsk5XUzRGHacV3yS/hIpb3L1fUoTruQwQOi3q5B7UGd/nTt+dO4EydEnDZN3 tc39s8mJFsirFMa+fDYscG+0R8cfoyJAVt+0TqVsog6pzEFR2Bml3WOcEQu9LES1VVO5XsYsqyD 9/MqKkbU+90bQqxisUoWSH377s3nZbZLi8I862wo3EnLliVBmGXv/R/oTvLfAgFHiBmGSklN5Y8 s0ILSvJ6OlY2MdiZykr0hcS+T4WyOjlm3mxXI+QQxHRfdWhBcdFX6/HOLtig7akqXa4Oxp4OcCR Tt3Z9h2PAMblzxTwIaijYfefVfNfBfsIEUxo+jlTMYUxarxv3doblhNTS/DZATjNv0pHE1+PWv6 YCTf7s2SVvCJh2y7KpiFphaIAhcH6TQzB6aN8Siu1eyPqxx15aVOGMVRmR5yB6ajJWG/0= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Just for the sake of avoiding repetition. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 31 ++++++++++++----------------- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c index 7020c0192e18..ad1156678e91 100644 --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c @@ -35,6 +35,16 @@ struct panfrost_perfcnt { struct completion dump_comp; }; +static void panfrost_perfcnt_gpu_disable(struct panfrost_device *pfdev) +{ + gpu_write(pfdev, GPU_PERFCNT_CFG, + GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); + gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0x0); + gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0x0); + gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0x0); + gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); +} + void panfrost_perfcnt_clean_cache_done(struct panfrost_device *pfdev) { complete(&pfdev->perfcnt->dump_comp); @@ -193,12 +203,7 @@ static int panfrost_perfcnt_disable_locked(struct panfrost_device *pfdev, if (user != perfcnt->user) return -EINVAL; - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0x0); - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0x0); - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0x0); - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); - gpu_write(pfdev, GPU_PERFCNT_CFG, - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); + panfrost_perfcnt_gpu_disable(pfdev); perfcnt->user = NULL; drm_gem_vunmap(&perfcnt->mapping->obj->base.base, &map); @@ -327,12 +332,7 @@ int panfrost_perfcnt_init(struct panfrost_device *pfdev) perfcnt->bosize = size; /* Start with everything disabled. */ - gpu_write(pfdev, GPU_PERFCNT_CFG, - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); + panfrost_perfcnt_gpu_disable(pfdev); init_completion(&perfcnt->dump_comp); mutex_init(&perfcnt->lock); @@ -344,10 +344,5 @@ int panfrost_perfcnt_init(struct panfrost_device *pfdev) void panfrost_perfcnt_fini(struct panfrost_device *pfdev) { /* Disable everything before leaving. */ - gpu_write(pfdev, GPU_PERFCNT_CFG, - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0); - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); + panfrost_perfcnt_gpu_disable(pfdev); } -- 2.55.0