From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ECF23672AE for ; Wed, 29 Jul 2026 02:18:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785291505; cv=none; b=LBIvPwu0jwElWVUpXskON/f/U2kxAhien8qItoaKPKYtQ33mowBbvvb0xVVxsexNbGcq7dhOOT5TChFXRPSUiCr0ZPBpWB0SicAnMbJ41P/bJ/4LHJmEOtgDBZ/nIj84efXJn2ylLKPxoy4T4cnMgv+kXr6vfYb9M7zwGPPu2Qk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785291505; c=relaxed/simple; bh=6nkqDqAXcPS/8X6gEANTW4rGF9CCvG8ceg1mzWZa0xA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LNr2iH9OpybPWGmwKkJcpIvzwUxI6vgEWcjcBSFeHHYi31vJLWn0VYtsxdiK4CKZmE/W1gPD8eypMszauuVNImR+x6N1PRc4JQfPxvOEPqBSM04wWlqaeJoJP3sE+Yy8iSc9T0xeWfLRRY2+zpUyrkZS9/zwbQcFK5txCeIY/fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cqkF2XJK; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cqkF2XJK" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cc7e86e7aeso5505975ad.2 for ; Tue, 28 Jul 2026 19:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785291501; x=1785896301; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vnsZtjbV5skVSpYiYGDzFiuCt8jnr0IDD5NnHQhZM2A=; b=cqkF2XJKZTEbPCOMeXEv9MCr+3xfltSkgrZU+zLzzzumZJ5Eei3SFQXGKOxR+DeTnG gmxoVDLfPqXxgyUb5+xfHqOpnWZoHEe8TL+YSb2smpqnBvhy/XH2vEL9x1pFISmh9MH3 5s3rREz5nzHd1WOSHdajzLRKuISJC/ugzWJmGR/6iYD38ak9Z28ZTqigTy8GpLSnBusH rd8U2d1cDVtsGIJMSR9ItLfLc3cswW/tcbqWJw63c5oYoLf+mAtUC2188s49HkDfaY4S Qg+BXOKQqTECouYljLm8r/7Sj2M3wwcI2lsHM/2FKegfKxeMiUNH3gpwoN09dEaFnHOJ Pe/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785291501; x=1785896301; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vnsZtjbV5skVSpYiYGDzFiuCt8jnr0IDD5NnHQhZM2A=; b=n6sNNV/EQ8pdMKAkKSW/jHaxQGbMnvRprSvWeWJQA5E65bN+Rz1pXNdnlzsRNR41KG ozlPL4sdWNSrRj2pxaVM0sCV1yuvSIYV5ps9FD9TWQaf/LTKgJGCfWbBzMmsekK3UbWu jkq34KQRJDGEa+TnyPi0kxiZ6aauc3D8/OvORNbcIwWxkgW2VF5WqO9BidklrlPSQjBx pAyoG13vCDR0Fr6I/K9HLJKCN3ofGcSz6yotgHbBtHkZIoBpH+HRBP1CP0qU8OASKAD/ PWYWL6hEO4SUj9P6ZtzQXoYuj1NAk2sDKIZowrqR9KaBoB4o1QxqM8PTIQhXbDyUlV/w nexw== X-Forwarded-Encrypted: i=1; AHgh+Roehub7hswNvKlq54HMF8BUpBctlhCaUf6KWRbKVERLNwfgEw80M5FNxpopZx1IilVfuLlnCoX+LP5jzH4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3G7uRdkQLq9k89iJHDWtttYcfeceL0x3AyHQUTloE74DRBOcF O0kQbMVNKiLKmvsqSB/tG0IZQ1JIX43e2B/Iy+ic9dfACU3uluiZklkGUjTiaZg= X-Gm-Gg: AR+sD11BBsQOyIrucLLUO6GRDMctKczfTpgFZ/iKLe4rYfLZC+tW9Yp3kNJ/LOMZBwp jUud2BQqmxwKKEycTLOXwV+oaO9PXnE2DSx4LkrC7aunbSLCxFAqw4G/oN1SphzaAegIaZ66qjf 51TXmtklR7EBINFbHH+5yTvHU8Fw9FA5atoqDzpynywTtWH11p38/MNyBXgZtMNgkkfDnBQZHox kL8tdngZOSOw9lY2CuRK+LFELCnfb6zrH+TAFJKMfyusZpA4GZyP8irtc5CnQ5XQj+ZXD16jjM4 kMWHd1XEtNHqunO3OGnldXYv73BV4svzD16RCcwayB5kQizm5RjYPAwYwp76urGws8X4w5lVFWW RRn0W60Vm2rbZujDZ9T5zFuObDvhxcduEDXF1D7Pfh4/CCHCSBoOkkGwASUd3cNMGBeNUT9hJyj Yet2TmXWM4rtKB/WUR1gBdtscM3vEfK08DkAP+E1CLWcZ6n+Gv4taqpP72iGFu3lR9Er+BzaYzV kObreU9rLJRu4le81jGz7Hcj2ELmac2WTRpnSx4eU4my7He72V2trJhHsQ8FJMc9Wk89gJxWlq9 bgqKFH1cya5oxd2qjDWB9qKpStWpt2Il9Q== X-Received: by 2002:a17:902:ef07:b0:2cb:2b84:f431 with SMTP id d9443c01a7336-2d015d607d0mr57360965ad.47.1785291501453; Tue, 28 Jul 2026 19:18:21 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022c5096asm3778355ad.81.2026.07.28.19.18.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 28 Jul 2026 19:18:20 -0700 (PDT) From: Myeonghun Pak To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] rtc: m41t80: clean up watchdog on registration failure Date: Wed, 29 Jul 2026 11:18:12 +0900 Message-ID: <20260729021812.49868-1-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The watchdog miscdevice and reboot notifier are registered before the RTC device. If RTC device registration fails, probe returns without undoing either registration. The remove callback is not called after probe failure, leaving callbacks tied to a device whose driver failed to bind. Those callbacks continue to dereference the file-global save_client. Unregister the notifier and miscdevice before returning the RTC registration error. Fixes: 10d0c768cc6d ("rtc: m41t80: fix race conditions") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/rtc/rtc-m41t80.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c @@ -1008,8 +1008,15 @@ static int m41t80_probe(struct i2c_client *client) #endif rc = devm_rtc_register_device(m41t80_data->rtc); - if (rc) + if (rc) { +#ifdef CONFIG_RTC_DRV_M41T80_WDT + if (m41t80_data->features & M41T80_FEATURE_HT) { + unregister_reboot_notifier(&wdt_notifier); + misc_deregister(&wdt_dev); + } +#endif return rc; + } return 0; } -- 2.50.1