From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0C75BA45 for ; Wed, 29 Jul 2026 04:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785298629; cv=none; b=ZlvvcvT7KOhqLhe+KHcHdMsVh67uX/RefqzpT4j9T14DjJfm+6ivLxZmETTIzMcXZ4/GesVrNO0U2QKSgFGB4lSWUNvM8ZbPz0u+sfOm64VodfouPfofg4SuxcDMl4XibR8d8L4G2zXEZyoODq3fsoxQl/EPSoNPgwO7QCfVkIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785298629; c=relaxed/simple; bh=+f93yqpB0vWTCoxVOTnikZ42TYA/9hQHZf7/f9OTlIs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qq9Iw1sLIVQwx28O+5MzyIIwRicis+PR7B0NRn6eOHs+9qyvHRkmmtQG927tosHtkad7OL9ANGrkap6R89Oasgdm9AkAfx/dTRTWrYLsdi33pzxM1jpGVK2vMPXgOE9cIWuSYTboH69Df/nKFjwgg6BWpfZruo8cY32POKDSUAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CHmN7dIu; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CHmN7dIu" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ccf2360620so4956315ad.3 for ; Tue, 28 Jul 2026 21:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785298628; x=1785903428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cfXUKL6KEgJ9xC0lbVLlHmoRQoa/+Lwi/4872gF1r5g=; b=CHmN7dIuuj2RMBWlN5fJVKLsAU+WCRSyPb2BPtKwo3Z4W3hbypnRGMa3vw+0BmQu4e L4HyTt3RPKqHVioyJ803CW4pIWLusrfUCDhBBc6zjndNrPNiMJy+LeUrEVhJraJk8nBV qFCxam0irIJ1h2S8AFf20uMuFd0XvtanKoxK+ztMZsmRIk5PAqGjJ7vX9dlXvnh0EJgd EFB1/THElzwd461P2wCg62Ny83P7EPcIwLqBJrRIKT1M5/nxYBDRqLM8RA4VfUtzZhgC Hb3RS0jbWk1FpfT0sAdqJAR2hEvlOn/W8WiZAiiTVa9vpnHL3nP7GiJCHMh/rtU6pthe 5aEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785298628; x=1785903428; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cfXUKL6KEgJ9xC0lbVLlHmoRQoa/+Lwi/4872gF1r5g=; b=PppRDLahJsn8SbXkdpPs45yaTnQjRTJMontjbyk6o/zs+WuRI2+Kja+Z82YnWsSVey T9qUCG22hqDaQIYqv5RVPFUsU3hloweYlXmt8Pi6dKyRXa7XLQuO0TgIRw8X6pJSrV7l 9zFDp0lPVcmYueIYdZvjIF/JD96ttYEmkkRgg5XV9B2jtjBrEUIO2cPnWYuwSVA7Xgx4 1S1OWdg713VZnKDj2MTWEP0/5cn3jwHmcLna/n+Ki01OxppxdbjkD5MCD34+RVguJhz/ tmDAwTiJnYrZzEw97c7k9GnTe8slmm0365pXSEV6d6OdLTvRO7Ab4VgZJQiTOKdzIqpK DHGA== X-Forwarded-Encrypted: i=1; AHgh+Rr44pCVY3SwdNJdz/t3bNLIfcTkRzYDSadfefExCqLLDqnWvltm/P4SFkXECfP/ZILbcHcUV/LanLuXvo8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8ZvyiMDqcQHIuYGtpvG6dTKy+Qb6BtKeX0s7AloLbWW8f5CyF OfbnpP9H1HaB+/Cm9ML1UAj73BkeaXL8/5JPDVgAwOaJSv7S69rFBsY= X-Gm-Gg: AR+sD11hJCFGEjrI7QWJnQciF5NXi1JNk5QlBsbKwL7UHDrry1HkQNvvQpKuzREXxgu onX6H1L1PBMciKtSvV2eYx/h4mG6fpGM+SbhyS0mzzvw4iN1JL3Zso97bZPi1764daRUhFaaB6L 2YQztT6tbeDzsDcHEiPanfqi6xk8qtCwQEzPhyfIBa7VQ94vzak1cKNz0mxzxfn2Q5nJQlGwWcU N0JRnaeJgkRssyWBprWYA20IPeJ40iPHq7fb6SKEpxfOrW7b+ZP8cKmBUdlyX1hhHdtIefJrOGu QCoU+ovxAVOwsQdQ0hxcYhhWfaYIHCOYzO8VfgV2nQCySJWIZ3hBPwJm+M1YWKBbFLNG4g7TFVs b7MNy0xWizazNsknV2Kjc0+mhoR6nIpbuGCemK68lwCvrYfL2jdAt5rB2H0v9LOwN+D53rOE6r3 mRibs70JE6og8rj0B7hgZHU8P8QxVqevInQFLo6EXFQL1GNnZySa8+nNdThR7Yb3c5AsngNTRIT JyksuTrypUG0+yvBUc2E+cF6wlXMy4Zm9f5xicl X-Received: by 2002:a05:6a21:2d43:b0:39f:59c8:f302 with SMTP id adf61e73a8af0-3c8ba5d0a12mr6192619637.37.1785298627978; Tue, 28 Jul 2026 21:17:07 -0700 (PDT) Received: from localhost.localdomain ([2600:1700:88b0:bed0:1488:2a4e:85f:d739]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504b6d14bsm4507589eec.10.2026.07.28.21.17.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 28 Jul 2026 21:17:07 -0700 (PDT) From: Rochan Avlur To: Jaegeuk Kim , Chao Yu Cc: Christian Brauner , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rochan Avlur Subject: [PATCH] f2fs: use the mount idmap for the owner check in f2fs_xattr_advise_set() Date: Tue, 28 Jul 2026 21:16:56 -0700 Message-ID: <20260729041656.51967-1-rochan.avlur@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit f2fs_xattr_advise_set() calls inode_owner_or_capable() with &nop_mnt_idmap before allowing the advise xattr to be set, instead of the idmap that was passed into the handler. Since f2fs supports idmapped mounts, this compares the caller's fsuid against the unmapped on-disk owner rather than the mapped owner; resulting in the actual owner to be wrongly denied with -EPERM. Use the idmap argument that was already passed to the xattr handler instead. Fixes: 984fc4e76d63 ("f2fs: support idmapped mounts") Cc: stable@vger.kernel.org Signed-off-by: Rochan Avlur --- fs/f2fs/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 610d5810074d..281e2fd6c778 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -118,7 +118,7 @@ static int f2fs_xattr_advise_set(const struct xattr_handler *handler, unsigned char old_advise = F2FS_I(inode)->i_advise; unsigned char new_advise; - if (!inode_owner_or_capable(&nop_mnt_idmap, inode)) + if (!inode_owner_or_capable(idmap, inode)) return -EPERM; if (value == NULL) return -EINVAL; -- 2.45.2