From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8A6426689 for ; Wed, 29 Jul 2026 07:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785311000; cv=none; b=bUdYwn+kvW6lRNxQTPnEVGUD90CX/DPm1RIOxrhnMNWSLWl/B95zUlMFkhKJ8I37O8m4zlnVehZl2/enHziftz53Qp/CS5jtNhVvI2mX8c3o/gTqN0hoRlhMicg8Tlkc+KzbgkDkmi3bCa1QnjbDqGaaZ0/iCl55dizuqoZGcFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785311000; c=relaxed/simple; bh=f0pUjgm12YiKOE5OLRjG68BkleLUl5Q4EzBqr6bq87c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bJCPhejMP3916yxeSBLaJoZnuZgpaOwzEUsrt5E2QeYtBbCZxyIVLp8jw/icNwAubs2WTeyMAsNu498dF95bgJ1POmyIZHJmJD+saEbHBWtAaqL6udEZCiLTZdTWJKf7FMeeX9HYsUF0LsNCDmYahF/Km3hGvR3bdGIFPBLgDu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bqeMxr4Y; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bqeMxr4Y" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ce98cb8165so6733585ad.1 for ; Wed, 29 Jul 2026 00:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785310982; x=1785915782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DewgyYDAktvZQQjsN7FV0AudowESd3lzCpxYXEo/03A=; b=bqeMxr4YLtU4UZbKVCToKcpKL6jMxI6MXTSASje5jNKtgOihI6GdhX6F8EFdpDzkHM KWr6kQUMOduAGv7oXsEdGnY+L+wpL0kNF1VHgTOZm5D5TsmlPMrZ5J0ZUkR/6xgA99Nt CCU1DKLMwOjOuCNFMM5MpV/lbNte7jNjbXcTpyLOZF+kUbdH6v0o8wb9DoIWull9MqPW 7BogAHkjuOHPZYvZV+EYn2kCpYxz/XSdlSjjpojN/aNqsNXLWXMM6yQKQdsyNz5yaS3l aGrDCNf6iC8cRPuPCeLHHEuv51WJO7llwEcwaJ20q0iYE0e5TUoB64jjRKUxziYojEt1 izAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785310982; x=1785915782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DewgyYDAktvZQQjsN7FV0AudowESd3lzCpxYXEo/03A=; b=Rg0ItK/mswBzod7Wcy5gGMDm/6Ci/MOGrk1fkK5pbRTLLVcIJWC776HKtP4lmF4WRv 9/E5U+DMwIupZGn09UIdZLHBvPNERvo6ku3zwn1ObNI49zGSn5jKPob0x7J6kbZJ3agH pEKU9yZEPK6iEll2OtUk0vhf9fIuZrTZ/8p1XvCrj8zUbTSwfEi2ihE7T9Ov0H/XjKHQ z+Al1X7idJux0FpnQ/KkDMVwRREtXnOiNnpyKmdg0JJL9FZqwT8L/cYctcvIAsC5K27g nZqsVxJCV4Ac51bo3BEDGApe9cmYugvWsy7PIS9FW1quaMkYKAMkjt9xLV9hsyhBmewV ZdUQ== X-Forwarded-Encrypted: i=1; AHgh+RryqJUu8RbAd5s8fEWPdMEyVKCOkZ+7/2uQZDPNb7+vpui8kV7zqdjxlhMUigBSnvKgZ5nI5+ORVTQ5Fws=@vger.kernel.org X-Gm-Message-State: AOJu0Ywlg8hSq8gNgAnNc4pUqpDBFE6wJdkyk5ADhMnddeSz41c5FXIb MRDkFGQAy1AyOiC4Z0e2+zf7tDrrrBfHCZ1H+ZTN2dL/h1QOMKeuu6rl X-Gm-Gg: AR+sD13QyhdWyjvYStStebXTGa65D1DdzIugX0hU2u415Y6deVZ8eriZ/f1e/esRKXg IlgnP4A3lWRTqsA7ob2NdKyx1Exu2AJkQVhWsFuWK0IWZpXfmZ3jVytyKBguFylL3ED+VA/JnLw KsuOB54hT7VW69IhcZ8wxHRhKjZW8I5Q5nGGPjDv7/Wc4jOOlXa3jX/AJLDEKBBs8oXqbC4uH6r 2x0mGVr4KUrjWfl/X+jU9XYfHVpFd/aj4VVfuLPqi0stHABWThOyc2d/FKe8HwNAAKibDtTEGyD a60gyBFYMcnOnH5fEoNoYpuswU+P6uGPNCeoaQp/KyFZ9ibXm7wAkDJD30kQDLNtbF62u8uoQ/G LjDaxOZFMVOPhLdZdu8pgvM9OBQ7bVe0rm2bFuZP+J+ri7cITEr50a9dVRy7gTYjfak7vmHIvrW YsPOCWt+OMj+ersaiNNpmG3dBj9pFyX8N2sYYh/HKOUXJeGuAwmpkmJI+JNj4= X-Received: by 2002:a17:903:2282:b0:2ca:53f7:3c69 with SMTP id d9443c01a7336-2d0266945f4mr13611065ad.9.1785310981897; Wed, 29 Jul 2026 00:43:01 -0700 (PDT) Received: from server227.. ([39.170.101.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022bf888csm7154505ad.64.2026.07.29.00.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 00:43:01 -0700 (PDT) From: Zxyan Zhu To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Russell King , Russell King , Maxime Chevallier , Serge Semin , Romain Gantois , Hariprasad Kelam , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zxyan Zhu Subject: [PATCH net-next v3 2/2] net: phylink: allow PHYs to be attached in 802.3z inband mode Date: Wed, 29 Jul 2026 15:42:37 +0800 Message-Id: <20260729074237.2624940-3-zxyan0222@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260729074237.2624940-1-zxyan0222@gmail.com> References: <20260729074237.2624940-1-zxyan0222@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Russell King (Oracle)" Now that we have proper decision making for inband mode support which makes it a "best efforts" feature based on the capabilities of the PHY and PCS, we can relax whether we expect and permit a PHY to be attached. This is especially true for the 2500BASE-X case which some PHYs use without inband on their host side interface for 2.5G speeds, but use inband for slower speeds switching to SGMII on their host side interface. We already have such a case for some qcom-ethqos setups, although qcom-ethqos overrides phylink's inband settings by accessing the PCS directly at the moment. This should allow qcom-ethqos to transition to defaulting to inband when 2500BASE-X or SGMII is specified in its DTS. Allow PHYs to be attached when inband mode has been specified, which will be necessary to allow inband mode to be used on qcom-ethqos. Signed-off-by: Russell King (Oracle) Signed-off-by: Zxyan Zhu --- drivers/net/phy/phylink.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 59dfe35afa54..fd4e80eeeda7 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -1964,9 +1964,7 @@ EXPORT_SYMBOL_GPL(phylink_destroy); */ bool phylink_expects_phy(struct phylink *pl) { - if (pl->cfg_link_an_mode == MLO_AN_FIXED || - (pl->cfg_link_an_mode == MLO_AN_INBAND && - phy_interface_mode_is_8023z(pl->link_interface))) + if (pl->cfg_link_an_mode == MLO_AN_FIXED) return false; return true; } @@ -2205,9 +2203,7 @@ static int phylink_attach_phy(struct phylink *pl, struct phy_device *phy, { u32 flags = 0; - if (WARN_ON(pl->cfg_link_an_mode == MLO_AN_FIXED || - (pl->cfg_link_an_mode == MLO_AN_INBAND && - phy_interface_mode_is_8023z(interface) && !pl->sfp_bus))) + if (WARN_ON(pl->cfg_link_an_mode == MLO_AN_FIXED)) return -EINVAL; if (pl->phydev) -- 2.34.1