From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89F852DB7BB for ; Wed, 29 Jul 2026 10:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785319243; cv=none; b=LUZc51FeWdnVADwKuhMPA5H0RVZ00h2m10trxCYfqIXPXHO2XM1E3pWGTWyEr3ZEBgymAeoinURd9t/WQXc8BXwpWf5CgbBfrPw3GgNS+8WJovO619Cqk2jzmk4rZNN+4boG8FEMGpCez0beuca6NhgKRiYnXTAxoO1MIxFvStU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785319243; c=relaxed/simple; bh=DKbCAlhssGJh4pkG2mbkDT/DvJeebOH+P/5y3xrQXh0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lu945olj1tdZNeEu3f6pTvZWNW5YXpFBJgNm6mzqLrr0fqDk+UjLJer8GT2QmSxlDzecnzrEtK8EW9eiB4iURA/2KKLSl0ua2KZ0eiD8ki6VQm2+QmNR5582ATgD6UGP2LQJlIJMftSoBFNp8IHKEaYczxpn80j5ebyqaksc3t0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mx+Vzc86; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mx+Vzc86" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8423f236418so570422b3a.1 for ; Wed, 29 Jul 2026 03:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785319242; x=1785924042; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=MUO/O2E/uVyg5/m0Q7dOLhA/qCfX6zg2xUM83/9BydI=; b=mx+Vzc86VT9ngXuH/mywJo7fiqS4sa0QCABCPr4CYLoT7nwJdfrBdbf4fXxrc2nV4e 6Isd1V/L0KFo53bAoNQmw75xZlMCgzzYHDWeSSLYYEWcfySUClpGQAL/amOHd6aakhgd 5Uq5jjJ45ANQmLXMncxf9UdWEscHDnDDJUxN17SkO+Xh8aSTCbDzDXxGk5dBtizdRY0a 3PAg7ekt/eEYkA+o/aL5mLKsA1E0lOv3XriLiYse2nnWmuxyRDwLZlZuXX4Pd6zYUgIU 8cDKIVsxheEOVB226JUoJ7+W0Rb2W3r3BKRmaiKg96WCLQ/Ncal14glGICGqpWqYX/57 LCLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785319242; x=1785924042; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MUO/O2E/uVyg5/m0Q7dOLhA/qCfX6zg2xUM83/9BydI=; b=d+wzci26kUD4vFZq5EgMMQtVyLrar0r7oInQh0y97Y+hY7sMTUHu1MegEnnU3ACZ0/ 3a+CqKPnSCQdHYHRy1/kV79J20NoEOOs6YUSsWcui2hKv+PY2wkd/jvUyVdAaLlB7Zgy FxPvtI3/BRlj7nUJVISNvSpmOLwjgeouD8HVMDXdfCb6ALLrrRYFHR0BXNY3S8za75Nq I9j7KqUQ0OmUt2yk305mzQB3gaeuwhHthhQ3QOJR35b1j+rxwkPDGxN+yqDMp/XkUo5e m2vX2dTlCyiayVrfs98ILFGPD0NbV9yLvUlkLu42z+qw3Y6UlOuUM0d5kXlDyWSTt1LU poPw== X-Gm-Message-State: AOJu0YwmQyKhdna1iNHna3xjXvXYMxRfEvPhIe/mrX6724jEud/xj6mt RK9wb/l5pykbRtd0977EcIc6npjh/ni8+Cx1kSLAV5iv7zmJ0SGZ+b7X X-Gm-Gg: AR+sD10rvEf3xD2PMcDpj2vzZL4EMBtnFz+nrQD0QsFYcC5HckpaIy1ToT+/x/RO/CK W7Shx8xqHAhmcDO1ZG5hTtJ5Dguq1fIIBJzriedXYOZRnyoktpE9Lyp7W6FOjRTIHgWaoyFu6vo Q4MjcCbL9g7Em221NP6l20TdSNjNhhk4UcGTY2hJRLASummuyYkq/bJnUmW/1Jrvp0PuX4o0Qfv BzzXcCtNL8h79JDeJShgBxT4HIhpzy5Cl62V2mOT0cdDIDNyJXKoPWyngCpgDDjX45AzTp+EgQF lAF/+VJ5V+JPYQ7b1HJXGSl/qUsGWUTURyc/ebwrIG4IqrLRRdngi4gQDF45TkI9vqyEC8ygOPQ G2W2I423WdsIOW/pCe32UoGKWNB/LeFuPhy/5p6AXIoH0vadi1g1mZUja4mxPAM5m2kHXh5MNui ZHmX+c1C4F/oZSR+z+0zlPMGEP8npqPU4cSuVIDteSjLl7rzmFGtAYSaPPUUGSrcKZ0YWeAI2JX uD4y6bae/KM6k3Amqat4yZtKzagPoZX+i5s2ZC7zufr6qiffBlx9JtgtBx9yg1UK9JnjxQaas5z oo8h X-Received: by 2002:aa7:914d:0:b0:848:86d6:298b with SMTP id d2e1a72fcca58-84e9316b4femr6395032b3a.29.1785319241282; Wed, 29 Jul 2026 03:00:41 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbdb7b8df4fsm654781a12.2.2026.07.29.03.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 03:00:41 -0700 (PDT) From: phucduc.bui@gmail.com To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] regulator: rt6245: Restore state on enable failure Date: Wed, 29 Jul 2026 17:00:18 +0700 Message-ID: <20260729100018.66577-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Currently, if regcache_sync() fails after the enable GPIO has been asserted, the driver returns with enable_gpio still set high and regcache_cache_only() left disabled. This leaves the device state inconsistent with the disabled state, where the enable GPIO is low and cache_only is enabled. On failure, restore the original state by setting cache_only back to true and driving the enable GPIO low before returning the error. Signed-off-by: bui duc phuc --- drivers/regulator/rt6245-regulator.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/rt6245-regulator.c b/drivers/regulator/rt6245-regulator.c index 1843ecec1922..5c0ee04e97ac 100644 --- a/drivers/regulator/rt6245-regulator.c +++ b/drivers/regulator/rt6245-regulator.c @@ -49,8 +49,11 @@ static int rt6245_enable(struct regulator_dev *rdev) regcache_cache_only(regmap, false); ret = regcache_sync(regmap); - if (ret) + if (ret) { + regcache_cache_only(regmap, true); + gpiod_direction_output(priv->enable_gpio, 0); return ret; + } priv->enable_state = true; return 0; -- 2.43.0